commit 2f3112258587fb89a91ddf372372f9d2ef8876e0
author Andrzej Kurek <andrzej.kurek@arm.com> Mon Nov 19 18:04:01 2018 -0500
committer Andrzej Kurek <andrzej.kurek@arm.com> Thu Nov 22 12:43:53 2018 -0500
tree c11fb9373996cdc1a6b47339af3c668bd3f0a6c2
parent c3de438b8eec7a94931442eedcbb6b998247bea4

Cosmetic changes

Adjust whitespaces, reduce test dependencies and reduce buffer size passed by 1.

library/pkwrite.c

diff --git a/library/pkwrite.c b/library/pkwrite.c
index d135060..dcd3263 100644
--- a/library/pkwrite.c
+++ b/library/pkwrite.c
@@ -168,11 +168,11 @@
     if( mbedtls_pk_get_type( key ) == MBEDTLS_PK_OPAQUE )
     {
         size_t buffer_size = *p - start;
-        psa_key_slot_t* key_slot = ( psa_key_slot_t* ) key->pk_ctx;
+        psa_key_slot_t* key_slot = (psa_key_slot_t*) key->pk_ctx;
         if ( psa_export_public_key( *key_slot, start, buffer_size, &len )
              != PSA_SUCCESS )
         {
-            return MBEDTLS_ERR_PK_BAD_INPUT_DATA;
+            return( MBEDTLS_ERR_PK_BAD_INPUT_DATA );
         }
         else
         {

tests/suites/test_suite_x509write.data

diff --git a/tests/suites/test_suite_x509write.data b/tests/suites/test_suite_x509write.data
index c932c68..4096425 100644
--- a/tests/suites/test_suite_x509write.data
+++ b/tests/suites/test_suite_x509write.data
@@ -43,7 +43,7 @@
 x509_csr_check:"data_files/server5.key":"data_files/server5.req.ku.sha1":MBEDTLS_MD_SHA1:MBEDTLS_X509_KU_DIGITAL_SIGNATURE | MBEDTLS_X509_KU_NON_REPUDIATION:0
 
 Certificate Request check opaque Server5 ECDSA, key_usage
-depends_on:MBEDTLS_SHA256_C:MBEDTLS_ECDSA_C:MBEDTLS_ECDSA_DETERMINISTIC:MBEDTLS_ECP_DP_SECP256R1_ENABLED:MBEDTLS_USE_PSA_CRYPTO
+depends_on:MBEDTLS_SHA256_C:MBEDTLS_ECDSA_C:MBEDTLS_ECP_DP_SECP256R1_ENABLED
 x509_csr_check_opaque:"data_files/server5.key":MBEDTLS_MD_SHA256:MBEDTLS_X509_KU_DIGITAL_SIGNATURE | MBEDTLS_X509_KU_NON_REPUDIATION:0
 
 Certificate write check Server1 SHA1

tests/suites/test_suite_x509write.function

diff --git a/tests/suites/test_suite_x509write.function b/tests/suites/test_suite_x509write.function
index f1aeaa0..8fe3b84 100644
--- a/tests/suites/test_suite_x509write.function
+++ b/tests/suites/test_suite_x509write.function
@@ -45,12 +45,17 @@
 
     md_info = mbedtls_md_info_from_type( csr.sig_md );
     if( mbedtls_md( md_info, csr.cri.p, csr.cri.len, hash ) != 0 )
-        return ( MBEDTLS_ERR_X509_BAD_INPUT_DATA );/* Note: this can't happen except after an internal error */
+    {
+        /* Note: this can't happen except after an internal error */
+        return( MBEDTLS_ERR_X509_BAD_INPUT_DATA );
+    }
 
     if( mbedtls_pk_verify_ext( csr.sig_pk, csr.sig_opts, &csr.pk,
                        csr.sig_md, hash, mbedtls_md_get_size( md_info ),
                        csr.sig.p, csr.sig.len ) != 0 )
+    {
         return( MBEDTLS_ERR_X509_CERT_VERIFY_FAILED );
+    }
 
     return( 0 );
 }
@@ -156,13 +161,13 @@
     if( cert_type != 0 )
         TEST_ASSERT( mbedtls_x509write_csr_set_ns_cert_type( &req, cert_type ) == 0 );
 
-    ret = mbedtls_x509write_csr_pem( &req, buf, sizeof( buf ),
+    ret = mbedtls_x509write_csr_pem( &req, buf, sizeof( buf ) - 1,
                              rnd_pseudo_rand, &rnd_info );
     TEST_ASSERT( ret == 0 );
 
     pem_len = strlen( (char *) buf );
     buf[pem_len] = '\0';
-    TEST_ASSERT( x509_crt_verifycsr( buf, pem_len+1 ) == 0 );
+    TEST_ASSERT( x509_crt_verifycsr( buf, pem_len + 1 ) == 0 );
 
 exit:
     mbedtls_x509write_csr_free( &req );