Address review comments
diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh
index 78e123c..63fbea2 100755
--- a/tests/scripts/all.sh
+++ b/tests/scripts/all.sh
@@ -683,17 +683,17 @@
}
component_test_no_resumption () {
- msg "build: Default + !MBEDTLS_SSL_SESSION_RESUMPTION (ASan build)" # ~ 6 min
+ msg "build: Default + MBEDTLS_SSL_NO_SESSION_RESUMPTION (ASan build)" # ~ 6 min
scripts/config.pl unset MBEDTLS_SSL_SESSION_TICKETS
- scripts/config.pl unset MBEDTLS_SSL_SESSION_CACHE
- scripts/config.pl unset MBEDTLS_SSL_SESSION_RESUMPTION
+ scripts/config.pl set MBEDTLS_SSL_NO_SESSION_CACHE
+ scripts/config.pl set MBEDTLS_SSL_NO_SESSION_RESUMPTION
CC=gcc cmake -D CMAKE_BUILD_TYPE:String=Asan .
make
- msg "test: !MBEDTLS_SSL_SESSION_RESUMPTION - main suites (inc. selftests) (ASan build)" # ~ 50s
+ msg "test: MBEDTLS_SSL_NO_SESSION_RESUMPTION - main suites (inc. selftests) (ASan build)" # ~ 50s
make test
- msg "test: !MBEDTLS_SSL_SESSION_RESUMPTION - ssl-opt.sh (ASan build)" # ~ 6 min
+ msg "test: MBEDTLS_SSL_NO_SESSION_RESUMPTION - ssl-opt.sh (ASan build)" # ~ 6 min
if_build_succeeded tests/ssl-opt.sh
}
diff --git a/tests/ssl-opt.sh b/tests/ssl-opt.sh
index a3c189d..0dd9a87 100755
--- a/tests/ssl-opt.sh
+++ b/tests/ssl-opt.sh
@@ -916,7 +916,7 @@
# ("signature_algorithm ext: 6" means SHA-512 (highest common hash))
run_test "Default" \
"$P_SRV debug_level=3" \
- "$P_CLI debug_level=3" \
+ "$P_CLI" \
0 \
-s "Protocol is TLSv1.2" \
-s "Ciphersuite is TLS-ECDHE-RSA-WITH-CHACHA20-POLY1305-SHA256" \
@@ -2206,7 +2206,7 @@
# Tests for Session Tickets
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets: basic" \
"$P_SRV debug_level=3 tickets=1" \
@@ -2222,7 +2222,7 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets: cache disabled" \
"$P_SRV debug_level=3 tickets=1 cache_max=0" \
@@ -2238,7 +2238,7 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets: timeout" \
"$P_SRV debug_level=3 tickets=1 cache_max=0 ticket_timeout=1" \
@@ -2254,7 +2254,7 @@
-S "a session has been resumed" \
-C "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets: session copy" \
"$P_SRV debug_level=3 tickets=1 cache_max=0" \
@@ -2270,7 +2270,7 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets: openssl server" \
"$O_SRV" \
@@ -2281,7 +2281,7 @@
-c "parse new session ticket" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets: openssl client" \
"$P_SRV debug_level=3 tickets=1" \
@@ -2297,7 +2297,7 @@
# Tests for Session Tickets with DTLS
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets, DTLS: basic" \
"$P_SRV debug_level=3 dtls=1 tickets=1" \
@@ -2313,7 +2313,7 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets, DTLS: cache disabled" \
"$P_SRV debug_level=3 dtls=1 tickets=1 cache_max=0" \
@@ -2329,7 +2329,7 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets, DTLS: timeout" \
"$P_SRV debug_level=3 dtls=1 tickets=1 cache_max=0 ticket_timeout=1" \
@@ -2345,7 +2345,7 @@
-S "a session has been resumed" \
-C "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets, DTLS: session copy" \
"$P_SRV debug_level=3 dtls=1 tickets=1 cache_max=0" \
@@ -2361,7 +2361,7 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets, DTLS: openssl server" \
"$O_SRV -dtls1" \
@@ -2372,7 +2372,7 @@
-c "parse new session ticket" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
run_test "Session resume using tickets, DTLS: openssl client" \
"$P_SRV dtls=1 debug_level=3 tickets=1" \
@@ -2388,9 +2388,9 @@
# Tests for Session Resume based on session-ID and cache
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: tickets enabled on client" \
"$P_SRV debug_level=3 tickets=0" \
"$P_CLI debug_level=3 tickets=1 reconnect=1" \
@@ -2405,9 +2405,9 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: tickets enabled on server" \
"$P_SRV debug_level=3 tickets=1" \
"$P_CLI debug_level=3 tickets=0 reconnect=1" \
@@ -2422,8 +2422,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: cache_max=0" \
"$P_SRV debug_level=3 tickets=0 cache_max=0" \
"$P_CLI debug_level=3 tickets=0 reconnect=1" \
@@ -2433,8 +2433,8 @@
-S "a session has been resumed" \
-C "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: cache_max=1" \
"$P_SRV debug_level=3 tickets=0 cache_max=1" \
"$P_CLI debug_level=3 tickets=0 reconnect=1" \
@@ -2444,8 +2444,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: timeout > delay" \
"$P_SRV debug_level=3 tickets=0" \
"$P_CLI debug_level=3 tickets=0 reconnect=1 reco_delay=0" \
@@ -2455,8 +2455,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: timeout < delay" \
"$P_SRV debug_level=3 tickets=0 cache_timeout=1" \
"$P_CLI debug_level=3 tickets=0 reconnect=1 reco_delay=2" \
@@ -2466,8 +2466,8 @@
-S "a session has been resumed" \
-C "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: no timeout" \
"$P_SRV debug_level=3 tickets=0 cache_timeout=0" \
"$P_CLI debug_level=3 tickets=0 reconnect=1 reco_delay=2" \
@@ -2477,8 +2477,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: session copy" \
"$P_SRV debug_level=3 tickets=0" \
"$P_CLI debug_level=3 tickets=0 reconnect=1 reco_mode=0" \
@@ -2488,8 +2488,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: openssl client" \
"$P_SRV debug_level=3 tickets=0" \
"( $O_CLI -sess_out $SESSION; \
@@ -2502,8 +2502,8 @@
-S "session successfully restored from ticket" \
-s "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache: openssl server" \
"$O_SRV" \
"$P_CLI debug_level=3 tickets=0 reconnect=1" \
@@ -2514,9 +2514,9 @@
# Tests for Session Resume based on session-ID and cache, DTLS
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: tickets enabled on client" \
"$P_SRV dtls=1 debug_level=3 tickets=0" \
"$P_CLI dtls=1 debug_level=3 tickets=1 reconnect=1" \
@@ -2531,9 +2531,9 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: tickets enabled on server" \
"$P_SRV dtls=1 debug_level=3 tickets=1" \
"$P_CLI dtls=1 debug_level=3 tickets=0 reconnect=1" \
@@ -2548,8 +2548,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: cache_max=0" \
"$P_SRV dtls=1 debug_level=3 tickets=0 cache_max=0" \
"$P_CLI dtls=1 debug_level=3 tickets=0 reconnect=1" \
@@ -2559,8 +2559,8 @@
-S "a session has been resumed" \
-C "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: cache_max=1" \
"$P_SRV dtls=1 debug_level=3 tickets=0 cache_max=1" \
"$P_CLI dtls=1 debug_level=3 tickets=0 reconnect=1" \
@@ -2570,8 +2570,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: timeout > delay" \
"$P_SRV dtls=1 debug_level=3 tickets=0" \
"$P_CLI dtls=1 debug_level=3 tickets=0 reconnect=1 reco_delay=0" \
@@ -2581,8 +2581,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: timeout < delay" \
"$P_SRV dtls=1 debug_level=3 tickets=0 cache_timeout=1" \
"$P_CLI dtls=1 debug_level=3 tickets=0 reconnect=1 reco_delay=2" \
@@ -2592,8 +2592,8 @@
-S "a session has been resumed" \
-C "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: no timeout" \
"$P_SRV dtls=1 debug_level=3 tickets=0 cache_timeout=0" \
"$P_CLI dtls=1 debug_level=3 tickets=0 reconnect=1 reco_delay=2" \
@@ -2603,8 +2603,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: session copy" \
"$P_SRV dtls=1 debug_level=3 tickets=0" \
"$P_CLI dtls=1 debug_level=3 tickets=0 reconnect=1 reco_mode=0" \
@@ -2614,8 +2614,8 @@
-s "a session has been resumed" \
-c "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: openssl client" \
"$P_SRV dtls=1 debug_level=3 tickets=0" \
"( $O_CLI -dtls1 -sess_out $SESSION; \
@@ -2628,8 +2628,8 @@
-S "session successfully restored from ticket" \
-s "a session has been resumed"
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "Session resume using cache, DTLS: openssl server" \
"$O_SRV -dtls1" \
"$P_CLI dtls=1 debug_level=3 tickets=0 reconnect=1" \
@@ -8074,9 +8074,9 @@
-c "HTTP/1.0 200 OK"
client_needs_more_time 4
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "DTLS proxy: 3d, min handshake, resumption" \
-p "$P_PXY drop=5 delay=5 duplicate=5" \
"$P_SRV dtls=1 dgram_packing=0 hs_timeout=500-10000 tickets=0 auth_mode=none \
@@ -8091,9 +8091,9 @@
-c "HTTP/1.0 200 OK"
client_needs_more_time 4
-requires_config_enabled MBEDTLS_SSL_SESSION_RESUMPTION
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_RESUMPTION
requires_config_enabled MBEDTLS_SSL_SESSION_TICKETS
-requires_config_enabled MBEDTLS_SSL_SESSION_CACHE
+requires_config_disabled MBEDTLS_SSL_NO_SESSION_CACHE
run_test "DTLS proxy: 3d, min handshake, resumption, nbio" \
-p "$P_PXY drop=5 delay=5 duplicate=5" \
"$P_SRV dtls=1 dgram_packing=0 hs_timeout=500-10000 tickets=0 auth_mode=none \