commit 23e64f226bf01c6f913ea64dc333858bcc4d7dad
author Gilles Peskine <Gilles.Peskine@arm.com> Mon Feb 25 21:24:27 2019 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Wed Feb 27 11:03:25 2019 +0100
tree 91a45ba686c1cf3fdb2e0a9488172b21f97683e0
parent 1e9698af4b8b6d393f9537dfea0708cfe9306d42

check-files.py: readability improvement in permission check

tests/scripts/check-files.py

diff --git a/tests/scripts/check-files.py b/tests/scripts/check-files.py
index 19fc528..00fd0ed 100755
--- a/tests/scripts/check-files.py
+++ b/tests/scripts/check-files.py
@@ -91,8 +91,9 @@
     heading = "Incorrect permissions:"
 
     def check_file_for_issue(self, filepath):
-        if not (os.access(filepath, os.X_OK) ==
-                filepath.endswith((".sh", ".pl", ".py"))):
+        is_executable = os.access(filepath, os.X_OK)
+        should_be_executable = filepath.endswith((".sh", ".pl", ".py"))
+        if is_executable != should_be_executable:
             self.files_with_issues[filepath] = None