Remove useless null checks of data_t* parameters
The test framework never passes NULL for a data_t* parameter, so
testing them against NULL is clutter.
diff --git a/tests/suites/test_suite_psa_crypto.function b/tests/suites/test_suite_psa_crypto.function
index cf0dd80..c194a07 100644
--- a/tests/suites/test_suite_psa_crypto.function
+++ b/tests/suites/test_suite_psa_crypto.function
@@ -877,7 +877,6 @@
psa_status_t expected_status = expected_status_arg;
psa_status_t status;
- TEST_ASSERT( data != NULL );
PSA_ASSERT( psa_crypto_init( ) );
PSA_ASSERT( psa_allocate_key( type, KEY_BITS_FROM_DATA( type, data ),
@@ -995,7 +994,6 @@
size_t got_bits;
psa_key_policy_t policy;
- TEST_ASSERT( data != NULL );
export_size = (ptrdiff_t) data->len + export_size_delta;
ASSERT_ALLOC( exported, export_size );
if( ! canonical_input )
@@ -2005,10 +2003,6 @@
TEST_ASSERT( expected_mac->len <= PSA_MAC_MAX_SIZE );
- TEST_ASSERT( key != NULL );
- TEST_ASSERT( input != NULL );
- TEST_ASSERT( expected_mac != NULL );
-
PSA_ASSERT( psa_crypto_init( ) );
PSA_ASSERT( psa_allocate_key( key_type, PSA_BYTES_TO_BITS( key->len ),
@@ -2090,10 +2084,6 @@
psa_cipher_operation_t operation;
psa_key_policy_t policy;
- TEST_ASSERT( key != NULL );
- TEST_ASSERT( input != NULL );
- TEST_ASSERT( expected_output != NULL );
-
iv_size = PSA_BLOCK_CIPHER_BLOCK_SIZE( key_type );
memset( iv, 0x2a, iv_size );
@@ -2162,10 +2152,6 @@
psa_cipher_operation_t operation;
psa_key_policy_t policy;
- TEST_ASSERT( key != NULL );
- TEST_ASSERT( input != NULL );
- TEST_ASSERT( expected_output != NULL );
-
iv_size = PSA_BLOCK_CIPHER_BLOCK_SIZE( key_type );
memset( iv, 0x2a, iv_size );
@@ -2237,10 +2223,6 @@
psa_cipher_operation_t operation;
psa_key_policy_t policy;
- TEST_ASSERT( key != NULL );
- TEST_ASSERT( input != NULL );
- TEST_ASSERT( expected_output != NULL );
-
iv_size = PSA_BLOCK_CIPHER_BLOCK_SIZE( key_type );
memset( iv, 0x2a, iv_size );
@@ -2314,10 +2296,6 @@
psa_cipher_operation_t operation;
psa_key_policy_t policy;
- TEST_ASSERT( key != NULL );
- TEST_ASSERT( input != NULL );
- TEST_ASSERT( expected_output != NULL );
-
iv_size = PSA_BLOCK_CIPHER_BLOCK_SIZE( key_type );
memset( iv, 0x2a, iv_size );
@@ -2390,9 +2368,6 @@
psa_cipher_operation_t operation2;
psa_key_policy_t policy;
- TEST_ASSERT( key != NULL );
- TEST_ASSERT( input != NULL );
-
PSA_ASSERT( psa_crypto_init( ) );
PSA_ASSERT( psa_allocate_key( key_type, PSA_BYTES_TO_BITS( key->len ),
@@ -2479,9 +2454,6 @@
psa_cipher_operation_t operation2;
psa_key_policy_t policy;
- TEST_ASSERT( key != NULL );
- TEST_ASSERT( input != NULL );
-
PSA_ASSERT( psa_crypto_init( ) );
PSA_ASSERT( psa_allocate_key( key_type, PSA_BYTES_TO_BITS( key->len ),
@@ -2583,11 +2555,6 @@
psa_status_t expected_result = expected_result_arg;
psa_key_policy_t policy;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( input_data != NULL );
- TEST_ASSERT( nonce != NULL );
- TEST_ASSERT( additional_data != NULL );
-
output_size = input_data->len + tag_length;
ASSERT_ALLOC( output_data, output_size );
@@ -2655,12 +2622,6 @@
size_t tag_length = 16;
psa_key_policy_t policy;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( input_data != NULL );
- TEST_ASSERT( additional_data != NULL );
- TEST_ASSERT( nonce != NULL );
- TEST_ASSERT( expected_result != NULL );
-
output_size = input_data->len + tag_length;
ASSERT_ALLOC( output_data, output_size );
@@ -2712,12 +2673,6 @@
psa_key_policy_t policy;
psa_status_t expected_result = expected_result_arg;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( input_data != NULL );
- TEST_ASSERT( additional_data != NULL );
- TEST_ASSERT( nonce != NULL );
- TEST_ASSERT( expected_data != NULL );
-
output_size = input_data->len + tag_length;
ASSERT_ALLOC( output_data, output_size );
@@ -2782,10 +2737,6 @@
size_t signature_length = 0xdeadbeef;
psa_key_policy_t policy;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( input_data != NULL );
- TEST_ASSERT( output_data != NULL );
-
PSA_ASSERT( psa_crypto_init( ) );
PSA_ASSERT( psa_allocate_key( key_type,
@@ -2841,9 +2792,6 @@
size_t signature_length = 0xdeadbeef;
psa_key_policy_t policy;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( input_data != NULL );
-
ASSERT_ALLOC( signature, signature_size );
PSA_ASSERT( psa_crypto_init( ) );
@@ -2962,10 +2910,6 @@
TEST_ASSERT( signature_data->len <= PSA_ASYMMETRIC_SIGNATURE_MAX_SIZE );
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( hash_data != NULL );
- TEST_ASSERT( signature_data != NULL );
-
PSA_ASSERT( psa_crypto_init( ) );
PSA_ASSERT( psa_allocate_key( key_type,
@@ -3002,10 +2946,6 @@
psa_status_t expected_status = expected_status_arg;
psa_key_policy_t policy;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( hash_data != NULL );
- TEST_ASSERT( signature_data != NULL );
-
PSA_ASSERT( psa_crypto_init( ) );
PSA_ASSERT( psa_allocate_key( key_type,
@@ -3124,9 +3064,6 @@
size_t output2_length = ~0;
psa_key_policy_t policy;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( input_data != NULL );
-
PSA_ASSERT( psa_crypto_init( ) );
PSA_ASSERT( psa_allocate_key( key_type,
@@ -3195,10 +3132,6 @@
size_t output_length = ~0;
psa_key_policy_t policy;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( input_data != NULL );
- TEST_ASSERT( expected_data != NULL );
-
output_size = key_data->len;
ASSERT_ALLOC( output, output_size );
@@ -3266,9 +3199,6 @@
psa_status_t expected_status = expected_status_arg;
psa_key_policy_t policy;
- TEST_ASSERT( key_data != NULL );
- TEST_ASSERT( input_data != NULL );
-
output_size = key_data->len;
ASSERT_ALLOC( output, output_size );