commit 1898b68f09c77aacc6fe04331f82aa446ddf690b
author Hanno Becker <hanno.becker@arm.com> Fri Feb 22 16:03:29 2019 +0000
committer Hanno Becker <hanno.becker@arm.com> Tue Jun 25 09:06:26 2019 +0100
tree d76b376126349a0140966c6c0105f8876b631cd7
parent c84fd1cd95160520089eecd075eefe6baee4bfef

Allow NULL pointer in mbedtls_x509_get_sig_alg if params not needed

Also, set `sig_opts` pointer to `NULL` if no signature algorithm
parameters are given (to reflect exactly that).

library/x509.c

diff --git a/library/x509.c b/library/x509.c
index f2b6c7b..be170bb 100644
--- a/library/x509.c
+++ b/library/x509.c
@@ -811,9 +811,6 @@
 {
     int ret;
 
-    if( *sig_opts != NULL )
-        return( MBEDTLS_ERR_X509_BAD_INPUT_DATA );
-
     if( ( ret = mbedtls_oid_get_sig_alg( sig_oid, md_alg, pk_alg ) ) != 0 )
         return( MBEDTLS_ERR_X509_UNKNOWN_SIG_ALG + ret );
 
@@ -836,7 +833,10 @@
             return( ret );
         }
 
-        *sig_opts = (void *) pss_opts;
+        if( sig_opts != NULL )
+            *sig_opts = (void *) pss_opts;
+        else
+            mbedtls_free( pss_opts );
     }
     else
 #endif /* MBEDTLS_X509_RSASSA_PSS_SUPPORT */
@@ -844,7 +844,10 @@
         /* Make sure parameters are absent or NULL */
         if( ( sig_params->tag != MBEDTLS_ASN1_NULL && sig_params->tag != 0 ) ||
               sig_params->len != 0 )
-        return( MBEDTLS_ERR_X509_INVALID_ALG );
+            return( MBEDTLS_ERR_X509_INVALID_ALG );
+
+        if( sig_opts != NULL )
+            *sig_opts = NULL;
     }
 
     return( 0 );