commit 185e5163098f078b5c1eea442a9189f70da16d35
author Hanno Becker <hanno.becker@arm.com> Wed Dec 19 09:48:50 2018 +0000
committer Hanno Becker <hanno.becker@arm.com> Wed Dec 19 09:48:50 2018 +0000
tree c054af529b9c04a3cdc9721960fe19e555f2e7a9
parent 8ce3d939be5e3d53a5280f53aaaf411e8458b9a4

Minor fixes to ECJPAKE parameter validation

include/mbedtls/ecjpake.h

diff --git a/include/mbedtls/ecjpake.h b/include/mbedtls/ecjpake.h
index cf4ab87..f929164 100644
--- a/include/mbedtls/ecjpake.h
+++ b/include/mbedtls/ecjpake.h
@@ -110,8 +110,8 @@
  *                  #MBEDTLS_ECJPAKE_CLIENT or #MBEDTLS_ECJPAKE_SERVER.
  * \param hash      The identifier of the hash function to use,
  *                  for example #MBEDTLS_MD_SHA256.
- * \param curve     The identifier of the Telliptic curve to use,
- *                  for example #MBEDTLS_ECP_DP_SECP192K1.
+ * \param curve     The identifier of the elliptic curve to use,
+ *                  for example #MBEDTLS_ECP_DP_SECP256R1.
  * \param secret    The pre-shared secret (passphrase). This must be
  *                  a readable buffer of length \p len Bytes, but need
  *                  only be valid for the duration of this call. It may
@@ -209,7 +209,7 @@
  *                  (TLS: contents of the Client/ServerKeyExchange).
  *
  * \param ctx       The ECJPAKE context to use. This must be initialized
- *                  and set up and have performed roudn one.
+ *                  and set up and have performed round one.
  * \param buf       The buffer holding the second round message. This must
  *                  be a readable buffer of length \p len Bytes.
  * \param len       The length in Bytes of \p buf.

library/ecjpake.c

diff --git a/library/ecjpake.c b/library/ecjpake.c
index c5ab4cb..be941b1 100644
--- a/library/ecjpake.c
+++ b/library/ecjpake.c
@@ -111,6 +111,7 @@
                            size_t len )
 {
     int ret;
+
     ECJPAKE_VALIDATE_RET( ctx != NULL );
     ECJPAKE_VALIDATE_RET( role == MBEDTLS_ECJPAKE_CLIENT ||
                           role == MBEDTLS_ECJPAKE_SERVER );
@@ -579,6 +580,7 @@
     const unsigned char *end = buf + len;
     mbedtls_ecp_group grp;
     mbedtls_ecp_point G;    /* C: GB, S: GA */
+
     ECJPAKE_VALIDATE_RET( ctx != NULL );
     ECJPAKE_VALIDATE_RET( buf != NULL );
 
@@ -673,6 +675,7 @@
     unsigned char *p = buf;
     const unsigned char *end = buf + len;
     size_t ec_len;
+
     ECJPAKE_VALIDATE_RET( ctx   != NULL );
     ECJPAKE_VALIDATE_RET( buf   != NULL );
     ECJPAKE_VALIDATE_RET( olen  != NULL );
@@ -752,6 +755,7 @@
     mbedtls_mpi m_xm2_s, one;
     unsigned char kx[MBEDTLS_ECP_MAX_BYTES];
     size_t x_bytes;
+
     ECJPAKE_VALIDATE_RET( ctx   != NULL );
     ECJPAKE_VALIDATE_RET( buf   != NULL );
     ECJPAKE_VALIDATE_RET( olen  != NULL );