commit 14d85644020ff2858e60b179f7952f5d37b98bf1
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Mon Jul 15 11:01:14 2013 +0200
committer Paul Bakker <p.j.bakker@polarssl.org> Wed Jul 17 15:59:44 2013 +0200
tree 481eaf3d0f566c0c2266619722d9d1f6a966f12b
parent 4f47538ad8c186cae1bc2f06ee143183bb6961c2

Fix overflow check in oid_get_numeric_string()

(The fix in 791eed3 was wrong.)

library/oid.c

diff --git a/library/oid.c b/library/oid.c
index 366720e..750ece8 100644
--- a/library/oid.c
+++ b/library/oid.c
@@ -591,8 +591,7 @@
     for( i = 1; i < oid->len; i++ )
     {
         /* Prevent overflow in value. */
-        unsigned int v = value << 7;
-        if ( v < value )
+        if ( ( ( value << 7 ) >> 7 ) != value )
             return( POLARSSL_ERR_DEBUG_BUF_TOO_SMALL );
 
         value <<= 7;