commit 0c8f73ba8b83604463f26eca51f9c8278e791879
author Paul Bakker <p.j.bakker@polarssl.org> Thu Mar 22 14:08:57 2012 +0000
committer Paul Bakker <p.j.bakker@polarssl.org> Thu Mar 22 14:08:57 2012 +0000
tree 4e5de9a3a7b678ccca582742f37ba3b70b7d1d14
parent b78c74551f3c0cea35d17a870caf3d3dc65159df

 - Fixed a mistake in mpi_cmp_mpi() where longer B values are handled wrong

library/bignum.c

diff --git a/library/bignum.c b/library/bignum.c
index eccb9d3..b221312 100644
--- a/library/bignum.c
+++ b/library/bignum.c
@@ -687,7 +687,7 @@
         return( 0 );
 
     if( i > j ) return(  X->s );
-    if( j > i ) return( -X->s );
+    if( j > i ) return( -Y->s );
 
     if( X->s > 0 && Y->s < 0 ) return(  1 );
     if( Y->s > 0 && X->s < 0 ) return( -1 );

tests/suites/test_suite_mpi.data

diff --git a/tests/suites/test_suite_mpi.data b/tests/suites/test_suite_mpi.data
index 0a8c103..089c747 100644
--- a/tests/suites/test_suite_mpi.data
+++ b/tests/suites/test_suite_mpi.data
@@ -138,6 +138,15 @@
 Base test mpi_cmp_mpi (Negative values) #3
 mpi_cmp_mpi:10:"-2":10:"-1":-1
 
+Base test mpi_cmp_mpi (Mixed values) #4
+mpi_cmp_mpi:10:"-3":10:"2":-1
+
+Base test mpi_cmp_mpi (Mixed values) #5
+mpi_cmp_mpi:10:"2":10:"-3":1
+
+Base test mpi_cmp_mpi (Mixed values) #6
+mpi_cmp_mpi:10:"-2":10:"31231231289798":-1
+
 Base test mpi_cmp_abs #1
 mpi_cmp_abs:10:"693":10:"693":0