commit 0624e460fb8153d4c395ba559d55b7e12d1caade
author Andrzej Kurek <andrzej.kurek@arm.com> Tue May 23 10:57:14 2023 -0400
committer Andrzej Kurek <andrzej.kurek@arm.com> Wed Jun 07 08:54:35 2023 -0400
tree c0758951ac6090ecee91a9e54965b91b970fa3cc
parent 5d9aeba8996f70fbcd652f03b712e6ed2eb61a3b

Add a guard for IP parsing in cert_req app

Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>

programs/x509/cert_req.c

diff --git a/programs/x509/cert_req.c b/programs/x509/cert_req.c
index 531871b..23e816b 100644
--- a/programs/x509/cert_req.c
+++ b/programs/x509/cert_req.c
@@ -159,8 +159,9 @@
     mbedtls_ctr_drbg_context ctr_drbg;
     const char *pers = "csr example app";
     mbedtls_x509_san_list *cur, *prev;
+#if defined(MBEDTLS_X509_CRT_PARSE_C)
     uint8_t ip[4] = { 0 };
-
+#endif
     /*
      * Set to sane values
      */
@@ -241,20 +242,29 @@
                 } else if (strcmp(q, "DNS") == 0) {
                     cur->node.type = MBEDTLS_X509_SAN_DNS_NAME;
                 } else if (strcmp(q, "IP") == 0) {
+#if defined(MBEDTLS_X509_CRT_PARSE_C)
                     size_t ip_len = 0;
                     cur->node.type = MBEDTLS_X509_SAN_IP_ADDRESS;
                     ip_len = mbedtls_x509_crt_parse_cn_inet_pton(subtype_value, ip);
                     if (ip_len == 0) {
+                        mbedtls_printf("mbedtls_x509_crt_parse_cn_inet_pton failed to parse %s\n",
+                                       subtype_value);
                         goto exit;
                     }
+#else
+                    mbedtls_printf("IP SAN parsing requires MBEDTLS_X509_CRT_PARSE_C to be defined");
+                    goto exit;
+#endif
                 } else {
                     mbedtls_free(cur);
                     goto usage;
                 }
 
                 if (strcmp(q, "IP") == 0) {
+#if defined(MBEDTLS_X509_CRT_PARSE_C)
                     cur->node.san.unstructured_name.p = (unsigned char *) ip;
                     cur->node.san.unstructured_name.len = sizeof(ip);
+#endif
                 } else {
                     q = subtype_value;
                     cur->node.san.unstructured_name.p = (unsigned char *) q;