commit 02a999b91a02144ba34ca9352d297408d37c67e8
author Hanno Becker <hanno.becker@arm.com> Tue Jan 04 05:18:57 2022 +0000
committer Hanno Becker <hanno.becker@arm.com> Tue Jan 04 06:32:42 2022 +0000
tree 04b90590759c23c0a5689ffe65f860af23d32d31
parent 838b715fcc3de6fedc6fd6f501d911bfc9b1aa00

Remove local MPI from ecp_normalize_jac_many()

Signed-off-by: Hanno Becker <hanno.becker@arm.com>

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index 31f2e7f..c441e10 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -1279,7 +1279,7 @@
 #else
     int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
     size_t i;
-    mbedtls_mpi *c, u, Zi, ZZi;
+    mbedtls_mpi *c, u, Zi;
 
     if( ( c = mbedtls_calloc( T_size, sizeof( mbedtls_mpi ) ) ) == NULL )
         return( MBEDTLS_ERR_ECP_ALLOC_FAILED );
@@ -1287,7 +1287,7 @@
     for( i = 0; i < T_size; i++ )
         mbedtls_mpi_init( &c[i] );
 
-    mbedtls_mpi_init( &u ); mbedtls_mpi_init( &Zi ); mbedtls_mpi_init( &ZZi );
+    mbedtls_mpi_init( &u ); mbedtls_mpi_init( &Zi );
 
     /*
      * c[i] = Z_0 * ... * Z_i
@@ -1322,10 +1322,10 @@
         /*
          * proceed as in normalize()
          */
-        MPI_ECP_MUL( &ZZi,     &Zi,      &Zi  );
-        MPI_ECP_MUL( &T[i]->X, &T[i]->X, &ZZi );
-        MPI_ECP_MUL( &T[i]->Y, &T[i]->Y, &ZZi );
-        MPI_ECP_MUL( &T[i]->Y, &T[i]->Y, &Zi  );
+        MPI_ECP_MUL( &T[i]->Y, &T[i]->Y, &Zi );
+        MPI_ECP_MUL( &Zi,      &Zi,      &Zi );
+        MPI_ECP_MUL( &T[i]->X, &T[i]->X, &Zi );
+        MPI_ECP_MUL( &T[i]->Y, &T[i]->Y, &Zi );
 
         /*
          * Post-precessing: reclaim some memory by shrinking coordinates
@@ -1343,7 +1343,7 @@
 
 cleanup:
 
-    mbedtls_mpi_free( &u ); mbedtls_mpi_free( &Zi ); mbedtls_mpi_free( &ZZi );
+    mbedtls_mpi_free( &u ); mbedtls_mpi_free( &Zi );
     for( i = 0; i < T_size; i++ )
         mbedtls_mpi_free( &c[i] );
     mbedtls_free( c );