blob: 835bfa3bc88cfede416cd3db4438a9555991e615 [file] [log] [blame]
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01001/*
Manuel Pégourié-Gonnard32b04c12013-12-02 15:49:09 +01002 * Elliptic curves over GF(p): generic functions
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003 *
Bence Szépkúti1e148272020-08-07 13:07:28 +02004 * Copyright The Mbed TLS Contributors
Manuel Pégourié-Gonnard37ff1402015-09-04 14:21:07 +02005 * SPDX-License-Identifier: Apache-2.0
6 *
7 * Licensed under the Apache License, Version 2.0 (the "License"); you may
8 * not use this file except in compliance with the License.
9 * You may obtain a copy of the License at
10 *
11 * http://www.apache.org/licenses/LICENSE-2.0
12 *
13 * Unless required by applicable law or agreed to in writing, software
14 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
15 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16 * See the License for the specific language governing permissions and
17 * limitations under the License.
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010018 */
19
20/*
21 * References:
22 *
Manuel Pégourié-Gonnard883f3132012-11-02 09:40:25 +010023 * SEC1 http://www.secg.org/index.php?action=secg,docs_secg
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +010024 * GECC = Guide to Elliptic Curve Cryptography - Hankerson, Menezes, Vanstone
Manuel Pégourié-Gonnard62aad142012-11-10 00:27:12 +010025 * FIPS 186-3 http://csrc.nist.gov/publications/fips/fips186-3/fips_186-3.pdf
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +010026 * RFC 4492 for the related TLS structures and constants
Nicholas Wilson08f3ef12015-11-10 13:10:01 +000027 * RFC 7748 for the Curve448 and Curve25519 curve definitions
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020028 *
Manuel Pégourié-Gonnard07894332015-06-23 00:18:41 +020029 * [Curve25519] http://cr.yp.to/ecdh/curve25519-20060209.pdf
Manuel Pégourié-Gonnardfe0af402013-12-04 18:14:55 +010030 *
Manuel Pégourié-Gonnard998930a2015-04-03 13:48:06 +020031 * [2] CORON, Jean-S'ebastien. Resistance against differential power analysis
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020032 * for elliptic curve cryptosystems. In : Cryptographic Hardware and
33 * Embedded Systems. Springer Berlin Heidelberg, 1999. p. 292-302.
34 * <http://link.springer.com/chapter/10.1007/3-540-48059-5_25>
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +010035 *
Manuel Pégourié-Gonnard998930a2015-04-03 13:48:06 +020036 * [3] HEDABOU, Mustapha, PINEL, Pierre, et B'EN'ETEAU, Lucien. A comb method to
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +010037 * render ECC resistant against Side Channel Attacks. IACR Cryptology
38 * ePrint Archive, 2004, vol. 2004, p. 342.
39 * <http://eprint.iacr.org/2004/342.pdf>
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010040 */
41
Gilles Peskinedb09ef62020-06-03 01:43:33 +020042#include "common.h"
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010043
Andrzej Kurekc470b6b2019-01-31 08:20:20 -050044/**
45 * \brief Function level alternative implementation.
46 *
47 * The MBEDTLS_ECP_INTERNAL_ALT macro enables alternative implementations to
48 * replace certain functions in this module. The alternative implementations are
49 * typically hardware accelerators and need to activate the hardware before the
50 * computation starts and deactivate it after it finishes. The
51 * mbedtls_internal_ecp_init() and mbedtls_internal_ecp_free() functions serve
52 * this purpose.
53 *
54 * To preserve the correct functionality the following conditions must hold:
55 *
56 * - The alternative implementation must be activated by
57 * mbedtls_internal_ecp_init() before any of the replaceable functions is
58 * called.
59 * - mbedtls_internal_ecp_free() must \b only be called when the alternative
60 * implementation is activated.
61 * - mbedtls_internal_ecp_init() must \b not be called when the alternative
62 * implementation is activated.
63 * - Public functions must not return while the alternative implementation is
64 * activated.
65 * - Replaceable functions are guarded by \c MBEDTLS_ECP_XXX_ALT macros and
66 * before calling them an \code if( mbedtls_internal_ecp_grp_capable( grp ) )
67 * \endcode ensures that the alternative implementation supports the current
68 * group.
69 */
70#if defined(MBEDTLS_ECP_INTERNAL_ALT)
71#endif
72
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +020073#if defined(MBEDTLS_ECP_C)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +010074
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +000075#include "mbedtls/ecp.h"
Janos Follath430d3372016-11-03 14:25:37 +000076#include "mbedtls/threading.h"
Andres Amaya Garcia1f6301b2018-04-17 09:51:09 -050077#include "mbedtls/platform_util.h"
Janos Follath24eed8d2019-11-22 13:21:35 +000078#include "mbedtls/error.h"
Paul Bakker6e339b52013-07-03 13:37:05 +020079
Janos Follath8c70e812021-06-24 14:48:38 +010080#include "bn_mul.h"
Gilles Peskine80ba8502021-04-03 20:36:37 +020081#include "ecp_invasive.h"
Gabor Mezei9684d4d2023-01-16 16:50:11 +010082#include "ecp_internal.h"
83#include "bignum_core.h"
Gilles Peskine80ba8502021-04-03 20:36:37 +020084
Rich Evans00ab4702015-02-06 13:43:58 +000085#include <string.h>
86
Janos Follathb0697532016-08-18 12:38:46 +010087#if !defined(MBEDTLS_ECP_ALT)
88
Manuel Pégourié-Gonnard7f809972015-03-09 17:05:11 +000089#include "mbedtls/platform.h"
Paul Bakker6e339b52013-07-03 13:37:05 +020090
Gilles Peskine6a2fb612021-05-24 22:25:04 +020091#include "ecp_internal_alt.h"
Janos Follathb0697532016-08-18 12:38:46 +010092
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +020093#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +010094/*
Manuel Pégourié-Gonnard91814812013-11-21 20:23:55 +010095 * Counts of point addition and doubling, and field multiplications.
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +020096 * Used to test resistance of point multiplication to simple timing attacks.
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +010097 */
Manuel Pégourié-Gonnard43863ee2013-12-01 16:51:27 +010098static unsigned long add_count, dbl_count, mul_count;
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +010099#endif
100
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +0200101#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100102/*
103 * Maximum number of "basic operations" to be done in a row.
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +0200104 *
105 * Default value 0 means that ECC operations will not yield.
106 * Note that regardless of the value of ecp_max_ops, always at
107 * least one step is performed before yielding.
108 *
109 * Setting ecp_max_ops=1 can be suitable for testing purposes
110 * as it will interrupt computation at all possible points.
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100111 */
112static unsigned ecp_max_ops = 0;
113
114/*
115 * Set ecp_max_ops
116 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100117void mbedtls_ecp_set_max_ops(unsigned max_ops)
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100118{
119 ecp_max_ops = max_ops;
120}
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100121
122/*
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200123 * Check if restart is enabled
124 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100125int mbedtls_ecp_restart_is_enabled(void)
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200126{
Gilles Peskine449bd832023-01-11 14:50:10 +0100127 return ecp_max_ops != 0;
Manuel Pégourié-Gonnarda0c5bcc2017-04-21 11:33:57 +0200128}
129
130/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200131 * Restart sub-context for ecp_mul_comb()
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100132 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100133struct mbedtls_ecp_restart_mul {
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +0100134 mbedtls_ecp_point R; /* current intermediate result */
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +0100135 size_t i; /* current index in various loops, 0 outside */
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100136 mbedtls_ecp_point *T; /* table for precomputed points */
137 unsigned char T_size; /* number of points in table T */
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +0200138 enum { /* what were we doing last time we returned? */
139 ecp_rsm_init = 0, /* nothing so far, dummy initial state */
140 ecp_rsm_pre_dbl, /* precompute 2^n multiples */
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +0100141 ecp_rsm_pre_norm_dbl, /* normalize precomputed 2^n multiples */
142 ecp_rsm_pre_add, /* precompute remaining points by adding */
143 ecp_rsm_pre_norm_add, /* normalize all precomputed points */
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +0200144 ecp_rsm_comb_core, /* ecp_mul_comb_core() */
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +0100145 ecp_rsm_final_norm, /* do the final normalization */
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100146 } state;
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100147};
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100148
149/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200150 * Init restart_mul sub-context
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +0100151 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100152static void ecp_restart_rsm_init(mbedtls_ecp_restart_mul_ctx *ctx)
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100153{
Gilles Peskine449bd832023-01-11 14:50:10 +0100154 mbedtls_ecp_point_init(&ctx->R);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200155 ctx->i = 0;
156 ctx->T = NULL;
157 ctx->T_size = 0;
158 ctx->state = ecp_rsm_init;
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100159}
160
161/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200162 * Free the components of a restart_mul sub-context
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100163 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100164static void ecp_restart_rsm_free(mbedtls_ecp_restart_mul_ctx *ctx)
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100165{
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100166 unsigned char i;
167
Gilles Peskine449bd832023-01-11 14:50:10 +0100168 if (ctx == NULL) {
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100169 return;
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +0100170 }
171
Gilles Peskine449bd832023-01-11 14:50:10 +0100172 mbedtls_ecp_point_free(&ctx->R);
173
174 if (ctx->T != NULL) {
175 for (i = 0; i < ctx->T_size; i++) {
176 mbedtls_ecp_point_free(ctx->T + i);
177 }
178 mbedtls_free(ctx->T);
179 }
180
181 ecp_restart_rsm_init(ctx);
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +0100182}
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100183
184/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200185 * Restart context for ecp_muladd()
186 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100187struct mbedtls_ecp_restart_muladd {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200188 mbedtls_ecp_point mP; /* mP value */
189 mbedtls_ecp_point R; /* R intermediate result */
190 enum { /* what should we do next? */
191 ecp_rsma_mul1 = 0, /* first multiplication */
192 ecp_rsma_mul2, /* second multiplication */
193 ecp_rsma_add, /* addition */
194 ecp_rsma_norm, /* normalization */
195 } state;
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200196};
197
198/*
199 * Init restart_muladd sub-context
200 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100201static void ecp_restart_ma_init(mbedtls_ecp_restart_muladd_ctx *ctx)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200202{
Gilles Peskine449bd832023-01-11 14:50:10 +0100203 mbedtls_ecp_point_init(&ctx->mP);
204 mbedtls_ecp_point_init(&ctx->R);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200205 ctx->state = ecp_rsma_mul1;
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200206}
207
208/*
209 * Free the components of a restart_muladd sub-context
210 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100211static void ecp_restart_ma_free(mbedtls_ecp_restart_muladd_ctx *ctx)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200212{
Gilles Peskine449bd832023-01-11 14:50:10 +0100213 if (ctx == NULL) {
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200214 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100215 }
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200216
Gilles Peskine449bd832023-01-11 14:50:10 +0100217 mbedtls_ecp_point_free(&ctx->mP);
218 mbedtls_ecp_point_free(&ctx->R);
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200219
Gilles Peskine449bd832023-01-11 14:50:10 +0100220 ecp_restart_ma_init(ctx);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +0200221}
222
223/*
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200224 * Initialize a restart context
225 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100226void mbedtls_ecp_restart_init(mbedtls_ecp_restart_ctx *ctx)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200227{
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200228 ctx->ops_done = 0;
229 ctx->depth = 0;
230 ctx->rsm = NULL;
231 ctx->ma = NULL;
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200232}
233
234/*
235 * Free the components of a restart context
236 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100237void mbedtls_ecp_restart_free(mbedtls_ecp_restart_ctx *ctx)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200238{
Gilles Peskine449bd832023-01-11 14:50:10 +0100239 if (ctx == NULL) {
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200240 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100241 }
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200242
Gilles Peskine449bd832023-01-11 14:50:10 +0100243 ecp_restart_rsm_free(ctx->rsm);
244 mbedtls_free(ctx->rsm);
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +0200245
Gilles Peskine449bd832023-01-11 14:50:10 +0100246 ecp_restart_ma_free(ctx->ma);
247 mbedtls_free(ctx->ma);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200248
Gilles Peskine449bd832023-01-11 14:50:10 +0100249 mbedtls_ecp_restart_init(ctx);
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +0200250}
251
252/*
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100253 * Check if we can do the next step
254 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100255int mbedtls_ecp_check_budget(const mbedtls_ecp_group *grp,
256 mbedtls_ecp_restart_ctx *rs_ctx,
257 unsigned ops)
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100258{
Gilles Peskine449bd832023-01-11 14:50:10 +0100259 if (rs_ctx != NULL && ecp_max_ops != 0) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100260 /* scale depending on curve size: the chosen reference is 256-bit,
261 * and multiplication is quadratic. Round to the closest integer. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100262 if (grp->pbits >= 512) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100263 ops *= 4;
Gilles Peskine449bd832023-01-11 14:50:10 +0100264 } else if (grp->pbits >= 384) {
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100265 ops *= 2;
Gilles Peskine449bd832023-01-11 14:50:10 +0100266 }
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100267
Hanno Beckerb10c6602018-10-26 13:50:13 +0100268 /* Avoid infinite loops: always allow first step.
269 * Because of that, however, it's not generally true
270 * that ops_done <= ecp_max_ops, so the check
271 * ops_done > ecp_max_ops below is mandatory. */
Gilles Peskine449bd832023-01-11 14:50:10 +0100272 if ((rs_ctx->ops_done != 0) &&
273 (rs_ctx->ops_done > ecp_max_ops ||
274 ops > ecp_max_ops - rs_ctx->ops_done)) {
275 return MBEDTLS_ERR_ECP_IN_PROGRESS;
Hanno Beckerb10c6602018-10-26 13:50:13 +0100276 }
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100277
Manuel Pégourié-Gonnarde6854492017-03-20 14:35:19 +0100278 /* update running count */
Manuel Pégourié-Gonnard646393b2017-04-20 10:03:45 +0200279 rs_ctx->ops_done += ops;
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100280 }
281
Gilles Peskine449bd832023-01-11 14:50:10 +0100282 return 0;
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +0100283}
284
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200285/* Call this when entering a function that needs its own sub-context */
Gilles Peskine449bd832023-01-11 14:50:10 +0100286#define ECP_RS_ENTER(SUB) do { \
287 /* reset ops count for this call if top-level */ \
288 if (rs_ctx != NULL && rs_ctx->depth++ == 0) \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200289 rs_ctx->ops_done = 0; \
290 \
Gilles Peskine449bd832023-01-11 14:50:10 +0100291 /* set up our own sub-context if needed */ \
292 if (mbedtls_ecp_restart_is_enabled() && \
293 rs_ctx != NULL && rs_ctx->SUB == NULL) \
294 { \
295 rs_ctx->SUB = mbedtls_calloc(1, sizeof(*rs_ctx->SUB)); \
296 if (rs_ctx->SUB == NULL) \
297 return MBEDTLS_ERR_ECP_ALLOC_FAILED; \
298 \
299 ecp_restart_## SUB ##_init(rs_ctx->SUB); \
300 } \
301} while (0)
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200302
303/* Call this when leaving a function that needs its own sub-context */
Gilles Peskine449bd832023-01-11 14:50:10 +0100304#define ECP_RS_LEAVE(SUB) do { \
305 /* clear our sub-context when not in progress (done or error) */ \
306 if (rs_ctx != NULL && rs_ctx->SUB != NULL && \
307 ret != MBEDTLS_ERR_ECP_IN_PROGRESS) \
308 { \
309 ecp_restart_## SUB ##_free(rs_ctx->SUB); \
310 mbedtls_free(rs_ctx->SUB); \
311 rs_ctx->SUB = NULL; \
312 } \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200313 \
Gilles Peskine449bd832023-01-11 14:50:10 +0100314 if (rs_ctx != NULL) \
Manuel Pégourié-Gonnarda58e0112018-10-16 10:42:47 +0200315 rs_ctx->depth--; \
Gilles Peskine449bd832023-01-11 14:50:10 +0100316} while (0)
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200317
318#else /* MBEDTLS_ECP_RESTARTABLE */
319
Gilles Peskine449bd832023-01-11 14:50:10 +0100320#define ECP_RS_ENTER(sub) (void) rs_ctx;
321#define ECP_RS_LEAVE(sub) (void) rs_ctx;
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +0200322
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +0200323#endif /* MBEDTLS_ECP_RESTARTABLE */
Manuel Pégourié-Gonnard054433c2017-03-22 11:18:33 +0100324
Gilles Peskine449bd832023-01-11 14:50:10 +0100325static void mpi_init_many(mbedtls_mpi *arr, size_t size)
Hanno Becker466df6e2022-01-10 11:16:51 +0000326{
Gilles Peskine449bd832023-01-11 14:50:10 +0100327 while (size--) {
328 mbedtls_mpi_init(arr++);
329 }
Hanno Becker466df6e2022-01-10 11:16:51 +0000330}
331
Gilles Peskine449bd832023-01-11 14:50:10 +0100332static void mpi_free_many(mbedtls_mpi *arr, size_t size)
Hanno Becker466df6e2022-01-10 11:16:51 +0000333{
Gilles Peskine449bd832023-01-11 14:50:10 +0100334 while (size--) {
335 mbedtls_mpi_free(arr++);
336 }
Hanno Becker466df6e2022-01-10 11:16:51 +0000337}
338
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100339/*
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200340 * List of supported curves:
341 * - internal ID
Christoph M. Wintersteigercb310732019-02-15 15:50:38 +0000342 * - TLS NamedCurve ID (RFC 4492 sec. 5.1.1, RFC 7071 sec. 2, RFC 8446 sec. 4.2.7)
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200343 * - size in bits
Manuel Pégourié-Gonnard8195c1a2013-10-07 19:40:41 +0200344 * - readable name
Gergely Budaie40c4692014-01-22 11:22:20 +0100345 *
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100346 * Curves are listed in order: largest curves first, and for a given size,
Gilles Peskineae270bf2021-06-02 00:05:29 +0200347 * fastest curves first.
Manuel Pégourié-Gonnard88db5da2015-06-15 14:34:59 +0200348 *
Gilles Peskineae270bf2021-06-02 00:05:29 +0200349 * Reminder: update profiles in x509_crt.c and ssl_tls.c when adding a new curve!
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200350 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200351static const mbedtls_ecp_curve_info ecp_supported_curves[] =
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200352{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200353#if defined(MBEDTLS_ECP_DP_SECP521R1_ENABLED)
354 { MBEDTLS_ECP_DP_SECP521R1, 25, 521, "secp521r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200355#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200356#if defined(MBEDTLS_ECP_DP_BP512R1_ENABLED)
357 { MBEDTLS_ECP_DP_BP512R1, 28, 512, "brainpoolP512r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100358#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200359#if defined(MBEDTLS_ECP_DP_SECP384R1_ENABLED)
360 { MBEDTLS_ECP_DP_SECP384R1, 24, 384, "secp384r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200361#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200362#if defined(MBEDTLS_ECP_DP_BP384R1_ENABLED)
363 { MBEDTLS_ECP_DP_BP384R1, 27, 384, "brainpoolP384r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100364#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200365#if defined(MBEDTLS_ECP_DP_SECP256R1_ENABLED)
366 { MBEDTLS_ECP_DP_SECP256R1, 23, 256, "secp256r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200367#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200368#if defined(MBEDTLS_ECP_DP_SECP256K1_ENABLED)
369 { MBEDTLS_ECP_DP_SECP256K1, 22, 256, "secp256k1" },
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100370#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200371#if defined(MBEDTLS_ECP_DP_BP256R1_ENABLED)
372 { MBEDTLS_ECP_DP_BP256R1, 26, 256, "brainpoolP256r1" },
Gergely Budaie40c4692014-01-22 11:22:20 +0100373#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200374#if defined(MBEDTLS_ECP_DP_SECP224R1_ENABLED)
375 { MBEDTLS_ECP_DP_SECP224R1, 21, 224, "secp224r1" },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200376#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200377#if defined(MBEDTLS_ECP_DP_SECP224K1_ENABLED)
378 { MBEDTLS_ECP_DP_SECP224K1, 20, 224, "secp224k1" },
Manuel Pégourié-Gonnard9bcff392014-01-10 18:26:48 +0100379#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200380#if defined(MBEDTLS_ECP_DP_SECP192R1_ENABLED)
381 { MBEDTLS_ECP_DP_SECP192R1, 19, 192, "secp192r1" },
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100382#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200383#if defined(MBEDTLS_ECP_DP_SECP192K1_ENABLED)
384 { MBEDTLS_ECP_DP_SECP192K1, 18, 192, "secp192k1" },
Manuel Pégourié-Gonnard9bcff392014-01-10 18:26:48 +0100385#endif
Gilles Peskine360e2c42020-07-24 02:03:20 +0200386#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Christoph M. Wintersteiger86e36c42018-12-06 17:27:31 +0000387 { MBEDTLS_ECP_DP_CURVE25519, 29, 256, "x25519" },
Christoph M. Wintersteigerc9f737b2018-10-25 13:03:05 +0100388#endif
Gilles Peskine360e2c42020-07-24 02:03:20 +0200389#if defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
390 { MBEDTLS_ECP_DP_CURVE448, 30, 448, "x448" },
391#endif
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200392 { MBEDTLS_ECP_DP_NONE, 0, 0, NULL },
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200393};
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100394
Gilles Peskine449bd832023-01-11 14:50:10 +0100395#define ECP_NB_CURVES sizeof(ecp_supported_curves) / \
396 sizeof(ecp_supported_curves[0])
Manuel Pégourié-Gonnardba782bb2014-07-08 13:31:34 +0200397
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200398static mbedtls_ecp_group_id ecp_supported_grp_id[ECP_NB_CURVES];
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200399
400/*
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200401 * List of supported curves and associated info
402 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100403const mbedtls_ecp_curve_info *mbedtls_ecp_curve_list(void)
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200404{
Gilles Peskine449bd832023-01-11 14:50:10 +0100405 return ecp_supported_curves;
Manuel Pégourié-Gonnardda179e42013-09-18 15:31:24 +0200406}
407
408/*
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100409 * List of supported curves, group ID only
410 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100411const mbedtls_ecp_group_id *mbedtls_ecp_grp_id_list(void)
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100412{
413 static int init_done = 0;
414
Gilles Peskine449bd832023-01-11 14:50:10 +0100415 if (!init_done) {
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100416 size_t i = 0;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200417 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100418
Gilles Peskine449bd832023-01-11 14:50:10 +0100419 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200420 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100421 curve_info++) {
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100422 ecp_supported_grp_id[i++] = curve_info->grp_id;
423 }
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200424 ecp_supported_grp_id[i] = MBEDTLS_ECP_DP_NONE;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100425
426 init_done = 1;
427 }
428
Gilles Peskine449bd832023-01-11 14:50:10 +0100429 return ecp_supported_grp_id;
Manuel Pégourié-Gonnardac719412014-02-04 14:48:50 +0100430}
431
432/*
433 * Get the curve info for the internal identifier
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200434 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100435const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_grp_id(mbedtls_ecp_group_id grp_id)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200436{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200437 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200438
Gilles Peskine449bd832023-01-11 14:50:10 +0100439 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200440 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100441 curve_info++) {
442 if (curve_info->grp_id == grp_id) {
443 return curve_info;
444 }
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200445 }
446
Gilles Peskine449bd832023-01-11 14:50:10 +0100447 return NULL;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200448}
449
450/*
451 * Get the curve info from the TLS identifier
452 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100453const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_tls_id(uint16_t tls_id)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200454{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200455 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200456
Gilles Peskine449bd832023-01-11 14:50:10 +0100457 for (curve_info = mbedtls_ecp_curve_list();
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200458 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100459 curve_info++) {
460 if (curve_info->tls_id == tls_id) {
461 return curve_info;
462 }
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200463 }
464
Gilles Peskine449bd832023-01-11 14:50:10 +0100465 return NULL;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200466}
467
468/*
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100469 * Get the curve info from the name
470 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100471const mbedtls_ecp_curve_info *mbedtls_ecp_curve_info_from_name(const char *name)
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100472{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200473 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100474
Gilles Peskine449bd832023-01-11 14:50:10 +0100475 if (name == NULL) {
476 return NULL;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100477 }
478
Gilles Peskine449bd832023-01-11 14:50:10 +0100479 for (curve_info = mbedtls_ecp_curve_list();
480 curve_info->grp_id != MBEDTLS_ECP_DP_NONE;
481 curve_info++) {
482 if (strcmp(curve_info->name, name) == 0) {
483 return curve_info;
484 }
485 }
486
487 return NULL;
Manuel Pégourié-Gonnard0267e3d2013-11-30 15:10:14 +0100488}
489
490/*
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100491 * Get the type of a curve
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100492 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100493mbedtls_ecp_curve_type mbedtls_ecp_get_type(const mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100494{
Gilles Peskine449bd832023-01-11 14:50:10 +0100495 if (grp->G.X.p == NULL) {
496 return MBEDTLS_ECP_TYPE_NONE;
497 }
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +0100498
Gilles Peskine449bd832023-01-11 14:50:10 +0100499 if (grp->G.Y.p == NULL) {
500 return MBEDTLS_ECP_TYPE_MONTGOMERY;
501 } else {
502 return MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS;
503 }
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +0100504}
505
506/*
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100507 * Initialize (the components of) a point
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100508 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100509void mbedtls_ecp_point_init(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100510{
Gilles Peskine449bd832023-01-11 14:50:10 +0100511 mbedtls_mpi_init(&pt->X);
512 mbedtls_mpi_init(&pt->Y);
513 mbedtls_mpi_init(&pt->Z);
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100514}
515
516/*
517 * Initialize (the components of) a group
518 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100519void mbedtls_ecp_group_init(mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +0100520{
Manuel Pégourié-Gonnard95e2eca2018-06-20 10:29:47 +0200521 grp->id = MBEDTLS_ECP_DP_NONE;
Gilles Peskine449bd832023-01-11 14:50:10 +0100522 mbedtls_mpi_init(&grp->P);
523 mbedtls_mpi_init(&grp->A);
524 mbedtls_mpi_init(&grp->B);
525 mbedtls_ecp_point_init(&grp->G);
526 mbedtls_mpi_init(&grp->N);
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +0200527 grp->pbits = 0;
528 grp->nbits = 0;
529 grp->h = 0;
530 grp->modp = NULL;
531 grp->t_pre = NULL;
532 grp->t_post = NULL;
533 grp->t_data = NULL;
534 grp->T = NULL;
535 grp->T_size = 0;
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100536}
537
538/*
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200539 * Initialize (the components of) a key pair
540 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100541void mbedtls_ecp_keypair_init(mbedtls_ecp_keypair *key)
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200542{
Gilles Peskine449bd832023-01-11 14:50:10 +0100543 mbedtls_ecp_group_init(&key->grp);
544 mbedtls_mpi_init(&key->d);
545 mbedtls_ecp_point_init(&key->Q);
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200546}
547
548/*
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100549 * Unallocate (the components of) a point
550 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100551void mbedtls_ecp_point_free(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100552{
Gilles Peskine449bd832023-01-11 14:50:10 +0100553 if (pt == NULL) {
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100554 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100555 }
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100556
Gilles Peskine449bd832023-01-11 14:50:10 +0100557 mbedtls_mpi_free(&(pt->X));
558 mbedtls_mpi_free(&(pt->Y));
559 mbedtls_mpi_free(&(pt->Z));
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100560}
561
562/*
kXuanba9cb762021-04-08 14:32:06 +0800563 * Check that the comb table (grp->T) is static initialized.
564 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100565static int ecp_group_is_static_comb_table(const mbedtls_ecp_group *grp)
566{
kXuanba9cb762021-04-08 14:32:06 +0800567#if MBEDTLS_ECP_FIXED_POINT_OPTIM == 1
568 return grp->T != NULL && grp->T_size == 0;
569#else
570 (void) grp;
571 return 0;
572#endif
573}
574
575/*
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100576 * Unallocate (the components of) a group
577 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100578void mbedtls_ecp_group_free(mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100579{
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +0200580 size_t i;
581
Gilles Peskine449bd832023-01-11 14:50:10 +0100582 if (grp == NULL) {
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100583 return;
Manuel Pégourié-Gonnard1f82b042013-12-06 12:51:50 +0100584 }
Manuel Pégourié-Gonnardc9727702013-09-16 18:56:28 +0200585
Gilles Peskine449bd832023-01-11 14:50:10 +0100586 if (grp->h != 1) {
587 mbedtls_mpi_free(&grp->P);
588 mbedtls_mpi_free(&grp->A);
589 mbedtls_mpi_free(&grp->B);
590 mbedtls_ecp_point_free(&grp->G);
591 mbedtls_mpi_free(&grp->N);
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +0200592 }
593
Gilles Peskine449bd832023-01-11 14:50:10 +0100594 if (!ecp_group_is_static_comb_table(grp) && grp->T != NULL) {
595 for (i = 0; i < grp->T_size; i++) {
596 mbedtls_ecp_point_free(&grp->T[i]);
597 }
598 mbedtls_free(grp->T);
599 }
600
601 mbedtls_platform_zeroize(grp, sizeof(mbedtls_ecp_group));
Manuel Pégourié-Gonnard1e8c8ec2012-10-31 19:24:21 +0100602}
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +0100603
Manuel Pégourié-Gonnard883f3132012-11-02 09:40:25 +0100604/*
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200605 * Unallocate (the components of) a key pair
606 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100607void mbedtls_ecp_keypair_free(mbedtls_ecp_keypair *key)
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200608{
Gilles Peskine449bd832023-01-11 14:50:10 +0100609 if (key == NULL) {
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200610 return;
Gilles Peskine449bd832023-01-11 14:50:10 +0100611 }
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200612
Gilles Peskine449bd832023-01-11 14:50:10 +0100613 mbedtls_ecp_group_free(&key->grp);
614 mbedtls_mpi_free(&key->d);
615 mbedtls_ecp_point_free(&key->Q);
Manuel Pégourié-Gonnardb8c6e0e2013-07-01 13:40:52 +0200616}
617
618/*
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200619 * Copy the contents of a point
620 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100621int mbedtls_ecp_copy(mbedtls_ecp_point *P, const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200622{
Janos Follath24eed8d2019-11-22 13:21:35 +0000623 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100624 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->X, &Q->X));
625 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->Y, &Q->Y));
626 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&P->Z, &Q->Z));
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200627
628cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100629 return ret;
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200630}
631
632/*
633 * Copy the contents of a group object
634 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100635int mbedtls_ecp_group_copy(mbedtls_ecp_group *dst, const mbedtls_ecp_group *src)
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200636{
Gilles Peskine449bd832023-01-11 14:50:10 +0100637 return mbedtls_ecp_group_load(dst, src->id);
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +0200638}
639
640/*
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100641 * Set point to zero
642 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100643int mbedtls_ecp_set_zero(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100644{
Janos Follath24eed8d2019-11-22 13:21:35 +0000645 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100646 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->X, 1));
647 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Y, 1));
648 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 0));
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +0100649
650cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100651 return ret;
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +0100652}
653
654/*
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100655 * Tell if a point is zero
656 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100657int mbedtls_ecp_is_zero(mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100658{
Gilles Peskine449bd832023-01-11 14:50:10 +0100659 return mbedtls_mpi_cmp_int(&pt->Z, 0) == 0;
Manuel Pégourié-Gonnard6545ca72013-01-26 16:05:22 +0100660}
661
662/*
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500663 * Compare two points lazily
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200664 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100665int mbedtls_ecp_point_cmp(const mbedtls_ecp_point *P,
666 const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200667{
Gilles Peskine449bd832023-01-11 14:50:10 +0100668 if (mbedtls_mpi_cmp_mpi(&P->X, &Q->X) == 0 &&
669 mbedtls_mpi_cmp_mpi(&P->Y, &Q->Y) == 0 &&
670 mbedtls_mpi_cmp_mpi(&P->Z, &Q->Z) == 0) {
671 return 0;
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200672 }
673
Gilles Peskine449bd832023-01-11 14:50:10 +0100674 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard6029a852015-08-11 15:44:41 +0200675}
676
677/*
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100678 * Import a non-zero point from ASCII strings
679 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100680int mbedtls_ecp_point_read_string(mbedtls_ecp_point *P, int radix,
681 const char *x, const char *y)
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100682{
Janos Follath24eed8d2019-11-22 13:21:35 +0000683 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100684 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(&P->X, radix, x));
685 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(&P->Y, radix, y));
686 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&P->Z, 1));
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100687
688cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100689 return ret;
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +0100690}
691
692/*
Janos Follath7caf8e42019-02-20 12:00:22 +0000693 * Export a point into unsigned binary data (SEC1 2.3.3 and RFC7748)
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100694 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100695int mbedtls_ecp_point_write_binary(const mbedtls_ecp_group *grp,
696 const mbedtls_ecp_point *P,
697 int format, size_t *olen,
698 unsigned char *buf, size_t buflen)
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100699{
Janos Follath28eb06d2019-02-26 10:53:34 +0000700 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100701 size_t plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100702 if (format != MBEDTLS_ECP_PF_UNCOMPRESSED &&
703 format != MBEDTLS_ECP_PF_COMPRESSED) {
704 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
705 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100706
Gilles Peskine449bd832023-01-11 14:50:10 +0100707 plen = mbedtls_mpi_size(&grp->P);
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100708
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200709#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine59970052019-02-28 13:12:06 +0100710 (void) format; /* Montgomery curves always use the same point format */
Gilles Peskine449bd832023-01-11 14:50:10 +0100711 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000712 *olen = plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100713 if (buflen < *olen) {
714 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
715 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100716
Gilles Peskine449bd832023-01-11 14:50:10 +0100717 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary_le(&P->X, buf, plen));
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100718 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000719#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200720#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100721 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000722 /*
723 * Common case: P == 0
724 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100725 if (mbedtls_mpi_cmp_int(&P->Z, 0) == 0) {
726 if (buflen < 1) {
727 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
728 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100729
Janos Follath7caf8e42019-02-20 12:00:22 +0000730 buf[0] = 0x00;
731 *olen = 1;
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100732
Gilles Peskine449bd832023-01-11 14:50:10 +0100733 return 0;
Janos Follath7caf8e42019-02-20 12:00:22 +0000734 }
735
Gilles Peskine449bd832023-01-11 14:50:10 +0100736 if (format == MBEDTLS_ECP_PF_UNCOMPRESSED) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000737 *olen = 2 * plen + 1;
738
Gilles Peskine449bd832023-01-11 14:50:10 +0100739 if (buflen < *olen) {
740 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
741 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000742
743 buf[0] = 0x04;
Gilles Peskine449bd832023-01-11 14:50:10 +0100744 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->X, buf + 1, plen));
745 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->Y, buf + 1 + plen, plen));
746 } else if (format == MBEDTLS_ECP_PF_COMPRESSED) {
Janos Follath7caf8e42019-02-20 12:00:22 +0000747 *olen = plen + 1;
748
Gilles Peskine449bd832023-01-11 14:50:10 +0100749 if (buflen < *olen) {
750 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
751 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000752
Gilles Peskine449bd832023-01-11 14:50:10 +0100753 buf[0] = 0x02 + mbedtls_mpi_get_bit(&P->Y, 0);
754 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&P->X, buf + 1, plen));
Janos Follath7caf8e42019-02-20 12:00:22 +0000755 }
Manuel Pégourié-Gonnard37d218a2012-11-24 15:19:55 +0100756 }
Janos Follath7caf8e42019-02-20 12:00:22 +0000757#endif
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100758
759cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100760 return ret;
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100761}
762
Glenn Strauss2ff77112022-09-14 23:27:50 -0400763#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100764static int mbedtls_ecp_sw_derive_y(const mbedtls_ecp_group *grp,
765 const mbedtls_mpi *X,
766 mbedtls_mpi *Y,
767 int parity_bit);
Glenn Strauss2ff77112022-09-14 23:27:50 -0400768#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
769
Manuel Pégourié-Gonnarde19feb52012-11-24 14:10:14 +0100770/*
Janos Follath59b813c2019-02-13 10:44:06 +0000771 * Import a point from unsigned binary data (SEC1 2.3.4 and RFC7748)
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100772 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100773int mbedtls_ecp_point_read_binary(const mbedtls_ecp_group *grp,
774 mbedtls_ecp_point *pt,
775 const unsigned char *buf, size_t ilen)
Manuel Pégourié-Gonnard5246ee52014-03-19 16:18:38 +0100776{
Janos Follath28eb06d2019-02-26 10:53:34 +0000777 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100778 size_t plen;
Gilles Peskine449bd832023-01-11 14:50:10 +0100779 if (ilen < 1) {
780 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
781 }
Manuel Pégourié-Gonnard67dbe1e2014-07-08 13:09:24 +0200782
Gilles Peskine449bd832023-01-11 14:50:10 +0100783 plen = mbedtls_mpi_size(&grp->P);
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100784
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200785#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100786 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
787 if (plen != ilen) {
788 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
789 }
Manuel Pégourié-Gonnard5246ee52014-03-19 16:18:38 +0100790
Gilles Peskine449bd832023-01-11 14:50:10 +0100791 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&pt->X, buf, plen));
792 mbedtls_mpi_free(&pt->Y);
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100793
Gilles Peskine449bd832023-01-11 14:50:10 +0100794 if (grp->id == MBEDTLS_ECP_DP_CURVE25519) {
Janos Follathffbd7e82019-02-25 11:35:20 +0000795 /* Set most significant bit to 0 as prescribed in RFC7748 §5 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100796 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&pt->X, plen * 8 - 1, 0));
797 }
Janos Follath28eb06d2019-02-26 10:53:34 +0000798
Gilles Peskine449bd832023-01-11 14:50:10 +0100799 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 1));
Janos Follath59b813c2019-02-13 10:44:06 +0000800 }
801#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +0200802#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +0100803 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
804 if (buf[0] == 0x00) {
805 if (ilen == 1) {
806 return mbedtls_ecp_set_zero(pt);
807 } else {
808 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
809 }
Janos Follath59b813c2019-02-13 10:44:06 +0000810 }
811
Gilles Peskine449bd832023-01-11 14:50:10 +0100812 if (ilen < 1 + plen) {
813 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
814 }
Janos Follath59b813c2019-02-13 10:44:06 +0000815
Gilles Peskine449bd832023-01-11 14:50:10 +0100816 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary(&pt->X, buf + 1, plen));
817 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&pt->Z, 1));
Glenn Strauss2ff77112022-09-14 23:27:50 -0400818
Gilles Peskine449bd832023-01-11 14:50:10 +0100819 if (buf[0] == 0x04) {
Glenn Strauss2ff77112022-09-14 23:27:50 -0400820 /* format == MBEDTLS_ECP_PF_UNCOMPRESSED */
Gilles Peskine449bd832023-01-11 14:50:10 +0100821 if (ilen != 1 + plen * 2) {
822 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
823 }
824 return mbedtls_mpi_read_binary(&pt->Y, buf + 1 + plen, plen);
825 } else if (buf[0] == 0x02 || buf[0] == 0x03) {
Glenn Strauss2ff77112022-09-14 23:27:50 -0400826 /* format == MBEDTLS_ECP_PF_COMPRESSED */
Gilles Peskine449bd832023-01-11 14:50:10 +0100827 if (ilen != 1 + plen) {
828 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
829 }
830 return mbedtls_ecp_sw_derive_y(grp, &pt->X, &pt->Y,
831 (buf[0] & 1));
832 } else {
833 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Glenn Strauss2ff77112022-09-14 23:27:50 -0400834 }
Janos Follath59b813c2019-02-13 10:44:06 +0000835 }
836#endif
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100837
838cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +0100839 return ret;
Manuel Pégourié-Gonnard5e402d82012-11-24 16:19:42 +0100840}
841
842/*
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100843 * Import a point from a TLS ECPoint record (RFC 4492)
844 * struct {
845 * opaque point <1..2^8-1>;
846 * } ECPoint;
847 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100848int mbedtls_ecp_tls_read_point(const mbedtls_ecp_group *grp,
849 mbedtls_ecp_point *pt,
850 const unsigned char **buf, size_t buf_len)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100851{
852 unsigned char data_len;
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100853 const unsigned char *buf_start;
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100854 /*
Manuel Pégourié-Gonnard67dbe1e2014-07-08 13:09:24 +0200855 * We must have at least two bytes (1 for length, at least one for data)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100856 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100857 if (buf_len < 2) {
858 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
859 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100860
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100861 data_len = *(*buf)++;
Gilles Peskine449bd832023-01-11 14:50:10 +0100862 if (data_len < 1 || data_len > buf_len - 1) {
863 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
864 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100865
Manuel Pégourié-Gonnard98f51812013-02-10 13:38:29 +0100866 /*
867 * Save buffer start for read_binary and update buf
868 */
869 buf_start = *buf;
870 *buf += data_len;
871
Gilles Peskine449bd832023-01-11 14:50:10 +0100872 return mbedtls_ecp_point_read_binary(grp, pt, buf_start, data_len);
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100873}
874
875/*
876 * Export a point as a TLS ECPoint record (RFC 4492)
877 * struct {
878 * opaque point <1..2^8-1>;
879 * } ECPoint;
880 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100881int mbedtls_ecp_tls_write_point(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt,
882 int format, size_t *olen,
883 unsigned char *buf, size_t blen)
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100884{
Janos Follath24eed8d2019-11-22 13:21:35 +0000885 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +0100886 if (format != MBEDTLS_ECP_PF_UNCOMPRESSED &&
887 format != MBEDTLS_ECP_PF_COMPRESSED) {
888 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
889 }
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100890
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100891 /*
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100892 * buffer length must be at least one, for our length byte
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100893 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100894 if (blen < 1) {
895 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
896 }
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100897
Gilles Peskine449bd832023-01-11 14:50:10 +0100898 if ((ret = mbedtls_ecp_point_write_binary(grp, pt, format,
899 olen, buf + 1, blen - 1)) != 0) {
900 return ret;
901 }
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100902
903 /*
904 * write length to the first byte and update total length
905 */
Paul Bakkerb9cfaa02013-10-11 18:58:55 +0200906 buf[0] = (unsigned char) *olen;
Manuel Pégourié-Gonnard420f1eb2013-02-10 12:22:46 +0100907 ++*olen;
908
Gilles Peskine449bd832023-01-11 14:50:10 +0100909 return 0;
Manuel Pégourié-Gonnard00794052013-02-09 19:00:07 +0100910}
911
912/*
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100913 * Set a group from an ECParameters record (RFC 4492)
914 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100915int mbedtls_ecp_tls_read_group(mbedtls_ecp_group *grp,
916 const unsigned char **buf, size_t len)
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500917{
Janos Follath24eed8d2019-11-22 13:21:35 +0000918 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500919 mbedtls_ecp_group_id grp_id;
Gilles Peskine449bd832023-01-11 14:50:10 +0100920 if ((ret = mbedtls_ecp_tls_read_group_id(&grp_id, buf, len)) != 0) {
921 return ret;
922 }
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500923
Gilles Peskine449bd832023-01-11 14:50:10 +0100924 return mbedtls_ecp_group_load(grp, grp_id);
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500925}
926
927/*
928 * Read a group id from an ECParameters record (RFC 4492) and convert it to
929 * mbedtls_ecp_group_id.
930 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100931int mbedtls_ecp_tls_read_group_id(mbedtls_ecp_group_id *grp,
932 const unsigned char **buf, size_t len)
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100933{
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200934 uint16_t tls_id;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200935 const mbedtls_ecp_curve_info *curve_info;
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100936 /*
937 * We expect at least three bytes (see below)
938 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100939 if (len < 3) {
940 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
941 }
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100942
943 /*
944 * First byte is curve_type; only named_curve is handled
945 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100946 if (*(*buf)++ != MBEDTLS_ECP_TLS_NAMED_CURVE) {
947 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
948 }
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100949
950 /*
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100951 * Next two bytes are the namedcurve value
Manuel Pégourié-Gonnard1a967282013-02-09 17:03:58 +0100952 */
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200953 tls_id = *(*buf)++;
954 tls_id <<= 8;
955 tls_id |= *(*buf)++;
956
Gilles Peskine449bd832023-01-11 14:50:10 +0100957 if ((curve_info = mbedtls_ecp_curve_info_from_tls_id(tls_id)) == NULL) {
958 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
959 }
Manuel Pégourié-Gonnardf24b4a72013-09-23 18:14:50 +0200960
Andrzej Kurekc470b6b2019-01-31 08:20:20 -0500961 *grp = curve_info->grp_id;
962
Gilles Peskine449bd832023-01-11 14:50:10 +0100963 return 0;
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100964}
965
966/*
967 * Write the ECParameters record corresponding to a group (RFC 4492)
968 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100969int mbedtls_ecp_tls_write_group(const mbedtls_ecp_group *grp, size_t *olen,
970 unsigned char *buf, size_t blen)
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100971{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200972 const mbedtls_ecp_curve_info *curve_info;
Gilles Peskine449bd832023-01-11 14:50:10 +0100973 if ((curve_info = mbedtls_ecp_curve_info_from_grp_id(grp->id)) == NULL) {
974 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
975 }
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +0200976
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100977 /*
978 * We are going to write 3 bytes (see below)
979 */
980 *olen = 3;
Gilles Peskine449bd832023-01-11 14:50:10 +0100981 if (blen < *olen) {
982 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
983 }
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100984
985 /*
986 * First byte is curve_type, always named_curve
987 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200988 *buf++ = MBEDTLS_ECP_TLS_NAMED_CURVE;
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100989
990 /*
991 * Next two bytes are the namedcurve value
992 */
Gilles Peskine449bd832023-01-11 14:50:10 +0100993 MBEDTLS_PUT_UINT16_BE(curve_info->tls_id, buf, 0);
Manuel Pégourié-Gonnardb3258872013-02-10 12:06:19 +0100994
Gilles Peskine449bd832023-01-11 14:50:10 +0100995 return 0;
Manuel Pégourié-Gonnarda5402fe2012-11-07 20:24:05 +0100996}
Manuel Pégourié-Gonnardab38b702012-11-05 17:34:55 +0100997
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +0200998/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +0200999 * Wrapper around fast quasi-modp functions, with fall-back to mbedtls_mpi_mod_mpi.
1000 * See the documentation of struct mbedtls_ecp_group.
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001001 *
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001002 * This function is in the critial loop for mbedtls_ecp_mul, so pay attention to perf.
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001003 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001004static int ecp_modp(mbedtls_mpi *N, const mbedtls_ecp_group *grp)
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001005{
Janos Follath24eed8d2019-11-22 13:21:35 +00001006 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001007
Gilles Peskine449bd832023-01-11 14:50:10 +01001008 if (grp->modp == NULL) {
1009 return mbedtls_mpi_mod_mpi(N, N, &grp->P);
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001010 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001011
Gilles Peskine449bd832023-01-11 14:50:10 +01001012 /* N->s < 0 is a much faster test, which fails only if N is 0 */
1013 if ((N->s < 0 && mbedtls_mpi_cmp_int(N, 0) != 0) ||
1014 mbedtls_mpi_bitlen(N) > 2 * grp->pbits) {
1015 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1016 }
1017
1018 MBEDTLS_MPI_CHK(grp->modp(N));
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001019
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001020 /* N->s < 0 is a much faster test, which fails only if N is 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001021 while (N->s < 0 && mbedtls_mpi_cmp_int(N, 0) != 0) {
1022 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi(N, N, &grp->P));
1023 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001024
Gilles Peskine449bd832023-01-11 14:50:10 +01001025 while (mbedtls_mpi_cmp_mpi(N, &grp->P) >= 0) {
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001026 /* we known P, N and the result are positive */
Gilles Peskine449bd832023-01-11 14:50:10 +01001027 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_abs(N, N, &grp->P));
1028 }
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001029
Manuel Pégourié-Gonnardcae6f3e2013-10-23 20:19:57 +02001030cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001031 return ret;
Manuel Pégourié-Gonnard70380392013-09-16 16:19:53 +02001032}
Manuel Pégourié-Gonnard568c9cf2013-09-16 17:30:04 +02001033
Gabor Mezei9684d4d2023-01-16 16:50:11 +01001034int mbedtls_ecp_quasi_reduction(mbedtls_mpi_uint *X,
1035 const mbedtls_mpi_mod_modulus *N)
1036{
1037 if (N->limbs == 0) {
1038 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1039 }
1040
1041 mbedtls_mpi_uint c = mbedtls_mpi_core_sub(X, X, N->p, N->limbs);
1042
1043 (void) mbedtls_mpi_core_add_if(X, N->p, N->limbs, (unsigned) c);
1044
1045 return 0;
1046}
1047
Manuel Pégourié-Gonnard847395a2012-11-05 13:13:44 +01001048/*
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001049 * Fast mod-p functions expect their argument to be in the 0..p^2 range.
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001050 *
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001051 * In order to guarantee that, we need to ensure that operands of
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001052 * mbedtls_mpi_mul_mpi are in the 0..p range. So, after each operation we will
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001053 * bring the result back to this range.
1054 *
Manuel Pégourié-Gonnard47123252012-11-10 14:44:24 +01001055 * The following macros are shortcuts for doing that.
Manuel Pégourié-Gonnarddada4da2012-11-10 14:23:17 +01001056 */
1057
1058/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001059 * Reduce a mbedtls_mpi mod p in-place, general case, to use after mbedtls_mpi_mul_mpi
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001060 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001061#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard91814812013-11-21 20:23:55 +01001062#define INC_MUL_COUNT mul_count++;
1063#else
1064#define INC_MUL_COUNT
1065#endif
1066
Gilles Peskine449bd832023-01-11 14:50:10 +01001067#define MOD_MUL(N) \
Hanno Becker1eeca412018-10-15 12:01:35 +01001068 do \
1069 { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001070 MBEDTLS_MPI_CHK(ecp_modp(&(N), grp)); \
Hanno Becker1eeca412018-10-15 12:01:35 +01001071 INC_MUL_COUNT \
Gilles Peskine449bd832023-01-11 14:50:10 +01001072 } while (0)
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001073
Gilles Peskine449bd832023-01-11 14:50:10 +01001074static inline int mbedtls_mpi_mul_mod(const mbedtls_ecp_group *grp,
1075 mbedtls_mpi *X,
1076 const mbedtls_mpi *A,
1077 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001078{
Janos Follath24eed8d2019-11-22 13:21:35 +00001079 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001080 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mpi(X, A, B));
1081 MOD_MUL(*X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001082cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001083 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001084}
1085
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001086/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001087 * Reduce a mbedtls_mpi mod p in-place, to use after mbedtls_mpi_sub_mpi
Manuel Pégourié-Gonnardc9e387c2013-10-17 17:15:35 +02001088 * N->s < 0 is a very fast test, which fails only if N is 0
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001089 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001090#define MOD_SUB(N) \
Hanno Beckerce29ae82022-01-04 04:55:11 +00001091 do { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001092 while ((N)->s < 0 && mbedtls_mpi_cmp_int((N), 0) != 0) \
1093 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi((N), (N), &grp->P)); \
1094 } while (0)
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001095
Gilles Peskine449bd832023-01-11 14:50:10 +01001096#if (defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED) && \
1097 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1098 defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) && \
1099 defined(MBEDTLS_ECP_ADD_MIXED_ALT))) || \
1100 (defined(MBEDTLS_ECP_MONTGOMERY_ENABLED) && \
1101 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1102 defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)))
1103static inline int mbedtls_mpi_sub_mod(const mbedtls_ecp_group *grp,
1104 mbedtls_mpi *X,
1105 const mbedtls_mpi *A,
1106 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001107{
Janos Follath24eed8d2019-11-22 13:21:35 +00001108 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001109 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(X, A, B));
1110 MOD_SUB(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001111cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001112 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001113}
Steven Cooremane5388962021-03-01 14:04:53 +01001114#endif /* All functions referencing mbedtls_mpi_sub_mod() are alt-implemented without fallback */
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001115
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001116/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001117 * Reduce a mbedtls_mpi mod p in-place, to use after mbedtls_mpi_add_mpi and mbedtls_mpi_mul_int.
Manuel Pégourié-Gonnardc9e387c2013-10-17 17:15:35 +02001118 * We known P, N and the result are positive, so sub_abs is correct, and
1119 * a bit faster.
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001120 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001121#define MOD_ADD(N) \
1122 while (mbedtls_mpi_cmp_mpi((N), &grp->P) >= 0) \
1123 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_abs((N), (N), &grp->P))
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001124
Gilles Peskine449bd832023-01-11 14:50:10 +01001125static inline int mbedtls_mpi_add_mod(const mbedtls_ecp_group *grp,
1126 mbedtls_mpi *X,
1127 const mbedtls_mpi *A,
1128 const mbedtls_mpi *B)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001129{
Janos Follath24eed8d2019-11-22 13:21:35 +00001130 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001131 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mpi(X, A, B));
1132 MOD_ADD(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001133cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001134 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001135}
1136
Gilles Peskine449bd832023-01-11 14:50:10 +01001137static inline int mbedtls_mpi_mul_int_mod(const mbedtls_ecp_group *grp,
1138 mbedtls_mpi *X,
1139 const mbedtls_mpi *A,
1140 mbedtls_mpi_uint c)
Hanno Becker02b35bd2022-01-01 06:54:25 +00001141{
1142 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1143
Gilles Peskine449bd832023-01-11 14:50:10 +01001144 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_int(X, A, c));
1145 MOD_ADD(X);
Hanno Becker02b35bd2022-01-01 06:54:25 +00001146cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001147 return ret;
Hanno Becker02b35bd2022-01-01 06:54:25 +00001148}
1149
Gilles Peskine449bd832023-01-11 14:50:10 +01001150static inline int mbedtls_mpi_sub_int_mod(const mbedtls_ecp_group *grp,
1151 mbedtls_mpi *X,
1152 const mbedtls_mpi *A,
1153 mbedtls_mpi_uint c)
Hanno Beckerce29ae82022-01-04 04:55:11 +00001154{
1155 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1156
Gilles Peskine449bd832023-01-11 14:50:10 +01001157 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_int(X, A, c));
1158 MOD_SUB(X);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001159cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001160 return ret;
Hanno Beckerce29ae82022-01-04 04:55:11 +00001161}
1162
Gilles Peskine449bd832023-01-11 14:50:10 +01001163#define MPI_ECP_SUB_INT(X, A, c) \
1164 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_int_mod(grp, X, A, c))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001165
Steven Cooremane5388962021-03-01 14:04:53 +01001166#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED) && \
Gilles Peskine449bd832023-01-11 14:50:10 +01001167 !(defined(MBEDTLS_ECP_NO_FALLBACK) && \
1168 defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) && \
1169 defined(MBEDTLS_ECP_ADD_MIXED_ALT))
1170static inline int mbedtls_mpi_shift_l_mod(const mbedtls_ecp_group *grp,
1171 mbedtls_mpi *X,
1172 size_t count)
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001173{
Janos Follath24eed8d2019-11-22 13:21:35 +00001174 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001175 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_l(X, count));
1176 MOD_ADD(X);
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001177cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001178 return ret;
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001179}
Gilles Peskine449bd832023-01-11 14:50:10 +01001180#endif \
1181 /* All functions referencing mbedtls_mpi_shift_l_mod() are alt-implemented without fallback */
Gilles Peskine3b3b34f2019-07-18 21:08:27 +02001182
Hanno Becker595616e2022-01-05 08:28:24 +00001183/*
1184 * Macro wrappers around ECP modular arithmetic
1185 *
1186 * Currently, these wrappers are defined via the bignum module.
1187 */
1188
Gilles Peskine449bd832023-01-11 14:50:10 +01001189#define MPI_ECP_ADD(X, A, B) \
1190 MBEDTLS_MPI_CHK(mbedtls_mpi_add_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001191
Gilles Peskine449bd832023-01-11 14:50:10 +01001192#define MPI_ECP_SUB(X, A, B) \
1193 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001194
Gilles Peskine449bd832023-01-11 14:50:10 +01001195#define MPI_ECP_MUL(X, A, B) \
1196 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mod(grp, X, A, B))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001197
Gilles Peskine449bd832023-01-11 14:50:10 +01001198#define MPI_ECP_SQR(X, A) \
1199 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_mod(grp, X, A, A))
Hanno Becker885ed402022-01-04 06:43:50 +00001200
Gilles Peskine449bd832023-01-11 14:50:10 +01001201#define MPI_ECP_MUL_INT(X, A, c) \
1202 MBEDTLS_MPI_CHK(mbedtls_mpi_mul_int_mod(grp, X, A, c))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001203
Gilles Peskine449bd832023-01-11 14:50:10 +01001204#define MPI_ECP_INV(dst, src) \
1205 MBEDTLS_MPI_CHK(mbedtls_mpi_inv_mod((dst), (src), &grp->P))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001206
Gilles Peskine449bd832023-01-11 14:50:10 +01001207#define MPI_ECP_MOV(X, A) \
1208 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(X, A))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001209
Gilles Peskine449bd832023-01-11 14:50:10 +01001210#define MPI_ECP_SHIFT_L(X, count) \
1211 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_l_mod(grp, X, count))
Hanno Beckerce29ae82022-01-04 04:55:11 +00001212
Gilles Peskine449bd832023-01-11 14:50:10 +01001213#define MPI_ECP_LSET(X, c) \
1214 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(X, c))
Hanno Becker595616e2022-01-05 08:28:24 +00001215
Gilles Peskine449bd832023-01-11 14:50:10 +01001216#define MPI_ECP_CMP_INT(X, c) \
1217 mbedtls_mpi_cmp_int(X, c)
Hanno Becker595616e2022-01-05 08:28:24 +00001218
Gilles Peskine449bd832023-01-11 14:50:10 +01001219#define MPI_ECP_CMP(X, Y) \
1220 mbedtls_mpi_cmp_mpi(X, Y)
Hanno Becker595616e2022-01-05 08:28:24 +00001221
1222/* Needs f_rng, p_rng to be defined. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001223#define MPI_ECP_RAND(X) \
1224 MBEDTLS_MPI_CHK(mbedtls_mpi_random((X), 2, &grp->P, f_rng, p_rng))
Hanno Becker595616e2022-01-05 08:28:24 +00001225
1226/* Conditional negation
1227 * Needs grp and a temporary MPI tmp to be defined. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001228#define MPI_ECP_COND_NEG(X, cond) \
Hanno Becker595616e2022-01-05 08:28:24 +00001229 do \
1230 { \
Gilles Peskine449bd832023-01-11 14:50:10 +01001231 unsigned char nonzero = mbedtls_mpi_cmp_int((X), 0) != 0; \
1232 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&tmp, &grp->P, (X))); \
1233 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign((X), &tmp, \
1234 nonzero & cond)); \
1235 } while (0)
Hanno Becker595616e2022-01-05 08:28:24 +00001236
Gilles Peskine449bd832023-01-11 14:50:10 +01001237#define MPI_ECP_NEG(X) MPI_ECP_COND_NEG((X), 1)
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001238
Gilles Peskine449bd832023-01-11 14:50:10 +01001239#define MPI_ECP_VALID(X) \
1240 ((X)->p != NULL)
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001241
Gilles Peskine449bd832023-01-11 14:50:10 +01001242#define MPI_ECP_COND_ASSIGN(X, Y, cond) \
1243 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign((X), (Y), (cond)))
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001244
Gilles Peskine449bd832023-01-11 14:50:10 +01001245#define MPI_ECP_COND_SWAP(X, Y, cond) \
1246 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_swap((X), (Y), (cond)))
Hanno Beckerc27a0e02022-01-06 05:56:34 +00001247
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02001248#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Glenn Straussefde9d52022-12-20 04:20:12 -05001249
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001250/*
1251 * Computes the right-hand side of the Short Weierstrass equation
1252 * RHS = X^3 + A X + B
1253 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001254static int ecp_sw_rhs(const mbedtls_ecp_group *grp,
1255 mbedtls_mpi *rhs,
1256 const mbedtls_mpi *X)
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001257{
1258 int ret;
1259
1260 /* Compute X^3 + A X + B as X (X^2 + A) + B */
Gilles Peskine449bd832023-01-11 14:50:10 +01001261 MPI_ECP_SQR(rhs, X);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001262
1263 /* Special case for A = -3 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001264 if (grp->A.p == NULL) {
1265 MPI_ECP_SUB_INT(rhs, rhs, 3);
1266 } else {
1267 MPI_ECP_ADD(rhs, rhs, &grp->A);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001268 }
1269
Gilles Peskine449bd832023-01-11 14:50:10 +01001270 MPI_ECP_MUL(rhs, rhs, X);
1271 MPI_ECP_ADD(rhs, rhs, &grp->B);
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001272
1273cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001274 return ret;
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001275}
1276
1277/*
1278 * Derive Y from X and a parity bit
1279 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001280static int mbedtls_ecp_sw_derive_y(const mbedtls_ecp_group *grp,
1281 const mbedtls_mpi *X,
1282 mbedtls_mpi *Y,
1283 int parity_bit)
Glenn Strauss45241612022-12-19 19:37:07 -05001284{
1285 /* w = y^2 = x^3 + ax + b
1286 * y = sqrt(w) = w^((p+1)/4) mod p (for prime p where p = 3 mod 4)
1287 *
1288 * Note: this method for extracting square root does not validate that w
1289 * was indeed a square so this function will return garbage in Y if X
1290 * does not correspond to a point on the curve.
1291 */
1292
1293 /* Check prerequisite p = 3 mod 4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001294 if (mbedtls_mpi_get_bit(&grp->P, 0) != 1 ||
1295 mbedtls_mpi_get_bit(&grp->P, 1) != 1) {
1296 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
1297 }
Glenn Strauss45241612022-12-19 19:37:07 -05001298
1299 int ret;
1300 mbedtls_mpi exp;
Gilles Peskine449bd832023-01-11 14:50:10 +01001301 mbedtls_mpi_init(&exp);
Glenn Strauss45241612022-12-19 19:37:07 -05001302
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01001303 /* use Y to store intermediate result, actually w above */
Gilles Peskine449bd832023-01-11 14:50:10 +01001304 MBEDTLS_MPI_CHK(ecp_sw_rhs(grp, Y, X));
Glenn Strauss45241612022-12-19 19:37:07 -05001305
1306 /* w = y^2 */ /* Y contains y^2 intermediate result */
1307 /* exp = ((p+1)/4) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001308 MBEDTLS_MPI_CHK(mbedtls_mpi_add_int(&exp, &grp->P, 1));
1309 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_r(&exp, 2));
Glenn Strauss45241612022-12-19 19:37:07 -05001310 /* sqrt(w) = w^((p+1)/4) mod p (for prime p where p = 3 mod 4) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001311 MBEDTLS_MPI_CHK(mbedtls_mpi_exp_mod(Y, Y /*y^2*/, &exp, &grp->P, NULL));
Glenn Strauss45241612022-12-19 19:37:07 -05001312
1313 /* check parity bit match or else invert Y */
1314 /* This quick inversion implementation is valid because Y != 0 for all
1315 * Short Weierstrass curves supported by mbedtls, as each supported curve
1316 * has an order that is a large prime, so each supported curve does not
1317 * have any point of order 2, and a point with Y == 0 would be of order 2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001318 if (mbedtls_mpi_get_bit(Y, 0) != parity_bit) {
1319 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(Y, &grp->P, Y));
1320 }
Glenn Strauss45241612022-12-19 19:37:07 -05001321
1322cleanup:
1323
Gilles Peskine449bd832023-01-11 14:50:10 +01001324 mbedtls_mpi_free(&exp);
1325 return ret;
Glenn Strauss45241612022-12-19 19:37:07 -05001326}
Glenn Strauss45241612022-12-19 19:37:07 -05001327
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01001328/*
1329 * For curves in short Weierstrass form, we do all the internal operations in
1330 * Jacobian coordinates.
1331 *
Shaun Case8b0ecbc2021-12-20 21:14:10 -08001332 * For multiplication, we'll use a comb method with countermeasures against
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01001333 * SPA, hence timing attacks.
1334 */
1335
Manuel Pégourié-Gonnard84d1aea2012-11-09 02:09:38 +01001336/*
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +01001337 * Normalize jacobian coordinates so that Z == 0 || Z == 1 (GECC 3.2.1)
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001338 * Cost: 1N := 1I + 3M + 1S
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001339 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001340static int ecp_normalize_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001341{
Gilles Peskine449bd832023-01-11 14:50:10 +01001342 if (MPI_ECP_CMP_INT(&pt->Z, 0) == 0) {
1343 return 0;
1344 }
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001345
Janos Follathb0697532016-08-18 12:38:46 +01001346#if defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001347 if (mbedtls_internal_ecp_grp_capable(grp)) {
1348 return mbedtls_internal_ecp_normalize_jac(grp, pt);
1349 }
Janos Follath372697b2016-10-28 16:53:11 +01001350#endif /* MBEDTLS_ECP_NORMALIZE_JAC_ALT */
Manuel Pégourié-Gonnardebac5d32017-08-23 16:23:36 +02001351
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001352#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001353 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001354#else
1355 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker76f897d2022-01-02 12:47:34 +00001356 mbedtls_mpi T;
Gilles Peskine449bd832023-01-11 14:50:10 +01001357 mbedtls_mpi_init(&T);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001358
Gilles Peskine449bd832023-01-11 14:50:10 +01001359 MPI_ECP_INV(&T, &pt->Z); /* T <- 1 / Z */
1360 MPI_ECP_MUL(&pt->Y, &pt->Y, &T); /* Y' <- Y*T = Y / Z */
1361 MPI_ECP_SQR(&T, &T); /* T <- T^2 = 1 / Z^2 */
1362 MPI_ECP_MUL(&pt->X, &pt->X, &T); /* X <- X * T = X / Z^2 */
1363 MPI_ECP_MUL(&pt->Y, &pt->Y, &T); /* Y'' <- Y' * T = Y / Z^3 */
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001364
Gilles Peskine449bd832023-01-11 14:50:10 +01001365 MPI_ECP_LSET(&pt->Z, 1);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001366
1367cleanup:
1368
Gilles Peskine449bd832023-01-11 14:50:10 +01001369 mbedtls_mpi_free(&T);
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001370
Gilles Peskine449bd832023-01-11 14:50:10 +01001371 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001372#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_JAC_ALT) */
Manuel Pégourié-Gonnardd070f512012-11-08 17:40:51 +01001373}
1374
1375/*
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001376 * Normalize jacobian coordinates of an array of (pointers to) points,
Manuel Pégourié-Gonnard3680c822012-11-21 18:49:45 +01001377 * using Montgomery's trick to perform only one inversion mod P.
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001378 * (See for example Cohen's "A Course in Computational Algebraic Number
1379 * Theory", Algorithm 10.3.4.)
1380 *
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001381 * Warning: fails (returning an error) if one of the points is zero!
Manuel Pégourié-Gonnard7a949d32013-12-05 10:26:01 +01001382 * This should never happen, see choice of w in ecp_mul_comb().
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001383 *
1384 * Cost: 1N(t) := 1I + (6t - 3)M + 1S
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001385 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001386static int ecp_normalize_jac_many(const mbedtls_ecp_group *grp,
1387 mbedtls_ecp_point *T[], size_t T_size)
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001388{
Gilles Peskine449bd832023-01-11 14:50:10 +01001389 if (T_size < 2) {
1390 return ecp_normalize_jac(grp, *T);
1391 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001392
Janos Follathb0697532016-08-18 12:38:46 +01001393#if defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001394 if (mbedtls_internal_ecp_grp_capable(grp)) {
1395 return mbedtls_internal_ecp_normalize_jac_many(grp, T, T_size);
1396 }
Janos Follathb0697532016-08-18 12:38:46 +01001397#endif
1398
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001399#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001400 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001401#else
1402 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
1403 size_t i;
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001404 mbedtls_mpi *c, t;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001405
Gilles Peskine449bd832023-01-11 14:50:10 +01001406 if ((c = mbedtls_calloc(T_size, sizeof(mbedtls_mpi))) == NULL) {
1407 return MBEDTLS_ERR_ECP_ALLOC_FAILED;
1408 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001409
Gilles Peskine449bd832023-01-11 14:50:10 +01001410 mbedtls_mpi_init(&t);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001411
Gilles Peskine449bd832023-01-11 14:50:10 +01001412 mpi_init_many(c, T_size);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001413 /*
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001414 * c[i] = Z_0 * ... * Z_i, i = 0,..,n := T_size-1
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001415 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001416 MPI_ECP_MOV(&c[0], &T[0]->Z);
1417 for (i = 1; i < T_size; i++) {
1418 MPI_ECP_MUL(&c[i], &c[i-1], &T[i]->Z);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001419 }
1420
1421 /*
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001422 * c[n] = 1 / (Z_0 * ... * Z_n) mod P
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001423 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001424 MPI_ECP_INV(&c[T_size-1], &c[T_size-1]);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001425
Gilles Peskine449bd832023-01-11 14:50:10 +01001426 for (i = T_size - 1;; i--) {
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001427 /* At the start of iteration i (note that i decrements), we have
1428 * - c[j] = Z_0 * .... * Z_j for j < i,
1429 * - c[j] = 1 / (Z_0 * .... * Z_j) for j == i,
1430 *
1431 * This is maintained via
1432 * - c[i-1] <- c[i] * Z_i
1433 *
1434 * We also derive 1/Z_i = c[i] * c[i-1] for i>0 and use that
1435 * to do the actual normalization. For i==0, we already have
1436 * c[0] = 1 / Z_0.
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001437 */
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001438
Gilles Peskine449bd832023-01-11 14:50:10 +01001439 if (i > 0) {
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001440 /* Compute 1/Z_i and establish invariant for the next iteration. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001441 MPI_ECP_MUL(&t, &c[i], &c[i-1]);
1442 MPI_ECP_MUL(&c[i-1], &c[i], &T[i]->Z);
1443 } else {
1444 MPI_ECP_MOV(&t, &c[0]);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001445 }
1446
Hanno Beckerb8442cd2022-01-04 06:32:11 +00001447 /* Now t holds 1 / Z_i; normalize as in ecp_normalize_jac() */
Gilles Peskine449bd832023-01-11 14:50:10 +01001448 MPI_ECP_MUL(&T[i]->Y, &T[i]->Y, &t);
1449 MPI_ECP_SQR(&t, &t);
1450 MPI_ECP_MUL(&T[i]->X, &T[i]->X, &t);
1451 MPI_ECP_MUL(&T[i]->Y, &T[i]->Y, &t);
Manuel Pégourié-Gonnard1f789b82013-12-30 17:31:56 +01001452
1453 /*
1454 * Post-precessing: reclaim some memory by shrinking coordinates
1455 * - not storing Z (always 1)
1456 * - shrinking other coordinates, but still keeping the same number of
1457 * limbs as P, as otherwise it will too likely be regrown too fast.
1458 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001459 MBEDTLS_MPI_CHK(mbedtls_mpi_shrink(&T[i]->X, grp->P.n));
1460 MBEDTLS_MPI_CHK(mbedtls_mpi_shrink(&T[i]->Y, grp->P.n));
Hanno Beckeree95f6c2022-01-09 05:46:18 +00001461
Gilles Peskine449bd832023-01-11 14:50:10 +01001462 MPI_ECP_LSET(&T[i]->Z, 1);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001463
Gilles Peskine449bd832023-01-11 14:50:10 +01001464 if (i == 0) {
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001465 break;
Gilles Peskine449bd832023-01-11 14:50:10 +01001466 }
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001467 }
1468
1469cleanup:
1470
Gilles Peskine449bd832023-01-11 14:50:10 +01001471 mbedtls_mpi_free(&t);
1472 mpi_free_many(c, T_size);
1473 mbedtls_free(c);
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001474
Gilles Peskine449bd832023-01-11 14:50:10 +01001475 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001476#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_JAC_MANY_ALT) */
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001477}
1478
Manuel Pégourié-Gonnardcdd44322012-11-21 16:00:55 +01001479/*
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001480 * Conditional point inversion: Q -> -Q = (Q.X, -Q.Y, Q.Z) without leak.
1481 * "inv" must be 0 (don't invert) or 1 (invert) or the result will be invalid
1482 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001483static int ecp_safe_invert_jac(const mbedtls_ecp_group *grp,
1484 mbedtls_ecp_point *Q,
1485 unsigned char inv)
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001486{
Janos Follath24eed8d2019-11-22 13:21:35 +00001487 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker595616e2022-01-05 08:28:24 +00001488 mbedtls_mpi tmp;
Gilles Peskine449bd832023-01-11 14:50:10 +01001489 mbedtls_mpi_init(&tmp);
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001490
Gilles Peskine449bd832023-01-11 14:50:10 +01001491 MPI_ECP_COND_NEG(&Q->Y, inv);
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001492
1493cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001494 mbedtls_mpi_free(&tmp);
1495 return ret;
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01001496}
1497
1498/*
Manuel Pégourié-Gonnard0cd6f982013-10-10 15:55:39 +02001499 * Point doubling R = 2 P, Jacobian coordinates
Manuel Pégourié-Gonnard0ace4b32013-10-10 12:44:27 +02001500 *
Peter Dettmance661b22015-02-07 14:43:51 +07001501 * Based on http://www.hyperelliptic.org/EFD/g1p/auto-shortw-jacobian.html#doubling-dbl-1998-cmo-2 .
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001502 *
Peter Dettmance661b22015-02-07 14:43:51 +07001503 * We follow the variable naming fairly closely. The formula variations that trade a MUL for a SQR
1504 * (plus a few ADDs) aren't useful as our bignum implementation doesn't distinguish squaring.
1505 *
1506 * Standard optimizations are applied when curve parameter A is one of { 0, -3 }.
1507 *
1508 * Cost: 1D := 3M + 4S (A == 0)
1509 * 4M + 4S (A == -3)
1510 * 3M + 6S + 1a otherwise
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001511 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001512static int ecp_double_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
1513 const mbedtls_ecp_point *P,
1514 mbedtls_mpi tmp[4])
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001515{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001516#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard0cd6f982013-10-10 15:55:39 +02001517 dbl_count++;
1518#endif
1519
Janos Follathb0697532016-08-18 12:38:46 +01001520#if defined(MBEDTLS_ECP_DOUBLE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001521 if (mbedtls_internal_ecp_grp_capable(grp)) {
1522 return mbedtls_internal_ecp_double_jac(grp, R, P);
1523 }
Janos Follath372697b2016-10-28 16:53:11 +01001524#endif /* MBEDTLS_ECP_DOUBLE_JAC_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001525
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001526#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_DOUBLE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001527 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001528#else
1529 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard73cc01d2013-12-06 12:41:30 +01001530
1531 /* Special case for A = -3 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001532 if (grp->A.p == NULL) {
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001533 /* tmp[0] <- M = 3(X + Z^2)(X - Z^2) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001534 MPI_ECP_SQR(&tmp[1], &P->Z);
1535 MPI_ECP_ADD(&tmp[2], &P->X, &tmp[1]);
1536 MPI_ECP_SUB(&tmp[3], &P->X, &tmp[1]);
1537 MPI_ECP_MUL(&tmp[1], &tmp[2], &tmp[3]);
1538 MPI_ECP_MUL_INT(&tmp[0], &tmp[1], 3);
1539 } else {
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001540 /* tmp[0] <- M = 3.X^2 + A.Z^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001541 MPI_ECP_SQR(&tmp[1], &P->X);
1542 MPI_ECP_MUL_INT(&tmp[0], &tmp[1], 3);
Peter Dettmance661b22015-02-07 14:43:51 +07001543
1544 /* Optimize away for "koblitz" curves with A = 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001545 if (MPI_ECP_CMP_INT(&grp->A, 0) != 0) {
Peter Dettmance661b22015-02-07 14:43:51 +07001546 /* M += A.Z^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001547 MPI_ECP_SQR(&tmp[1], &P->Z);
1548 MPI_ECP_SQR(&tmp[2], &tmp[1]);
1549 MPI_ECP_MUL(&tmp[1], &tmp[2], &grp->A);
1550 MPI_ECP_ADD(&tmp[0], &tmp[0], &tmp[1]);
Peter Dettmance661b22015-02-07 14:43:51 +07001551 }
Peter Vaskovica676acf2014-08-06 00:48:39 +02001552 }
Manuel Pégourié-Gonnard73cc01d2013-12-06 12:41:30 +01001553
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001554 /* tmp[1] <- S = 4.X.Y^2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001555 MPI_ECP_SQR(&tmp[2], &P->Y);
1556 MPI_ECP_SHIFT_L(&tmp[2], 1);
1557 MPI_ECP_MUL(&tmp[1], &P->X, &tmp[2]);
1558 MPI_ECP_SHIFT_L(&tmp[1], 1);
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001559
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001560 /* tmp[3] <- U = 8.Y^4 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001561 MPI_ECP_SQR(&tmp[3], &tmp[2]);
1562 MPI_ECP_SHIFT_L(&tmp[3], 1);
Peter Dettmance661b22015-02-07 14:43:51 +07001563
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001564 /* tmp[2] <- T = M^2 - 2.S */
Gilles Peskine449bd832023-01-11 14:50:10 +01001565 MPI_ECP_SQR(&tmp[2], &tmp[0]);
1566 MPI_ECP_SUB(&tmp[2], &tmp[2], &tmp[1]);
1567 MPI_ECP_SUB(&tmp[2], &tmp[2], &tmp[1]);
Peter Dettmance661b22015-02-07 14:43:51 +07001568
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001569 /* tmp[1] <- S = M(S - T) - U */
Gilles Peskine449bd832023-01-11 14:50:10 +01001570 MPI_ECP_SUB(&tmp[1], &tmp[1], &tmp[2]);
1571 MPI_ECP_MUL(&tmp[1], &tmp[1], &tmp[0]);
1572 MPI_ECP_SUB(&tmp[1], &tmp[1], &tmp[3]);
Peter Dettmance661b22015-02-07 14:43:51 +07001573
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001574 /* tmp[3] <- U = 2.Y.Z */
Gilles Peskine449bd832023-01-11 14:50:10 +01001575 MPI_ECP_MUL(&tmp[3], &P->Y, &P->Z);
1576 MPI_ECP_SHIFT_L(&tmp[3], 1);
Peter Dettmance661b22015-02-07 14:43:51 +07001577
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001578 /* Store results */
Gilles Peskine449bd832023-01-11 14:50:10 +01001579 MPI_ECP_MOV(&R->X, &tmp[2]);
1580 MPI_ECP_MOV(&R->Y, &tmp[1]);
1581 MPI_ECP_MOV(&R->Z, &tmp[3]);
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001582
1583cleanup:
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001584
Gilles Peskine449bd832023-01-11 14:50:10 +01001585 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001586#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_DOUBLE_JAC_ALT) */
Manuel Pégourié-Gonnard1c4aa242013-10-09 16:09:46 +02001587}
1588
1589/*
Manuel Pégourié-Gonnard469a2092013-11-21 18:20:43 +01001590 * Addition: R = P + Q, mixed affine-Jacobian coordinates (GECC 3.22)
Manuel Pégourié-Gonnard9674fd02012-11-19 21:23:27 +01001591 *
1592 * The coordinates of Q must be normalized (= affine),
1593 * but those of P don't need to. R is not normalized.
1594 *
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001595 * P,Q,R may alias, but only at the level of EC points: they must be either
1596 * equal as pointers, or disjoint (including the coordinate data buffers).
1597 * Fine-grained aliasing at the level of coordinates is not supported.
1598 *
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001599 * Special cases: (1) P or Q is zero, (2) R is zero, (3) P == Q.
Manuel Pégourié-Gonnard7a949d32013-12-05 10:26:01 +01001600 * None of these cases can happen as intermediate step in ecp_mul_comb():
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001601 * - at each step, P, Q and R are multiples of the base point, the factor
1602 * being less than its order, so none of them is zero;
1603 * - Q is an odd multiple of the base point, P an even multiple,
1604 * due to the choice of precomputed points in the modified comb method.
1605 * So branches for these cases do not leak secret information.
1606 *
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001607 * Cost: 1A := 8M + 3S
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001608 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001609static int ecp_add_mixed(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
1610 const mbedtls_ecp_point *P, const mbedtls_ecp_point *Q,
1611 mbedtls_mpi tmp[4])
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001612{
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001613#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01001614 add_count++;
1615#endif
1616
Janos Follathb0697532016-08-18 12:38:46 +01001617#if defined(MBEDTLS_ECP_ADD_MIXED_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001618 if (mbedtls_internal_ecp_grp_capable(grp)) {
1619 return mbedtls_internal_ecp_add_mixed(grp, R, P, Q);
1620 }
Janos Follath372697b2016-10-28 16:53:11 +01001621#endif /* MBEDTLS_ECP_ADD_MIXED_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001622
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001623#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_ADD_MIXED_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001624 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001625#else
1626 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker838b7152022-01-04 05:01:53 +00001627
1628 /* NOTE: Aliasing between input and output is allowed, so one has to make
1629 * sure that at the point X,Y,Z are written, {P,Q}->{X,Y,Z} are no
1630 * longer read from. */
Hanno Becker5c8ea302022-01-01 06:01:45 +00001631 mbedtls_mpi * const X = &R->X;
1632 mbedtls_mpi * const Y = &R->Y;
1633 mbedtls_mpi * const Z = &R->Z;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001634
Gilles Peskine449bd832023-01-11 14:50:10 +01001635 if (!MPI_ECP_VALID(&Q->Z)) {
1636 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1637 }
Hanno Beckeree95f6c2022-01-09 05:46:18 +00001638
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001639 /*
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001640 * Trivial cases: P == 0 or Q == 0 (case 1)
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001641 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001642 if (MPI_ECP_CMP_INT(&P->Z, 0) == 0) {
1643 return mbedtls_ecp_copy(R, Q);
1644 }
Manuel Pégourié-Gonnard469a2092013-11-21 18:20:43 +01001645
Gilles Peskine449bd832023-01-11 14:50:10 +01001646 if (MPI_ECP_CMP_INT(&Q->Z, 0) == 0) {
1647 return mbedtls_ecp_copy(R, P);
1648 }
Manuel Pégourié-Gonnard1c2782c2012-11-19 20:16:28 +01001649
1650 /*
1651 * Make sure Q coordinates are normalized
1652 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001653 if (MPI_ECP_CMP_INT(&Q->Z, 1) != 0) {
1654 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
1655 }
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001656
Gilles Peskine449bd832023-01-11 14:50:10 +01001657 MPI_ECP_SQR(&tmp[0], &P->Z);
1658 MPI_ECP_MUL(&tmp[1], &tmp[0], &P->Z);
1659 MPI_ECP_MUL(&tmp[0], &tmp[0], &Q->X);
1660 MPI_ECP_MUL(&tmp[1], &tmp[1], &Q->Y);
1661 MPI_ECP_SUB(&tmp[0], &tmp[0], &P->X);
1662 MPI_ECP_SUB(&tmp[1], &tmp[1], &P->Y);
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001663
Manuel Pégourié-Gonnardaade42f2013-11-21 19:19:54 +01001664 /* Special cases (2) and (3) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001665 if (MPI_ECP_CMP_INT(&tmp[0], 0) == 0) {
1666 if (MPI_ECP_CMP_INT(&tmp[1], 0) == 0) {
1667 ret = ecp_double_jac(grp, R, P, tmp);
Manuel Pégourié-Gonnard7e0adfb2012-11-08 23:21:46 +01001668 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01001669 } else {
1670 ret = mbedtls_ecp_set_zero(R);
Manuel Pégourié-Gonnard7e0adfb2012-11-08 23:21:46 +01001671 goto cleanup;
1672 }
1673 }
1674
Hanno Becker838b7152022-01-04 05:01:53 +00001675 /* {P,Q}->Z no longer used, so OK to write to Z even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001676 MPI_ECP_MUL(Z, &P->Z, &tmp[0]);
1677 MPI_ECP_SQR(&tmp[2], &tmp[0]);
1678 MPI_ECP_MUL(&tmp[3], &tmp[2], &tmp[0]);
1679 MPI_ECP_MUL(&tmp[2], &tmp[2], &P->X);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001680
Gilles Peskine449bd832023-01-11 14:50:10 +01001681 MPI_ECP_MOV(&tmp[0], &tmp[2]);
1682 MPI_ECP_SHIFT_L(&tmp[0], 1);
Hanno Beckerce29ae82022-01-04 04:55:11 +00001683
Hanno Becker838b7152022-01-04 05:01:53 +00001684 /* {P,Q}->X no longer used, so OK to write to X even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001685 MPI_ECP_SQR(X, &tmp[1]);
1686 MPI_ECP_SUB(X, X, &tmp[0]);
1687 MPI_ECP_SUB(X, X, &tmp[3]);
1688 MPI_ECP_SUB(&tmp[2], &tmp[2], X);
1689 MPI_ECP_MUL(&tmp[2], &tmp[2], &tmp[1]);
1690 MPI_ECP_MUL(&tmp[3], &tmp[3], &P->Y);
Hanno Becker838b7152022-01-04 05:01:53 +00001691 /* {P,Q}->Y no longer used, so OK to write to Y even if there's aliasing. */
Gilles Peskine449bd832023-01-11 14:50:10 +01001692 MPI_ECP_SUB(Y, &tmp[2], &tmp[3]);
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001693
1694cleanup:
1695
Gilles Peskine449bd832023-01-11 14:50:10 +01001696 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001697#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_ADD_MIXED_ALT) */
Manuel Pégourié-Gonnardae180d02012-11-02 18:14:40 +01001698}
1699
1700/*
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001701 * Randomize jacobian coordinates:
1702 * (X, Y, Z) -> (l^2 X, l^3 Y, l Z) for random l
Manuel Pégourié-Gonnard3c0b4ea2013-12-02 19:44:41 +01001703 * This is sort of the reverse operation of ecp_normalize_jac().
Manuel Pégourié-Gonnard44aab792013-11-21 10:53:59 +01001704 *
1705 * This countermeasure was first suggested in [2].
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001706 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001707static int ecp_randomize_jac(const mbedtls_ecp_group *grp, mbedtls_ecp_point *pt,
1708 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001709{
Janos Follathb0697532016-08-18 12:38:46 +01001710#if defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001711 if (mbedtls_internal_ecp_grp_capable(grp)) {
1712 return mbedtls_internal_ecp_randomize_jac(grp, pt, f_rng, p_rng);
1713 }
Janos Follath372697b2016-10-28 16:53:11 +01001714#endif /* MBEDTLS_ECP_RANDOMIZE_JAC_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01001715
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001716#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01001717 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001718#else
1719 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Becker0d629792022-01-04 06:45:49 +00001720 mbedtls_mpi l;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001721
Gilles Peskine449bd832023-01-11 14:50:10 +01001722 mbedtls_mpi_init(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001723
1724 /* Generate l such that 1 < l < p */
Gilles Peskine449bd832023-01-11 14:50:10 +01001725 MPI_ECP_RAND(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001726
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001727 /* Z' = l * Z */
Gilles Peskine449bd832023-01-11 14:50:10 +01001728 MPI_ECP_MUL(&pt->Z, &pt->Z, &l);
Hanno Becker0d629792022-01-04 06:45:49 +00001729
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001730 /* Y' = l * Y */
Gilles Peskine449bd832023-01-11 14:50:10 +01001731 MPI_ECP_MUL(&pt->Y, &pt->Y, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001732
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001733 /* X' = l^2 * X */
Gilles Peskine449bd832023-01-11 14:50:10 +01001734 MPI_ECP_SQR(&l, &l);
1735 MPI_ECP_MUL(&pt->X, &pt->X, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001736
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001737 /* Y'' = l^2 * Y' = l^3 * Y */
Gilles Peskine449bd832023-01-11 14:50:10 +01001738 MPI_ECP_MUL(&pt->Y, &pt->Y, &l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001739
1740cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01001741 mbedtls_mpi_free(&l);
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001742
Gilles Peskine449bd832023-01-11 14:50:10 +01001743 if (ret == MBEDTLS_ERR_MPI_NOT_ACCEPTABLE) {
Gilles Peskine59215172021-03-29 22:28:50 +02001744 ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine449bd832023-01-11 14:50:10 +01001745 }
1746 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01001747#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_RANDOMIZE_JAC_ALT) */
Manuel Pégourié-Gonnard07de4b12013-09-02 16:26:04 +02001748}
1749
1750/*
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001751 * Check and define parameters used by the comb method (see below for details)
1752 */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001753#if MBEDTLS_ECP_WINDOW_SIZE < 2 || MBEDTLS_ECP_WINDOW_SIZE > 7
1754#error "MBEDTLS_ECP_WINDOW_SIZE out of bounds"
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001755#endif
1756
1757/* d = ceil( n / w ) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001758#define COMB_MAX_D (MBEDTLS_ECP_MAX_BITS + 1) / 2
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001759
1760/* number of precomputed points */
Gilles Peskine449bd832023-01-11 14:50:10 +01001761#define COMB_MAX_PRE (1 << (MBEDTLS_ECP_WINDOW_SIZE - 1))
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001762
1763/*
1764 * Compute the representation of m that will be used with our comb method.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001765 *
1766 * The basic comb method is described in GECC 3.44 for example. We use a
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001767 * modified version that provides resistance to SPA by avoiding zero
1768 * digits in the representation as in [3]. We modify the method further by
1769 * requiring that all K_i be odd, which has the small cost that our
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001770 * representation uses one more K_i, due to carries, but saves on the size of
1771 * the precomputed table.
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001772 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001773 * Summary of the comb method and its modifications:
1774 *
1775 * - The goal is to compute m*P for some w*d-bit integer m.
1776 *
1777 * - The basic comb method splits m into the w-bit integers
1778 * x[0] .. x[d-1] where x[i] consists of the bits in m whose
1779 * index has residue i modulo d, and computes m * P as
1780 * S[x[0]] + 2 * S[x[1]] + .. + 2^(d-1) S[x[d-1]], where
1781 * S[i_{w-1} .. i_0] := i_{w-1} 2^{(w-1)d} P + ... + i_1 2^d P + i_0 P.
1782 *
1783 * - If it happens that, say, x[i+1]=0 (=> S[x[i+1]]=0), one can replace the sum by
1784 * .. + 2^{i-1} S[x[i-1]] - 2^i S[x[i]] + 2^{i+1} S[x[i]] + 2^{i+2} S[x[i+2]] ..,
1785 * thereby successively converting it into a form where all summands
1786 * are nonzero, at the cost of negative summands. This is the basic idea of [3].
1787 *
1788 * - More generally, even if x[i+1] != 0, we can first transform the sum as
1789 * .. - 2^i S[x[i]] + 2^{i+1} ( S[x[i]] + S[x[i+1]] ) + 2^{i+2} S[x[i+2]] ..,
1790 * and then replace S[x[i]] + S[x[i+1]] = S[x[i] ^ x[i+1]] + 2 S[x[i] & x[i+1]].
1791 * Performing and iterating this procedure for those x[i] that are even
1792 * (keeping track of carry), we can transform the original sum into one of the form
1793 * S[x'[0]] +- 2 S[x'[1]] +- .. +- 2^{d-1} S[x'[d-1]] + 2^d S[x'[d]]
1794 * with all x'[i] odd. It is therefore only necessary to know S at odd indices,
1795 * which is why we are only computing half of it in the first place in
1796 * ecp_precompute_comb and accessing it with index abs(i) / 2 in ecp_select_comb.
1797 *
1798 * - For the sake of compactness, only the seven low-order bits of x[i]
1799 * are used to represent its absolute value (K_i in the paper), and the msb
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001800 * of x[i] encodes the sign (s_i in the paper): it is set if and only if
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001801 * if s_i == -1;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001802 *
1803 * Calling conventions:
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001804 * - x is an array of size d + 1
Manuel Pégourié-Gonnardc30200e2013-11-20 18:39:55 +01001805 * - w is the size, ie number of teeth, of the comb, and must be between
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02001806 * 2 and 7 (in practice, between 2 and MBEDTLS_ECP_WINDOW_SIZE)
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001807 * - m is the MPI, expected to be odd and such that bitlength(m) <= w * d
1808 * (the result will be incorrect if these assumptions are not satisfied)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001809 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001810static void ecp_comb_recode_core(unsigned char x[], size_t d,
1811 unsigned char w, const mbedtls_mpi *m)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001812{
1813 size_t i, j;
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001814 unsigned char c, cc, adjust;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001815
Gilles Peskine449bd832023-01-11 14:50:10 +01001816 memset(x, 0, d+1);
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001817
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001818 /* First get the classical comb values (except for x_d = 0) */
Gilles Peskine449bd832023-01-11 14:50:10 +01001819 for (i = 0; i < d; i++) {
1820 for (j = 0; j < w; j++) {
1821 x[i] |= mbedtls_mpi_get_bit(m, i + d * j) << j;
1822 }
1823 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001824
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001825 /* Now make sure x_1 .. x_d are odd */
1826 c = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001827 for (i = 1; i <= d; i++) {
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001828 /* Add carry and update it */
1829 cc = x[i] & c;
1830 x[i] = x[i] ^ c;
1831 c = cc;
1832
Manuel Pégourié-Gonnardedc1a1f2013-11-21 09:50:00 +01001833 /* Adjust if needed, avoiding branches */
Gilles Peskine449bd832023-01-11 14:50:10 +01001834 adjust = 1 - (x[i] & 0x01);
1835 c |= x[i] & (x[i-1] * adjust);
1836 x[i] = x[i] ^ (x[i-1] * adjust);
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001837 x[i-1] |= adjust << 7;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001838 }
1839}
1840
1841/*
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001842 * Precompute points for the adapted comb method
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001843 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001844 * Assumption: T must be able to hold 2^{w - 1} elements.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001845 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001846 * Operation: If i = i_{w-1} ... i_1 is the binary representation of i,
1847 * sets T[i] = i_{w-1} 2^{(w-1)d} P + ... + i_1 2^d P + P.
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01001848 *
1849 * Cost: d(w-1) D + (2^{w-1} - 1) A + 1 N(w-1) + 1 N(2^{w-1} - 1)
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001850 *
1851 * Note: Even comb values (those where P would be omitted from the
1852 * sum defining T[i] above) are not needed in our adaption
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001853 * the comb method. See ecp_comb_recode_core().
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001854 *
1855 * This function currently works in four steps:
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001856 * (1) [dbl] Computation of intermediate T[i] for 2-power values of i
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001857 * (2) [norm_dbl] Normalization of coordinates of these T[i]
1858 * (3) [add] Computation of all T[i]
1859 * (4) [norm_add] Normalization of all T[i]
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02001860 *
1861 * Step 1 can be interrupted but not the others; together with the final
1862 * coordinate normalization they are the largest steps done at once, depending
1863 * on the window size. Here are operation counts for P-256:
1864 *
1865 * step (2) (3) (4)
1866 * w = 5 142 165 208
1867 * w = 4 136 77 160
1868 * w = 3 130 33 136
1869 * w = 2 124 11 124
1870 *
1871 * So if ECC operations are blocking for too long even with a low max_ops
1872 * value, it's useful to set MBEDTLS_ECP_WINDOW_SIZE to a lower value in order
1873 * to minimize maximum blocking time.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001874 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001875static int ecp_precompute_comb(const mbedtls_ecp_group *grp,
1876 mbedtls_ecp_point T[], const mbedtls_ecp_point *P,
1877 unsigned char w, size_t d,
1878 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001879{
Janos Follath24eed8d2019-11-22 13:21:35 +00001880 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001881 unsigned char i;
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001882 size_t j = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001883 const unsigned char T_size = 1U << (w - 1);
1884 mbedtls_ecp_point *cur, *TT[COMB_MAX_PRE - 1] = { NULL };
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001885
Hanno Beckera7f8edd2022-01-04 07:29:46 +00001886 mbedtls_mpi tmp[4];
1887
Gilles Peskine449bd832023-01-11 14:50:10 +01001888 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00001889
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001890#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001891 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
1892 if (rs_ctx->rsm->state == ecp_rsm_pre_dbl) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001893 goto dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001894 }
1895 if (rs_ctx->rsm->state == ecp_rsm_pre_norm_dbl) {
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001896 goto norm_dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001897 }
1898 if (rs_ctx->rsm->state == ecp_rsm_pre_add) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001899 goto add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001900 }
1901 if (rs_ctx->rsm->state == ecp_rsm_pre_norm_add) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001902 goto norm_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001903 }
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01001904 }
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001905#else
1906 (void) rs_ctx;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01001907#endif
1908
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001909#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001910 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001911 rs_ctx->rsm->state = ecp_rsm_pre_dbl;
1912
1913 /* initial state for the loop */
1914 rs_ctx->rsm->i = 0;
1915 }
1916
1917dbl:
1918#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001919 /*
1920 * Set T[0] = P and
1921 * T[2^{l-1}] = 2^{dl} P for l = 1 .. w-1 (this is not the final value)
1922 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001923 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(&T[0], P));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001924
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001925#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001926 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->i != 0) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02001927 j = rs_ctx->rsm->i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001928 } else
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001929#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01001930 j = 0;
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001931
Gilles Peskine449bd832023-01-11 14:50:10 +01001932 for (; j < d * (w - 1); j++) {
1933 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_DBL);
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01001934
Gilles Peskine449bd832023-01-11 14:50:10 +01001935 i = 1U << (j / d);
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001936 cur = T + i;
Manuel Pégourié-Gonnardae557072017-03-20 12:21:24 +01001937
Gilles Peskine449bd832023-01-11 14:50:10 +01001938 if (j % d == 0) {
1939 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(cur, T + (i >> 1)));
1940 }
Manuel Pégourié-Gonnardae557072017-03-20 12:21:24 +01001941
Gilles Peskine449bd832023-01-11 14:50:10 +01001942 MBEDTLS_MPI_CHK(ecp_double_jac(grp, cur, cur, tmp));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001943 }
1944
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001945#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001946 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001947 rs_ctx->rsm->state = ecp_rsm_pre_norm_dbl;
Gilles Peskine449bd832023-01-11 14:50:10 +01001948 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001949
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001950norm_dbl:
1951#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001952 /*
Hanno Beckerac4d4bc2022-01-09 05:58:49 +00001953 * Normalize current elements in T to allow them to be used in
1954 * ecp_add_mixed() below, which requires one normalized input.
1955 *
1956 * As T has holes, use an auxiliary array of pointers to elements in T.
1957 *
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001958 */
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001959 j = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01001960 for (i = 1; i < T_size; i <<= 1) {
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001961 TT[j++] = T + i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001962 }
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01001963
Gilles Peskine449bd832023-01-11 14:50:10 +01001964 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV + 6 * j - 2);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001965
Gilles Peskine449bd832023-01-11 14:50:10 +01001966 MBEDTLS_MPI_CHK(ecp_normalize_jac_many(grp, TT, j));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001967
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001968#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001969 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001970 rs_ctx->rsm->state = ecp_rsm_pre_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001971 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001972
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001973add:
1974#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001975 /*
1976 * Compute the remaining ones using the minimal number of additions
1977 * Be careful to update T[2^l] only after using it!
1978 */
Gilles Peskine449bd832023-01-11 14:50:10 +01001979 MBEDTLS_ECP_BUDGET((T_size - 1) * MBEDTLS_ECP_OPS_ADD);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001980
Gilles Peskine449bd832023-01-11 14:50:10 +01001981 for (i = 1; i < T_size; i <<= 1) {
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01001982 j = i;
Gilles Peskine449bd832023-01-11 14:50:10 +01001983 while (j--) {
1984 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, &T[i + j], &T[j], &T[i], tmp));
1985 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01001986 }
1987
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02001988#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01001989 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001990 rs_ctx->rsm->state = ecp_rsm_pre_norm_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01001991 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02001992
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01001993norm_add:
1994#endif
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001995 /*
Manuel Pégourié-Gonnarda966fde2018-10-23 10:41:11 +02001996 * Normalize final elements in T. Even though there are no holes now, we
1997 * still need the auxiliary array for homogeneity with the previous
1998 * call. Also, skip T[0] which is already normalised, being a copy of P.
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02001999 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002000 for (j = 0; j + 1 < T_size; j++) {
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01002001 TT[j] = T + j + 1;
Gilles Peskine449bd832023-01-11 14:50:10 +01002002 }
Manuel Pégourié-Gonnardfc3e0be2017-03-20 09:29:31 +01002003
Gilles Peskine449bd832023-01-11 14:50:10 +01002004 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV + 6 * j - 2);
Manuel Pégourié-Gonnarde2d7cb32017-03-20 10:24:17 +01002005
Gilles Peskine449bd832023-01-11 14:50:10 +01002006 MBEDTLS_MPI_CHK(ecp_normalize_jac_many(grp, TT, j));
Manuel Pégourié-Gonnarde2820122013-11-21 10:08:50 +01002007
Hanno Beckeree95f6c2022-01-09 05:46:18 +00002008 /* Free Z coordinate (=1 after normalization) to save RAM.
2009 * This makes T[i] invalid as mbedtls_ecp_points, but this is OK
2010 * since from this point onwards, they are only accessed indirectly
2011 * via the getter function ecp_select_comb() which does set the
2012 * target's Z coordinate to 1. */
Gilles Peskine449bd832023-01-11 14:50:10 +01002013 for (i = 0; i < T_size; i++) {
2014 mbedtls_mpi_free(&T[i].Z);
2015 }
Hanno Beckeree95f6c2022-01-09 05:46:18 +00002016
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002017cleanup:
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002018
Gilles Peskine449bd832023-01-11 14:50:10 +01002019 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002020
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002021#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002022 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2023 ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
2024 if (rs_ctx->rsm->state == ecp_rsm_pre_dbl) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002025 rs_ctx->rsm->i = j;
Gilles Peskine449bd832023-01-11 14:50:10 +01002026 }
Manuel Pégourié-Gonnard213541a2017-03-20 12:50:41 +01002027 }
2028#endif
Janos Follathb0697532016-08-18 12:38:46 +01002029
Gilles Peskine449bd832023-01-11 14:50:10 +01002030 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002031}
2032
2033/*
Manuel Pégourié-Gonnard101a39f2013-11-20 14:47:19 +01002034 * Select precomputed point: R = sign(i) * T[ abs(i) / 2 ]
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002035 *
2036 * See ecp_comb_recode_core() for background
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002037 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002038static int ecp_select_comb(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2039 const mbedtls_ecp_point T[], unsigned char T_size,
2040 unsigned char i)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002041{
Janos Follath24eed8d2019-11-22 13:21:35 +00002042 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002043 unsigned char ii, j;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002044
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002045 /* Ignore the "sign" bit and scale down */
Gilles Peskine449bd832023-01-11 14:50:10 +01002046 ii = (i & 0x7Fu) >> 1;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002047
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002048 /* Read the whole table to thwart cache-based timing attacks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002049 for (j = 0; j < T_size; j++) {
2050 MPI_ECP_COND_ASSIGN(&R->X, &T[j].X, j == ii);
2051 MPI_ECP_COND_ASSIGN(&R->Y, &T[j].Y, j == ii);
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002052 }
2053
Manuel Pégourié-Gonnard01fca5e2013-11-21 17:47:12 +01002054 /* Safely invert result if i is "negative" */
Gilles Peskine449bd832023-01-11 14:50:10 +01002055 MBEDTLS_MPI_CHK(ecp_safe_invert_jac(grp, R, i >> 7));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002056
Gilles Peskine449bd832023-01-11 14:50:10 +01002057 MPI_ECP_LSET(&R->Z, 1);
Hanno Becker6a288702022-01-05 05:19:48 +00002058
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002059cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002060 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002061}
2062
2063/*
2064 * Core multiplication algorithm for the (modified) comb method.
2065 * This part is actually common with the basic comb method (GECC 3.44)
Manuel Pégourié-Gonnard04a02252013-11-20 22:57:38 +01002066 *
2067 * Cost: d A + d D + 1 R
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002068 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002069static int ecp_mul_comb_core(const mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2070 const mbedtls_ecp_point T[], unsigned char T_size,
2071 const unsigned char x[], size_t d,
2072 int (*f_rng)(void *, unsigned char *, size_t),
2073 void *p_rng,
2074 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002075{
Janos Follath24eed8d2019-11-22 13:21:35 +00002076 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002077 mbedtls_ecp_point Txi;
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002078 mbedtls_mpi tmp[4];
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002079 size_t i;
2080
Gilles Peskine449bd832023-01-11 14:50:10 +01002081 mbedtls_ecp_point_init(&Txi);
2082 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002083
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002084#if !defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002085 (void) rs_ctx;
2086#endif
2087
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002088#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002089 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2090 rs_ctx->rsm->state != ecp_rsm_comb_core) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002091 rs_ctx->rsm->i = 0;
2092 rs_ctx->rsm->state = ecp_rsm_comb_core;
2093 }
2094
2095 /* new 'if' instead of nested for the sake of the 'else' branch */
Gilles Peskine449bd832023-01-11 14:50:10 +01002096 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->i != 0) {
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002097 /* restore current index (R already pointing to rs_ctx->rsm->R) */
2098 i = rs_ctx->rsm->i;
Gilles Peskine449bd832023-01-11 14:50:10 +01002099 } else
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002100#endif
2101 {
2102 /* Start with a non-zero point and randomize its coordinates */
2103 i = d;
Gilles Peskine449bd832023-01-11 14:50:10 +01002104 MBEDTLS_MPI_CHK(ecp_select_comb(grp, R, T, T_size, x[i]));
2105 if (f_rng != 0) {
2106 MBEDTLS_MPI_CHK(ecp_randomize_jac(grp, R, f_rng, p_rng));
2107 }
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002108 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002109
Gilles Peskine449bd832023-01-11 14:50:10 +01002110 while (i != 0) {
2111 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_DBL + MBEDTLS_ECP_OPS_ADD);
Manuel Pégourié-Gonnard90f31b72018-10-16 10:45:24 +02002112 --i;
2113
Gilles Peskine449bd832023-01-11 14:50:10 +01002114 MBEDTLS_MPI_CHK(ecp_double_jac(grp, R, R, tmp));
2115 MBEDTLS_MPI_CHK(ecp_select_comb(grp, &Txi, T, T_size, x[i]));
2116 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, R, R, &Txi, tmp));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002117 }
2118
2119cleanup:
Janos Follathb0697532016-08-18 12:38:46 +01002120
Gilles Peskine449bd832023-01-11 14:50:10 +01002121 mbedtls_ecp_point_free(&Txi);
2122 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Beckera7f8edd2022-01-04 07:29:46 +00002123
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002124#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002125 if (rs_ctx != NULL && rs_ctx->rsm != NULL &&
2126 ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
Manuel Pégourié-Gonnard90f31b72018-10-16 10:45:24 +02002127 rs_ctx->rsm->i = i;
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002128 /* no need to save R, already pointing to rs_ctx->rsm->R */
Manuel Pégourié-Gonnardc5d844b2017-03-15 13:06:28 +01002129 }
2130#endif
2131
Gilles Peskine449bd832023-01-11 14:50:10 +01002132 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002133}
2134
2135/*
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002136 * Recode the scalar to get constant-time comb multiplication
2137 *
2138 * As the actual scalar recoding needs an odd scalar as a starting point,
2139 * this wrapper ensures that by replacing m by N - m if necessary, and
2140 * informs the caller that the result of multiplication will be negated.
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002141 *
Manuel Pégourié-Gonnardfd87e352017-08-24 14:21:05 +02002142 * This works because we only support large prime order for Short Weierstrass
2143 * curves, so N is always odd hence either m or N - m is.
2144 *
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002145 * See ecp_comb_recode_core() for background.
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002146 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002147static int ecp_comb_recode_scalar(const mbedtls_ecp_group *grp,
2148 const mbedtls_mpi *m,
2149 unsigned char k[COMB_MAX_D + 1],
2150 size_t d,
2151 unsigned char w,
2152 unsigned char *parity_trick)
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002153{
Janos Follath24eed8d2019-11-22 13:21:35 +00002154 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002155 mbedtls_mpi M, mm;
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002156
Gilles Peskine449bd832023-01-11 14:50:10 +01002157 mbedtls_mpi_init(&M);
2158 mbedtls_mpi_init(&mm);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002159
Manuel Pégourié-Gonnardfd87e352017-08-24 14:21:05 +02002160 /* N is always odd (see above), just make extra sure */
Gilles Peskine449bd832023-01-11 14:50:10 +01002161 if (mbedtls_mpi_get_bit(&grp->N, 0) != 1) {
2162 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2163 }
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002164
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002165 /* do we need the parity trick? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002166 *parity_trick = (mbedtls_mpi_get_bit(m, 0) == 0);
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002167
2168 /* execute parity fix in constant time */
Gilles Peskine449bd832023-01-11 14:50:10 +01002169 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&M, m));
2170 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&mm, &grp->N, m));
2171 MBEDTLS_MPI_CHK(mbedtls_mpi_safe_cond_assign(&M, &mm, *parity_trick));
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002172
2173 /* actual scalar recoding */
Gilles Peskine449bd832023-01-11 14:50:10 +01002174 ecp_comb_recode_core(k, d, w, &M);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002175
2176cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002177 mbedtls_mpi_free(&mm);
2178 mbedtls_mpi_free(&M);
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002179
Gilles Peskine449bd832023-01-11 14:50:10 +01002180 return ret;
Manuel Pégourié-Gonnardec5606a2017-03-09 12:46:45 +01002181}
2182
2183/*
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002184 * Perform comb multiplication (for short Weierstrass curves)
2185 * once the auxiliary table has been pre-computed.
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002186 *
2187 * Scalar recoding may use a parity trick that makes us compute -m * P,
2188 * if that is the case we'll need to recover m * P at the end.
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002189 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002190static int ecp_mul_comb_after_precomp(const mbedtls_ecp_group *grp,
2191 mbedtls_ecp_point *R,
2192 const mbedtls_mpi *m,
2193 const mbedtls_ecp_point *T,
2194 unsigned char T_size,
2195 unsigned char w,
2196 size_t d,
2197 int (*f_rng)(void *, unsigned char *, size_t),
2198 void *p_rng,
2199 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002200{
Janos Follath24eed8d2019-11-22 13:21:35 +00002201 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard62738e92017-03-14 10:00:21 +01002202 unsigned char parity_trick;
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002203 unsigned char k[COMB_MAX_D + 1];
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002204 mbedtls_ecp_point *RR = R;
2205
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002206#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002207 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002208 RR = &rs_ctx->rsm->R;
2209
Gilles Peskine449bd832023-01-11 14:50:10 +01002210 if (rs_ctx->rsm->state == ecp_rsm_final_norm) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002211 goto final_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002212 }
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002213 }
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002214#endif
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002215
Gilles Peskine449bd832023-01-11 14:50:10 +01002216 MBEDTLS_MPI_CHK(ecp_comb_recode_scalar(grp, m, k, d, w,
2217 &parity_trick));
2218 MBEDTLS_MPI_CHK(ecp_mul_comb_core(grp, RR, T, T_size, k, d,
2219 f_rng, p_rng, rs_ctx));
2220 MBEDTLS_MPI_CHK(ecp_safe_invert_jac(grp, RR, parity_trick));
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002221
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002222#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002223 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002224 rs_ctx->rsm->state = ecp_rsm_final_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002225 }
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002226
Manuel Pégourié-Gonnard4ed1dab2017-08-24 11:02:04 +02002227final_norm:
Gilles Peskine449bd832023-01-11 14:50:10 +01002228 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV);
Manuel Pégourié-Gonnard2fad7ae2017-03-14 13:13:13 +01002229#endif
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002230 /*
2231 * Knowledge of the jacobian coordinates may leak the last few bits of the
2232 * scalar [1], and since our MPI implementation isn't constant-flow,
2233 * inversion (used for coordinate normalization) may leak the full value
2234 * of its input via side-channels [2].
2235 *
2236 * [1] https://eprint.iacr.org/2003/191
2237 * [2] https://eprint.iacr.org/2020/055
2238 *
2239 * Avoid the leak by randomizing coordinates before we normalize them.
2240 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002241 if (f_rng != 0) {
2242 MBEDTLS_MPI_CHK(ecp_randomize_jac(grp, RR, f_rng, p_rng));
2243 }
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002244
Gilles Peskine449bd832023-01-11 14:50:10 +01002245 MBEDTLS_MPI_CHK(ecp_normalize_jac(grp, RR));
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002246
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002247#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002248 if (rs_ctx != NULL && rs_ctx->rsm != NULL) {
2249 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, RR));
2250 }
Manuel Pégourié-Gonnard8962ddb2017-03-14 12:11:21 +01002251#endif
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002252
2253cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002254 return ret;
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002255}
2256
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002257/*
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002258 * Pick window size based on curve size and whether we optimize for base point
2259 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002260static unsigned char ecp_pick_window_size(const mbedtls_ecp_group *grp,
2261 unsigned char p_eq_g)
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002262{
2263 unsigned char w;
2264
2265 /*
2266 * Minimize the number of multiplications, that is minimize
2267 * 10 * d * w + 18 * 2^(w-1) + 11 * d + 7 * w, with d = ceil( nbits / w )
2268 * (see costs of the various parts, with 1S = 1M)
2269 */
2270 w = grp->nbits >= 384 ? 5 : 4;
2271
2272 /*
2273 * If P == G, pre-compute a bit more, since this may be re-used later.
2274 * Just adding one avoids upping the cost of the first mul too much,
2275 * and the memory cost too.
2276 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002277 if (p_eq_g) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002278 w++;
Gilles Peskine449bd832023-01-11 14:50:10 +01002279 }
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002280
2281 /*
kXuanba9cb762021-04-08 14:32:06 +08002282 * If static comb table may not be used (!p_eq_g) or static comb table does
2283 * not exists, make sure w is within bounds.
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002284 * (The last test is useful only for very small curves in the test suite.)
kXuanba9cb762021-04-08 14:32:06 +08002285 *
2286 * The user reduces MBEDTLS_ECP_WINDOW_SIZE does not changes the size of
2287 * static comb table, because the size of static comb table is fixed when
2288 * it is generated.
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002289 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002290#if (MBEDTLS_ECP_WINDOW_SIZE < 6)
2291 if ((!p_eq_g || !ecp_group_is_static_comb_table(grp)) && w > MBEDTLS_ECP_WINDOW_SIZE) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002292 w = MBEDTLS_ECP_WINDOW_SIZE;
Gilles Peskine449bd832023-01-11 14:50:10 +01002293 }
k-stachowiak653a4a22019-07-03 14:31:09 +02002294#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002295 if (w >= grp->nbits) {
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002296 w = 2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002297 }
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002298
Gilles Peskine449bd832023-01-11 14:50:10 +01002299 return w;
Manuel Pégourié-Gonnard4b2336d2017-03-09 13:23:50 +01002300}
2301
2302/*
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002303 * Multiplication using the comb method - for curves in short Weierstrass form
2304 *
2305 * This function is mainly responsible for administrative work:
2306 * - managing the restart context if enabled
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002307 * - managing the table of precomputed points (passed between the below two
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002308 * functions): allocation, computation, ownership transfer, freeing.
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002309 *
2310 * It delegates the actual arithmetic work to:
2311 * ecp_precompute_comb() and ecp_mul_comb_with_precomp()
2312 *
2313 * See comments on ecp_comb_recode_core() regarding the computation strategy.
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002314 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002315static int ecp_mul_comb(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2316 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2317 int (*f_rng)(void *, unsigned char *, size_t),
2318 void *p_rng,
2319 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002320{
Janos Follath24eed8d2019-11-22 13:21:35 +00002321 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002322 unsigned char w, p_eq_g, i;
Manuel Pégourié-Gonnardd7283502013-11-21 20:00:38 +01002323 size_t d;
Manuel Pégourié-Gonnardf2a9fcf2020-06-03 12:11:56 +02002324 unsigned char T_size = 0, T_ok = 0;
2325 mbedtls_ecp_point *T = NULL;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002326
Gilles Peskine449bd832023-01-11 14:50:10 +01002327 ECP_RS_ENTER(rsm);
Manuel Pégourié-Gonnard510d5ca2017-03-08 11:41:47 +01002328
Manuel Pégourié-Gonnard22be6352017-03-09 13:02:35 +01002329 /* Is P the base point ? */
2330#if MBEDTLS_ECP_FIXED_POINT_OPTIM == 1
Gilles Peskine449bd832023-01-11 14:50:10 +01002331 p_eq_g = (MPI_ECP_CMP(&P->Y, &grp->G.Y) == 0 &&
2332 MPI_ECP_CMP(&P->X, &grp->G.X) == 0);
Manuel Pégourié-Gonnard196d1332017-08-28 13:14:27 +02002333#else
2334 p_eq_g = 0;
Manuel Pégourié-Gonnard22be6352017-03-09 13:02:35 +01002335#endif
2336
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002337 /* Pick window size and deduce related sizes */
Gilles Peskine449bd832023-01-11 14:50:10 +01002338 w = ecp_pick_window_size(grp, p_eq_g);
2339 T_size = 1U << (w - 1);
2340 d = (grp->nbits + w - 1) / w;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002341
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002342 /* Pre-computed table: do we have it already for the base point? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002343 if (p_eq_g && grp->T != NULL) {
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002344 /* second pointer to the same table, will be deleted on exit */
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002345 T = grp->T;
2346 T_ok = 1;
Gilles Peskine449bd832023-01-11 14:50:10 +01002347 } else
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002348#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002349 /* Pre-computed table: do we have one in progress? complete? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002350 if (rs_ctx != NULL && rs_ctx->rsm != NULL && rs_ctx->rsm->T != NULL) {
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +01002351 /* transfer ownership of T from rsm to local function */
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002352 T = rs_ctx->rsm->T;
2353 rs_ctx->rsm->T = NULL;
2354 rs_ctx->rsm->T_size = 0;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002355
Manuel Pégourié-Gonnardb25cb602018-10-16 11:48:09 +02002356 /* This effectively jumps to the call to mul_comb_after_precomp() */
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002357 T_ok = rs_ctx->rsm->state >= ecp_rsm_comb_core;
Gilles Peskine449bd832023-01-11 14:50:10 +01002358 } else
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +01002359#endif
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002360 /* Allocate table if we didn't have any */
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002361 {
Gilles Peskine449bd832023-01-11 14:50:10 +01002362 T = mbedtls_calloc(T_size, sizeof(mbedtls_ecp_point));
2363 if (T == NULL) {
Manuel Pégourié-Gonnard6a8ca332015-05-28 09:33:39 +02002364 ret = MBEDTLS_ERR_ECP_ALLOC_FAILED;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002365 goto cleanup;
2366 }
Manuel Pégourié-Gonnard5bd38b12017-08-23 16:55:59 +02002367
Gilles Peskine449bd832023-01-11 14:50:10 +01002368 for (i = 0; i < T_size; i++) {
2369 mbedtls_ecp_point_init(&T[i]);
2370 }
Manuel Pégourié-Gonnard11556e22017-08-24 13:41:19 +02002371
2372 T_ok = 0;
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002373 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002374
Manuel Pégourié-Gonnard085b1df2017-03-16 16:56:04 +01002375 /* Compute table (or finish computing it) if not done already */
Gilles Peskine449bd832023-01-11 14:50:10 +01002376 if (!T_ok) {
2377 MBEDTLS_MPI_CHK(ecp_precompute_comb(grp, T, P, w, d, rs_ctx));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002378
Gilles Peskine449bd832023-01-11 14:50:10 +01002379 if (p_eq_g) {
Manuel Pégourié-Gonnard7037e222017-08-23 14:30:36 +02002380 /* almost transfer ownership of T to the group, but keep a copy of
Manuel Pégourié-Gonnardee68cff2018-10-15 15:27:49 +02002381 * the pointer to use for calling the next function more easily */
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002382 grp->T = T;
Manuel Pégourié-Gonnard92cceb22017-08-23 16:27:29 +02002383 grp->T_size = T_size;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002384 }
2385 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002386
Manuel Pégourié-Gonnard391f4412017-03-13 12:26:21 +01002387 /* Actual comb multiplication using precomputed points */
Gilles Peskine449bd832023-01-11 14:50:10 +01002388 MBEDTLS_MPI_CHK(ecp_mul_comb_after_precomp(grp, R, m,
2389 T, T_size, w, d,
2390 f_rng, p_rng, rs_ctx));
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002391
2392cleanup:
2393
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002394 /* does T belong to the group? */
Gilles Peskine449bd832023-01-11 14:50:10 +01002395 if (T == grp->T) {
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002396 T = NULL;
Gilles Peskine449bd832023-01-11 14:50:10 +01002397 }
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002398
2399 /* does T belong to the restart context? */
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002400#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002401 if (rs_ctx != NULL && rs_ctx->rsm != NULL && ret == MBEDTLS_ERR_ECP_IN_PROGRESS && T != NULL) {
Manuel Pégourié-Gonnard45fd0162017-03-22 08:24:42 +01002402 /* transfer ownership of T from local function to rsm */
Manuel Pégourié-Gonnard92cceb22017-08-23 16:27:29 +02002403 rs_ctx->rsm->T_size = T_size;
Manuel Pégourié-Gonnard3cade222017-04-20 09:31:00 +02002404 rs_ctx->rsm->T = T;
Manuel Pégourié-Gonnardc9c0aa62017-03-16 14:53:26 +01002405 T = NULL;
2406 }
2407#endif
2408
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002409 /* did T belong to us? then let's destroy it! */
Gilles Peskine449bd832023-01-11 14:50:10 +01002410 if (T != NULL) {
2411 for (i = 0; i < T_size; i++) {
2412 mbedtls_ecp_point_free(&T[i]);
2413 }
2414 mbedtls_free(T);
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002415 }
2416
Manuel Pégourié-Gonnard07bf6f52017-03-16 17:21:38 +01002417 /* prevent caller from using invalid value */
Gilles Peskine449bd832023-01-11 14:50:10 +01002418 int should_free_R = (ret != 0);
David Horstmannfc735df2022-10-06 19:11:04 +01002419#if defined(MBEDTLS_ECP_RESTARTABLE)
2420 /* don't free R while in progress in case R == P */
Gilles Peskine449bd832023-01-11 14:50:10 +01002421 if (ret == MBEDTLS_ERR_ECP_IN_PROGRESS) {
David Horstmann6e116872022-10-25 10:32:08 +01002422 should_free_R = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01002423 }
David Horstmannfc735df2022-10-06 19:11:04 +01002424#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002425 if (should_free_R) {
2426 mbedtls_ecp_point_free(R);
2427 }
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002428
Gilles Peskine449bd832023-01-11 14:50:10 +01002429 ECP_RS_LEAVE(rsm);
Manuel Pégourié-Gonnard77af79a2017-03-14 10:58:00 +01002430
Gilles Peskine449bd832023-01-11 14:50:10 +01002431 return ret;
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002432}
2433
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002434#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002435
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002436#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002437/*
2438 * For Montgomery curves, we do all the internal arithmetic in projective
2439 * coordinates. Import/export of points uses only the x coordinates, which is
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002440 * internally represented as X / Z.
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002441 *
2442 * For scalar multiplication, we'll use a Montgomery ladder.
2443 */
2444
Manuel Pégourié-Gonnardd1c1ba92013-11-16 15:50:12 +01002445/*
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002446 * Normalize Montgomery x/z coordinates: X = X/Z, Z = 1
2447 * Cost: 1M + 1I
2448 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002449static int ecp_normalize_mxz(const mbedtls_ecp_group *grp, mbedtls_ecp_point *P)
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002450{
Janos Follathb0697532016-08-18 12:38:46 +01002451#if defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002452 if (mbedtls_internal_ecp_grp_capable(grp)) {
2453 return mbedtls_internal_ecp_normalize_mxz(grp, P);
2454 }
Janos Follath372697b2016-10-28 16:53:11 +01002455#endif /* MBEDTLS_ECP_NORMALIZE_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002456
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002457#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002458 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002459#else
2460 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01002461 MPI_ECP_INV(&P->Z, &P->Z);
2462 MPI_ECP_MUL(&P->X, &P->X, &P->Z);
2463 MPI_ECP_LSET(&P->Z, 1);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002464
2465cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002466 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002467#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_NORMALIZE_MXZ_ALT) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002468}
2469
2470/*
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002471 * Randomize projective x/z coordinates:
2472 * (X, Z) -> (l X, l Z) for random l
2473 * This is sort of the reverse operation of ecp_normalize_mxz().
2474 *
2475 * This countermeasure was first suggested in [2].
2476 * Cost: 2M
2477 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002478static int ecp_randomize_mxz(const mbedtls_ecp_group *grp, mbedtls_ecp_point *P,
2479 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002480{
Janos Follathb0697532016-08-18 12:38:46 +01002481#if defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002482 if (mbedtls_internal_ecp_grp_capable(grp)) {
2483 return mbedtls_internal_ecp_randomize_mxz(grp, P, f_rng, p_rng);
2484 }
Janos Follath372697b2016-10-28 16:53:11 +01002485#endif /* MBEDTLS_ECP_RANDOMIZE_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002486
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002487#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002488 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002489#else
2490 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
2491 mbedtls_mpi l;
Gilles Peskine449bd832023-01-11 14:50:10 +01002492 mbedtls_mpi_init(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002493
2494 /* Generate l such that 1 < l < p */
Gilles Peskine449bd832023-01-11 14:50:10 +01002495 MPI_ECP_RAND(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002496
Gilles Peskine449bd832023-01-11 14:50:10 +01002497 MPI_ECP_MUL(&P->X, &P->X, &l);
2498 MPI_ECP_MUL(&P->Z, &P->Z, &l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002499
2500cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002501 mbedtls_mpi_free(&l);
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002502
Gilles Peskine449bd832023-01-11 14:50:10 +01002503 if (ret == MBEDTLS_ERR_MPI_NOT_ACCEPTABLE) {
Gilles Peskine59215172021-03-29 22:28:50 +02002504 ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine449bd832023-01-11 14:50:10 +01002505 }
2506 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002507#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_RANDOMIZE_MXZ_ALT) */
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002508}
2509
2510/*
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002511 * Double-and-add: R = 2P, S = P + Q, with d = X(P - Q),
2512 * for Montgomery curves in x/z coordinates.
2513 *
2514 * http://www.hyperelliptic.org/EFD/g1p/auto-code/montgom/xz/ladder/mladd-1987-m.op3
2515 * with
2516 * d = X1
2517 * P = (X2, Z2)
2518 * Q = (X3, Z3)
2519 * R = (X4, Z4)
2520 * S = (X5, Z5)
2521 * and eliminating temporary variables tO, ..., t4.
2522 *
2523 * Cost: 5M + 4S
2524 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002525static int ecp_double_add_mxz(const mbedtls_ecp_group *grp,
2526 mbedtls_ecp_point *R, mbedtls_ecp_point *S,
2527 const mbedtls_ecp_point *P, const mbedtls_ecp_point *Q,
2528 const mbedtls_mpi *d,
2529 mbedtls_mpi T[4])
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002530{
Janos Follathb0697532016-08-18 12:38:46 +01002531#if defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002532 if (mbedtls_internal_ecp_grp_capable(grp)) {
2533 return mbedtls_internal_ecp_double_add_mxz(grp, R, S, P, Q, d);
2534 }
Janos Follath372697b2016-10-28 16:53:11 +01002535#endif /* MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT */
Janos Follathb0697532016-08-18 12:38:46 +01002536
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002537#if defined(MBEDTLS_ECP_NO_FALLBACK) && defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002538 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002539#else
2540 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002541
Gilles Peskine449bd832023-01-11 14:50:10 +01002542 MPI_ECP_ADD(&T[0], &P->X, &P->Z); /* Pp := PX + PZ */
2543 MPI_ECP_SUB(&T[1], &P->X, &P->Z); /* Pm := PX - PZ */
2544 MPI_ECP_ADD(&T[2], &Q->X, &Q->Z); /* Qp := QX + XZ */
2545 MPI_ECP_SUB(&T[3], &Q->X, &Q->Z); /* Qm := QX - QZ */
2546 MPI_ECP_MUL(&T[3], &T[3], &T[0]); /* Qm * Pp */
2547 MPI_ECP_MUL(&T[2], &T[2], &T[1]); /* Qp * Pm */
2548 MPI_ECP_SQR(&T[0], &T[0]); /* Pp^2 */
2549 MPI_ECP_SQR(&T[1], &T[1]); /* Pm^2 */
2550 MPI_ECP_MUL(&R->X, &T[0], &T[1]); /* Pp^2 * Pm^2 */
2551 MPI_ECP_SUB(&T[0], &T[0], &T[1]); /* Pp^2 - Pm^2 */
2552 MPI_ECP_MUL(&R->Z, &grp->A, &T[0]); /* A * (Pp^2 - Pm^2) */
2553 MPI_ECP_ADD(&R->Z, &T[1], &R->Z); /* [ A * (Pp^2-Pm^2) ] + Pm^2 */
2554 MPI_ECP_ADD(&S->X, &T[3], &T[2]); /* Qm*Pp + Qp*Pm */
2555 MPI_ECP_SQR(&S->X, &S->X); /* (Qm*Pp + Qp*Pm)^2 */
2556 MPI_ECP_SUB(&S->Z, &T[3], &T[2]); /* Qm*Pp - Qp*Pm */
2557 MPI_ECP_SQR(&S->Z, &S->Z); /* (Qm*Pp - Qp*Pm)^2 */
2558 MPI_ECP_MUL(&S->Z, d, &S->Z); /* d * ( Qm*Pp - Qp*Pm )^2 */
2559 MPI_ECP_MUL(&R->Z, &T[0], &R->Z); /* [A*(Pp^2-Pm^2)+Pm^2]*(Pp^2-Pm^2) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002560
2561cleanup:
Hanno Becker28ccb1c2022-01-04 07:15:04 +00002562
Gilles Peskine449bd832023-01-11 14:50:10 +01002563 return ret;
Steven Cooreman7eb2aa02021-01-22 09:43:59 +01002564#endif /* !defined(MBEDTLS_ECP_NO_FALLBACK) || !defined(MBEDTLS_ECP_DOUBLE_ADD_MXZ_ALT) */
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002565}
2566
2567/*
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002568 * Multiplication with Montgomery ladder in x/z coordinates,
2569 * for curves in Montgomery form
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002570 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002571static int ecp_mul_mxz(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2572 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2573 int (*f_rng)(void *, unsigned char *, size_t),
2574 void *p_rng)
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002575{
Janos Follath24eed8d2019-11-22 13:21:35 +00002576 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002577 size_t i;
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002578 unsigned char b;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002579 mbedtls_ecp_point RP;
2580 mbedtls_mpi PX;
Hanno Becker30838862022-01-04 13:25:59 +00002581 mbedtls_mpi tmp[4];
Gilles Peskine449bd832023-01-11 14:50:10 +01002582 mbedtls_ecp_point_init(&RP); mbedtls_mpi_init(&PX);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002583
Gilles Peskine449bd832023-01-11 14:50:10 +01002584 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker30838862022-01-04 13:25:59 +00002585
Gilles Peskine449bd832023-01-11 14:50:10 +01002586 if (f_rng == NULL) {
2587 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2588 }
Manuel Pégourié-Gonnard02b57052021-06-15 11:29:26 +02002589
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002590 /* Save PX and read from P before writing to R, in case P == R */
Gilles Peskine449bd832023-01-11 14:50:10 +01002591 MPI_ECP_MOV(&PX, &P->X);
2592 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(&RP, P));
Manuel Pégourié-Gonnard357ff652013-12-04 18:39:17 +01002593
2594 /* Set R to zero in modified x/z coordinates */
Gilles Peskine449bd832023-01-11 14:50:10 +01002595 MPI_ECP_LSET(&R->X, 1);
2596 MPI_ECP_LSET(&R->Z, 0);
2597 mbedtls_mpi_free(&R->Y);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002598
Shaun Case8b0ecbc2021-12-20 21:14:10 -08002599 /* RP.X might be slightly larger than P, so reduce it */
Gilles Peskine449bd832023-01-11 14:50:10 +01002600 MOD_ADD(&RP.X);
Manuel Pégourié-Gonnard93f41db2013-12-05 10:48:42 +01002601
Manuel Pégourié-Gonnard3afa07f2013-12-03 13:28:21 +01002602 /* Randomize coordinates of the starting point */
Gilles Peskine449bd832023-01-11 14:50:10 +01002603 MBEDTLS_MPI_CHK(ecp_randomize_mxz(grp, &RP, f_rng, p_rng));
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002604
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002605 /* Loop invariant: R = result so far, RP = R + P */
Aurelien Jarnoc79ce882022-05-15 13:24:05 +02002606 i = grp->nbits + 1; /* one past the (zero-based) required msb for private keys */
Gilles Peskine449bd832023-01-11 14:50:10 +01002607 while (i-- > 0) {
2608 b = mbedtls_mpi_get_bit(m, i);
Manuel Pégourié-Gonnardb6f45a62013-12-04 21:54:36 +01002609 /*
2610 * if (b) R = 2R + P else R = 2R,
2611 * which is:
2612 * if (b) double_add( RP, R, RP, R )
2613 * else double_add( R, RP, R, RP )
2614 * but using safe conditional swaps to avoid leaks
2615 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002616 MPI_ECP_COND_SWAP(&R->X, &RP.X, b);
2617 MPI_ECP_COND_SWAP(&R->Z, &RP.Z, b);
2618 MBEDTLS_MPI_CHK(ecp_double_add_mxz(grp, R, &RP, R, &RP, &PX, tmp));
2619 MPI_ECP_COND_SWAP(&R->X, &RP.X, b);
2620 MPI_ECP_COND_SWAP(&R->Z, &RP.Z, b);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002621 }
2622
Manuel Pégourié-Gonnarda4aa89b2020-03-25 12:41:29 +01002623 /*
2624 * Knowledge of the projective coordinates may leak the last few bits of the
2625 * scalar [1], and since our MPI implementation isn't constant-flow,
2626 * inversion (used for coordinate normalization) may leak the full value
2627 * of its input via side-channels [2].
2628 *
2629 * [1] https://eprint.iacr.org/2003/191
2630 * [2] https://eprint.iacr.org/2020/055
2631 *
2632 * Avoid the leak by randomizing coordinates before we normalize them.
2633 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002634 MBEDTLS_MPI_CHK(ecp_randomize_mxz(grp, R, f_rng, p_rng));
2635 MBEDTLS_MPI_CHK(ecp_normalize_mxz(grp, R));
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002636
2637cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002638 mbedtls_ecp_point_free(&RP); mbedtls_mpi_free(&PX);
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002639
Gilles Peskine449bd832023-01-11 14:50:10 +01002640 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
2641 return ret;
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002642}
2643
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002644#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnard7c94d8b2013-12-04 23:15:46 +01002645
Manuel Pégourié-Gonnardd9ea82e72013-12-03 12:02:28 +01002646/*
Manuel Pégourié-Gonnard884569c2017-04-20 10:10:59 +02002647 * Restartable multiplication R = m * P
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002648 *
2649 * This internal function can be called without an RNG in case where we know
2650 * the inputs are not sensitive.
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002651 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002652static int ecp_mul_restartable_internal(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2653 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2654 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng,
2655 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002656{
Janos Follathb0697532016-08-18 12:38:46 +01002657 int ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Janos Follathc44ab972016-11-18 16:38:23 +00002658#if defined(MBEDTLS_ECP_INTERNAL_ALT)
2659 char is_grp_capable = 0;
2660#endif
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02002661
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002662#if defined(MBEDTLS_ECP_RESTARTABLE)
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002663 /* reset ops count for this call if top-level */
Gilles Peskine449bd832023-01-11 14:50:10 +01002664 if (rs_ctx != NULL && rs_ctx->depth++ == 0) {
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002665 rs_ctx->ops_done = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01002666 }
Gilles Peskine59970052019-02-28 13:12:06 +01002667#else
2668 (void) rs_ctx;
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002669#endif
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002670
Janos Follathc44ab972016-11-18 16:38:23 +00002671#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002672 if ((is_grp_capable = mbedtls_internal_ecp_grp_capable(grp))) {
2673 MBEDTLS_MPI_CHK(mbedtls_internal_ecp_init(grp));
2674 }
Janos Follathc44ab972016-11-18 16:38:23 +00002675#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002676
David Horstmannfc735df2022-10-06 19:11:04 +01002677 int restarting = 0;
Manuel Pégourié-Gonnard95aedfe2017-08-24 13:47:04 +02002678#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002679 restarting = (rs_ctx != NULL && rs_ctx->rsm != NULL);
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002680#endif
David Horstmannfc735df2022-10-06 19:11:04 +01002681 /* skip argument check when restarting */
Gilles Peskine449bd832023-01-11 14:50:10 +01002682 if (!restarting) {
Manuel Pégourié-Gonnard5314f232017-04-21 12:36:59 +02002683 /* check_privkey is free */
Gilles Peskine449bd832023-01-11 14:50:10 +01002684 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_CHK);
Manuel Pégourié-Gonnard5314f232017-04-21 12:36:59 +02002685
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002686 /* Common sanity checks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002687 MBEDTLS_MPI_CHK(mbedtls_ecp_check_privkey(grp, m));
2688 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
Manuel Pégourié-Gonnarda08cd1a2017-04-20 11:29:43 +02002689 }
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002690
2691 ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002692#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002693 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
2694 MBEDTLS_MPI_CHK(ecp_mul_mxz(grp, R, m, P, f_rng, p_rng));
2695 }
Janos Follath430d3372016-11-03 14:25:37 +00002696#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002697#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002698 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
2699 MBEDTLS_MPI_CHK(ecp_mul_comb(grp, R, m, P, f_rng, p_rng, rs_ctx));
2700 }
Janos Follath430d3372016-11-03 14:25:37 +00002701#endif
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002702
Janos Follath6c8ccd52016-11-29 15:37:09 +00002703cleanup:
Janos Follathb0697532016-08-18 12:38:46 +01002704
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002705#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002706 if (is_grp_capable) {
2707 mbedtls_internal_ecp_free(grp);
2708 }
Janos Follathc44ab972016-11-18 16:38:23 +00002709#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002710
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002711#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002712 if (rs_ctx != NULL) {
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002713 rs_ctx->depth--;
Gilles Peskine449bd832023-01-11 14:50:10 +01002714 }
Manuel Pégourié-Gonnard3a256122017-04-20 11:20:26 +02002715#endif
2716
Gilles Peskine449bd832023-01-11 14:50:10 +01002717 return ret;
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002718}
2719
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002720/*
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002721 * Restartable multiplication R = m * P
2722 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002723int mbedtls_ecp_mul_restartable(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2724 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2725 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng,
2726 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002727{
Gilles Peskine449bd832023-01-11 14:50:10 +01002728 if (f_rng == NULL) {
2729 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
2730 }
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002731
Gilles Peskine449bd832023-01-11 14:50:10 +01002732 return ecp_mul_restartable_internal(grp, R, m, P, f_rng, p_rng, rs_ctx);
Manuel Pégourié-Gonnard75525ae2021-06-15 11:29:26 +02002733}
2734
2735/*
Manuel Pégourié-Gonnard884569c2017-04-20 10:10:59 +02002736 * Multiplication R = m * P
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002737 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002738int mbedtls_ecp_mul(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2739 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2740 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002741{
Gilles Peskine449bd832023-01-11 14:50:10 +01002742 return mbedtls_ecp_mul_restartable(grp, R, m, P, f_rng, p_rng, NULL);
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002743}
Manuel Pégourié-Gonnardb739a712017-04-19 10:11:56 +02002744
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002745#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnarda0179b82013-12-04 11:49:20 +01002746/*
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002747 * Check that an affine point is valid as a public key,
2748 * short weierstrass curves (SEC1 3.2.3.1)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002749 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002750static int ecp_check_pubkey_sw(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002751{
Janos Follath24eed8d2019-11-22 13:21:35 +00002752 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002753 mbedtls_mpi YY, RHS;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002754
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01002755 /* pt coordinates must be normalized for our checks */
Gilles Peskine449bd832023-01-11 14:50:10 +01002756 if (mbedtls_mpi_cmp_int(&pt->X, 0) < 0 ||
2757 mbedtls_mpi_cmp_int(&pt->Y, 0) < 0 ||
2758 mbedtls_mpi_cmp_mpi(&pt->X, &grp->P) >= 0 ||
2759 mbedtls_mpi_cmp_mpi(&pt->Y, &grp->P) >= 0) {
2760 return MBEDTLS_ERR_ECP_INVALID_KEY;
2761 }
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002762
Gilles Peskine449bd832023-01-11 14:50:10 +01002763 mbedtls_mpi_init(&YY); mbedtls_mpi_init(&RHS);
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002764
2765 /*
2766 * YY = Y^2
Manuel Pégourié-Gonnard8b6d14b2022-12-20 10:02:52 +01002767 * RHS = X^3 + A X + B
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002768 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002769 MPI_ECP_SQR(&YY, &pt->Y);
2770 MBEDTLS_MPI_CHK(ecp_sw_rhs(grp, &RHS, &pt->X));
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002771
Gilles Peskine449bd832023-01-11 14:50:10 +01002772 if (MPI_ECP_CMP(&YY, &RHS) != 0) {
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02002773 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
Gilles Peskine449bd832023-01-11 14:50:10 +01002774 }
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002775
2776cleanup:
2777
Gilles Peskine449bd832023-01-11 14:50:10 +01002778 mbedtls_mpi_free(&YY); mbedtls_mpi_free(&RHS);
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002779
Gilles Peskine449bd832023-01-11 14:50:10 +01002780 return ret;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02002781}
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002782#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002783
Gilles Peskine9b99a892018-09-14 18:32:19 +02002784#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002785/*
TRodziewicz9edff742021-03-04 17:59:39 +01002786 * R = m * P with shortcuts for m == 0, m == 1 and m == -1
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002787 * NOT constant-time - ONLY for short Weierstrass!
2788 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002789static int mbedtls_ecp_mul_shortcuts(mbedtls_ecp_group *grp,
2790 mbedtls_ecp_point *R,
2791 const mbedtls_mpi *m,
2792 const mbedtls_ecp_point *P,
2793 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002794{
Janos Follath24eed8d2019-11-22 13:21:35 +00002795 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Hanno Beckerc27a0e02022-01-06 05:56:34 +00002796 mbedtls_mpi tmp;
Gilles Peskine449bd832023-01-11 14:50:10 +01002797 mbedtls_mpi_init(&tmp);
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002798
Gilles Peskine449bd832023-01-11 14:50:10 +01002799 if (mbedtls_mpi_cmp_int(m, 0) == 0) {
2800 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2801 MBEDTLS_MPI_CHK(mbedtls_ecp_set_zero(R));
2802 } else if (mbedtls_mpi_cmp_int(m, 1) == 0) {
2803 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2804 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, P));
2805 } else if (mbedtls_mpi_cmp_int(m, -1) == 0) {
2806 MBEDTLS_MPI_CHK(mbedtls_ecp_check_pubkey(grp, P));
2807 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, P));
2808 MPI_ECP_NEG(&R->Y);
2809 } else {
2810 MBEDTLS_MPI_CHK(ecp_mul_restartable_internal(grp, R, m, P,
2811 NULL, NULL, rs_ctx));
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002812 }
2813
2814cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01002815 mbedtls_mpi_free(&tmp);
Hanno Beckerc27a0e02022-01-06 05:56:34 +00002816
Gilles Peskine449bd832023-01-11 14:50:10 +01002817 return ret;
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002818}
2819
2820/*
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002821 * Restartable linear combination
Manuel Pégourié-Gonnardde9f9532015-10-23 15:50:37 +02002822 * NOT constant-time
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002823 */
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002824int mbedtls_ecp_muladd_restartable(
Gilles Peskine449bd832023-01-11 14:50:10 +01002825 mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2826 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2827 const mbedtls_mpi *n, const mbedtls_ecp_point *Q,
2828 mbedtls_ecp_restart_ctx *rs_ctx)
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002829{
Janos Follath24eed8d2019-11-22 13:21:35 +00002830 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002831 mbedtls_ecp_point mP;
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002832 mbedtls_ecp_point *pmP = &mP;
2833 mbedtls_ecp_point *pR = R;
Hanno Becker3b29f212022-01-04 07:34:14 +00002834 mbedtls_mpi tmp[4];
Janos Follathc44ab972016-11-18 16:38:23 +00002835#if defined(MBEDTLS_ECP_INTERNAL_ALT)
2836 char is_grp_capable = 0;
2837#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002838 if (mbedtls_ecp_get_type(grp) != MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
2839 return MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
2840 }
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002841
Gilles Peskine449bd832023-01-11 14:50:10 +01002842 mbedtls_ecp_point_init(&mP);
2843 mpi_init_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker3b29f212022-01-04 07:34:14 +00002844
Gilles Peskine449bd832023-01-11 14:50:10 +01002845 ECP_RS_ENTER(ma);
Manuel Pégourié-Gonnarddb4a8eb2017-08-23 18:18:22 +02002846
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002847#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002848 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002849 /* redirect intermediate results to restart context */
2850 pmP = &rs_ctx->ma->mP;
2851 pR = &rs_ctx->ma->R;
2852
2853 /* jump to next operation */
Gilles Peskine449bd832023-01-11 14:50:10 +01002854 if (rs_ctx->ma->state == ecp_rsma_mul2) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002855 goto mul2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002856 }
2857 if (rs_ctx->ma->state == ecp_rsma_add) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002858 goto add;
Gilles Peskine449bd832023-01-11 14:50:10 +01002859 }
2860 if (rs_ctx->ma->state == ecp_rsma_norm) {
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002861 goto norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002862 }
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002863 }
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002864#endif /* MBEDTLS_ECP_RESTARTABLE */
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002865
Gilles Peskine449bd832023-01-11 14:50:10 +01002866 MBEDTLS_MPI_CHK(mbedtls_ecp_mul_shortcuts(grp, pmP, m, P, rs_ctx));
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002867#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002868 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002869 rs_ctx->ma->state = ecp_rsma_mul2;
Gilles Peskine449bd832023-01-11 14:50:10 +01002870 }
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002871
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002872mul2:
2873#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002874 MBEDTLS_MPI_CHK(mbedtls_ecp_mul_shortcuts(grp, pR, n, Q, rs_ctx));
Andrzej Kurekc470b6b2019-01-31 08:20:20 -05002875
2876#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002877 if ((is_grp_capable = mbedtls_internal_ecp_grp_capable(grp))) {
2878 MBEDTLS_MPI_CHK(mbedtls_internal_ecp_init(grp));
2879 }
Andrzej Kurekc470b6b2019-01-31 08:20:20 -05002880#endif /* MBEDTLS_ECP_INTERNAL_ALT */
2881
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002882#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002883 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002884 rs_ctx->ma->state = ecp_rsma_add;
Gilles Peskine449bd832023-01-11 14:50:10 +01002885 }
Manuel Pégourié-Gonnard1a7c5ef2015-08-13 10:19:09 +02002886
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002887add:
2888#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002889 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_ADD);
2890 MBEDTLS_MPI_CHK(ecp_add_mixed(grp, pR, pmP, pR, tmp));
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002891#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002892 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
Manuel Pégourié-Gonnardc9efa002017-08-24 10:25:06 +02002893 rs_ctx->ma->state = ecp_rsma_norm;
Gilles Peskine449bd832023-01-11 14:50:10 +01002894 }
Janos Follath430d3372016-11-03 14:25:37 +00002895
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002896norm:
2897#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01002898 MBEDTLS_ECP_BUDGET(MBEDTLS_ECP_OPS_INV);
2899 MBEDTLS_MPI_CHK(ecp_normalize_jac(grp, pR));
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002900
Manuel Pégourié-Gonnard4b9c51e2017-04-20 15:50:26 +02002901#if defined(MBEDTLS_ECP_RESTARTABLE)
Gilles Peskine449bd832023-01-11 14:50:10 +01002902 if (rs_ctx != NULL && rs_ctx->ma != NULL) {
2903 MBEDTLS_MPI_CHK(mbedtls_ecp_copy(R, pR));
2904 }
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002905#endif
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002906
2907cleanup:
Hanno Becker3b29f212022-01-04 07:34:14 +00002908
Gilles Peskine449bd832023-01-11 14:50:10 +01002909 mpi_free_many(tmp, sizeof(tmp) / sizeof(mbedtls_mpi));
Hanno Becker3b29f212022-01-04 07:34:14 +00002910
Janos Follathc44ab972016-11-18 16:38:23 +00002911#if defined(MBEDTLS_ECP_INTERNAL_ALT)
Gilles Peskine449bd832023-01-11 14:50:10 +01002912 if (is_grp_capable) {
2913 mbedtls_internal_ecp_free(grp);
2914 }
Janos Follathc44ab972016-11-18 16:38:23 +00002915#endif /* MBEDTLS_ECP_INTERNAL_ALT */
Manuel Pégourié-Gonnard1631d632017-04-20 14:48:56 +02002916
Gilles Peskine449bd832023-01-11 14:50:10 +01002917 mbedtls_ecp_point_free(&mP);
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002918
Gilles Peskine449bd832023-01-11 14:50:10 +01002919 ECP_RS_LEAVE(ma);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002920
Gilles Peskine449bd832023-01-11 14:50:10 +01002921 return ret;
Manuel Pégourié-Gonnard56cc88a2015-05-11 18:40:45 +02002922}
2923
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002924/*
2925 * Linear combination
2926 * NOT constant-time
2927 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002928int mbedtls_ecp_muladd(mbedtls_ecp_group *grp, mbedtls_ecp_point *R,
2929 const mbedtls_mpi *m, const mbedtls_ecp_point *P,
2930 const mbedtls_mpi *n, const mbedtls_ecp_point *Q)
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002931{
Gilles Peskine449bd832023-01-11 14:50:10 +01002932 return mbedtls_ecp_muladd_restartable(grp, R, m, P, n, Q, NULL);
Manuel Pégourié-Gonnard54dd6522017-04-20 13:36:18 +02002933}
Gilles Peskine9b99a892018-09-14 18:32:19 +02002934#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01002935
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02002936#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002937#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002938#define ECP_MPI_INIT(s, n, p) { s, (n), (mbedtls_mpi_uint *) (p) }
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002939#define ECP_MPI_INIT_ARRAY(x) \
2940 ECP_MPI_INIT(1, sizeof(x) / sizeof(mbedtls_mpi_uint), x)
2941/*
2942 * Constants for the two points other than 0, 1, -1 (mod p) in
2943 * https://cr.yp.to/ecdh.html#validate
2944 * See ecp_check_pubkey_x25519().
2945 */
2946static const mbedtls_mpi_uint x25519_bad_point_1[] = {
Gilles Peskine449bd832023-01-11 14:50:10 +01002947 MBEDTLS_BYTES_TO_T_UINT_8(0xe0, 0xeb, 0x7a, 0x7c, 0x3b, 0x41, 0xb8, 0xae),
2948 MBEDTLS_BYTES_TO_T_UINT_8(0x16, 0x56, 0xe3, 0xfa, 0xf1, 0x9f, 0xc4, 0x6a),
2949 MBEDTLS_BYTES_TO_T_UINT_8(0xda, 0x09, 0x8d, 0xeb, 0x9c, 0x32, 0xb1, 0xfd),
2950 MBEDTLS_BYTES_TO_T_UINT_8(0x86, 0x62, 0x05, 0x16, 0x5f, 0x49, 0xb8, 0x00),
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002951};
2952static const mbedtls_mpi_uint x25519_bad_point_2[] = {
Gilles Peskine449bd832023-01-11 14:50:10 +01002953 MBEDTLS_BYTES_TO_T_UINT_8(0x5f, 0x9c, 0x95, 0xbc, 0xa3, 0x50, 0x8c, 0x24),
2954 MBEDTLS_BYTES_TO_T_UINT_8(0xb1, 0xd0, 0xb1, 0x55, 0x9c, 0x83, 0xef, 0x5b),
2955 MBEDTLS_BYTES_TO_T_UINT_8(0x04, 0x44, 0x5c, 0xc4, 0x58, 0x1c, 0x8e, 0x86),
2956 MBEDTLS_BYTES_TO_T_UINT_8(0xd8, 0x22, 0x4e, 0xdd, 0xd0, 0x9f, 0x11, 0x57),
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002957};
2958static const mbedtls_mpi ecp_x25519_bad_point_1 = ECP_MPI_INIT_ARRAY(
Gilles Peskine449bd832023-01-11 14:50:10 +01002959 x25519_bad_point_1);
Manuel Pégourié-Gonnard06215ea2021-06-23 12:53:18 +02002960static const mbedtls_mpi ecp_x25519_bad_point_2 = ECP_MPI_INIT_ARRAY(
Gilles Peskine449bd832023-01-11 14:50:10 +01002961 x25519_bad_point_2);
Janos Follath865a75e2021-06-24 15:34:59 +01002962#endif /* MBEDTLS_ECP_DP_CURVE25519_ENABLED */
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02002963
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002964/*
2965 * Check that the input point is not one of the low-order points.
2966 * This is recommended by the "May the Fourth" paper:
2967 * https://eprint.iacr.org/2017/806.pdf
2968 * Those points are never sent by an honest peer.
2969 */
Gilles Peskine449bd832023-01-11 14:50:10 +01002970static int ecp_check_bad_points_mx(const mbedtls_mpi *X, const mbedtls_mpi *P,
2971 const mbedtls_ecp_group_id grp_id)
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002972{
2973 int ret;
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02002974 mbedtls_mpi XmP;
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002975
Gilles Peskine449bd832023-01-11 14:50:10 +01002976 mbedtls_mpi_init(&XmP);
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002977
2978 /* Reduce X mod P so that we only need to check values less than P.
2979 * We know X < 2^256 so we can proceed by subtraction. */
Gilles Peskine449bd832023-01-11 14:50:10 +01002980 MBEDTLS_MPI_CHK(mbedtls_mpi_copy(&XmP, X));
2981 while (mbedtls_mpi_cmp_mpi(&XmP, P) >= 0) {
2982 MBEDTLS_MPI_CHK(mbedtls_mpi_sub_mpi(&XmP, &XmP, P));
2983 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002984
Janos Follath865a75e2021-06-24 15:34:59 +01002985 /* Check against the known bad values that are less than P. For Curve448
2986 * these are 0, 1 and -1. For Curve25519 we check the values less than P
2987 * from the following list: https://cr.yp.to/ecdh.html#validate */
Gilles Peskine449bd832023-01-11 14:50:10 +01002988 if (mbedtls_mpi_cmp_int(&XmP, 1) <= 0) { /* takes care of 0 and 1 */
Janos Follath8081ced2021-06-24 14:24:13 +01002989 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
2990 goto cleanup;
2991 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002992
Janos Follath865a75e2021-06-24 15:34:59 +01002993#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01002994 if (grp_id == MBEDTLS_ECP_DP_CURVE25519) {
2995 if (mbedtls_mpi_cmp_mpi(&XmP, &ecp_x25519_bad_point_1) == 0) {
Janos Follath865a75e2021-06-24 15:34:59 +01002996 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
2997 goto cleanup;
2998 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02002999
Gilles Peskine449bd832023-01-11 14:50:10 +01003000 if (mbedtls_mpi_cmp_mpi(&XmP, &ecp_x25519_bad_point_2) == 0) {
Janos Follath865a75e2021-06-24 15:34:59 +01003001 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
3002 goto cleanup;
3003 }
Janos Follath8081ced2021-06-24 14:24:13 +01003004 }
Janos Follath83e384d2021-06-25 15:29:56 +01003005#else
3006 (void) grp_id;
Janos Follath865a75e2021-06-24 15:34:59 +01003007#endif
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003008
Manuel Pégourié-Gonnard2389a602021-06-23 12:25:48 +02003009 /* Final check: check if XmP + 1 is P (final because it changes XmP!) */
Gilles Peskine449bd832023-01-11 14:50:10 +01003010 MBEDTLS_MPI_CHK(mbedtls_mpi_add_int(&XmP, &XmP, 1));
3011 if (mbedtls_mpi_cmp_mpi(&XmP, P) == 0) {
Janos Follath8081ced2021-06-24 14:24:13 +01003012 ret = MBEDTLS_ERR_ECP_INVALID_KEY;
3013 goto cleanup;
3014 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003015
3016 ret = 0;
3017
3018cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003019 mbedtls_mpi_free(&XmP);
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003020
Gilles Peskine449bd832023-01-11 14:50:10 +01003021 return ret;
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003022}
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003023
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003024/*
3025 * Check validity of a public key for Montgomery curves with x-only schemes
3026 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003027static int ecp_check_pubkey_mx(const mbedtls_ecp_group *grp, const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003028{
Manuel Pégourié-Gonnard07894332015-06-23 00:18:41 +02003029 /* [Curve25519 p. 5] Just check X is the correct number of bytes */
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003030 /* Allow any public value, if it's too big then we'll just reduce it mod p
3031 * (RFC 7748 sec. 5 para. 3). */
Gilles Peskine449bd832023-01-11 14:50:10 +01003032 if (mbedtls_mpi_size(&pt->X) > (grp->nbits + 7) / 8) {
3033 return MBEDTLS_ERR_ECP_INVALID_KEY;
3034 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003035
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003036 /* Implicit in all standards (as they don't consider negative numbers):
3037 * X must be non-negative. This is normally ensured by the way it's
3038 * encoded for transmission, but let's be extra sure. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003039 if (mbedtls_mpi_cmp_int(&pt->X, 0) < 0) {
3040 return MBEDTLS_ERR_ECP_INVALID_KEY;
3041 }
Manuel Pégourié-Gonnardf29857c2021-06-23 10:14:58 +02003042
Gilles Peskine449bd832023-01-11 14:50:10 +01003043 return ecp_check_bad_points_mx(&pt->X, &grp->P, grp->id);
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003044}
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003045#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003046
3047/*
3048 * Check that a point is valid as a public key
3049 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003050int mbedtls_ecp_check_pubkey(const mbedtls_ecp_group *grp,
3051 const mbedtls_ecp_point *pt)
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003052{
3053 /* Must use affine coordinates */
Gilles Peskine449bd832023-01-11 14:50:10 +01003054 if (mbedtls_mpi_cmp_int(&pt->Z, 1) != 0) {
3055 return MBEDTLS_ERR_ECP_INVALID_KEY;
3056 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003057
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003058#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003059 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3060 return ecp_check_pubkey_mx(grp, pt);
3061 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003062#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003063#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003064 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3065 return ecp_check_pubkey_sw(grp, pt);
3066 }
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003067#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01003068 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnardd9622732013-12-05 10:06:06 +01003069}
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003070
3071/*
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003072 * Check that an mbedtls_mpi is valid as a private key
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003073 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003074int mbedtls_ecp_check_privkey(const mbedtls_ecp_group *grp,
3075 const mbedtls_mpi *d)
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003076{
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003077#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003078 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003079 /* see RFC 7748 sec. 5 para. 5 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003080 if (mbedtls_mpi_get_bit(d, 0) != 0 ||
3081 mbedtls_mpi_get_bit(d, 1) != 0 ||
3082 mbedtls_mpi_bitlen(d) - 1 != grp->nbits) { /* mbedtls_mpi_bitlen is one-based! */
3083 return MBEDTLS_ERR_ECP_INVALID_KEY;
3084 }
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003085
3086 /* see [Curve25519] page 5 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003087 if (grp->nbits == 254 && mbedtls_mpi_get_bit(d, 2) != 0) {
3088 return MBEDTLS_ERR_ECP_INVALID_KEY;
3089 }
Nicholas Wilson08f3ef12015-11-10 13:10:01 +00003090
Gilles Peskine449bd832023-01-11 14:50:10 +01003091 return 0;
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003092 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003093#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
3094#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003095 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003096 /* see SEC1 3.2 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003097 if (mbedtls_mpi_cmp_int(d, 1) < 0 ||
3098 mbedtls_mpi_cmp_mpi(d, &grp->N) >= 0) {
3099 return MBEDTLS_ERR_ECP_INVALID_KEY;
3100 } else {
3101 return 0;
3102 }
Manuel Pégourié-Gonnard312d2e82013-12-04 11:08:01 +01003103 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003104#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003105
Gilles Peskine449bd832023-01-11 14:50:10 +01003106 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003107}
3108
Gilles Peskine72fcc982021-03-23 22:31:31 +01003109#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
3110MBEDTLS_STATIC_TESTABLE
Gilles Peskine449bd832023-01-11 14:50:10 +01003111int mbedtls_ecp_gen_privkey_mx(size_t high_bit,
3112 mbedtls_mpi *d,
3113 int (*f_rng)(void *, unsigned char *, size_t),
3114 void *p_rng)
Gilles Peskine72fcc982021-03-23 22:31:31 +01003115{
3116 int ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Gilles Peskine61f1f5f2021-03-24 12:46:46 +01003117 size_t n_random_bytes = high_bit / 8 + 1;
Gilles Peskine72fcc982021-03-23 22:31:31 +01003118
3119 /* [Curve25519] page 5 */
Gilles Peskine61f1f5f2021-03-24 12:46:46 +01003120 /* Generate a (high_bit+1)-bit random number by generating just enough
3121 * random bytes, then shifting out extra bits from the top (necessary
3122 * when (high_bit+1) is not a multiple of 8). */
Gilles Peskine449bd832023-01-11 14:50:10 +01003123 MBEDTLS_MPI_CHK(mbedtls_mpi_fill_random(d, n_random_bytes,
3124 f_rng, p_rng));
3125 MBEDTLS_MPI_CHK(mbedtls_mpi_shift_r(d, 8 * n_random_bytes - high_bit - 1));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003126
Gilles Peskine449bd832023-01-11 14:50:10 +01003127 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, high_bit, 1));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003128
3129 /* Make sure the last two bits are unset for Curve448, three bits for
3130 Curve25519 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003131 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 0, 0));
3132 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 1, 0));
3133 if (high_bit == 254) {
3134 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(d, 2, 0));
Gilles Peskine72fcc982021-03-23 22:31:31 +01003135 }
3136
3137cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003138 return ret;
Gilles Peskine72fcc982021-03-23 22:31:31 +01003139}
3140#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
3141
Gilles Peskine60d8b982021-03-29 22:28:21 +02003142#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
3143static int mbedtls_ecp_gen_privkey_sw(
3144 const mbedtls_mpi *N, mbedtls_mpi *d,
Gilles Peskine449bd832023-01-11 14:50:10 +01003145 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Gilles Peskine60d8b982021-03-29 22:28:21 +02003146{
Gilles Peskine449bd832023-01-11 14:50:10 +01003147 int ret = mbedtls_mpi_random(d, 1, N, f_rng, p_rng);
3148 switch (ret) {
Gilles Peskine60d8b982021-03-29 22:28:21 +02003149 case MBEDTLS_ERR_MPI_NOT_ACCEPTABLE:
Gilles Peskine449bd832023-01-11 14:50:10 +01003150 return MBEDTLS_ERR_ECP_RANDOM_FAILED;
Gilles Peskine60d8b982021-03-29 22:28:21 +02003151 default:
Gilles Peskine449bd832023-01-11 14:50:10 +01003152 return ret;
Gilles Peskine60d8b982021-03-29 22:28:21 +02003153 }
3154}
3155#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3156
Manuel Pégourié-Gonnardc8dc2952013-07-01 14:06:13 +02003157/*
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003158 * Generate a private key
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003159 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003160int mbedtls_ecp_gen_privkey(const mbedtls_ecp_group *grp,
3161 mbedtls_mpi *d,
3162 int (*f_rng)(void *, unsigned char *, size_t),
3163 void *p_rng)
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003164{
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003165#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003166 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3167 return mbedtls_ecp_gen_privkey_mx(grp->nbits, d, f_rng, p_rng);
3168 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003169#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003170
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003171#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003172 if (mbedtls_ecp_get_type(grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3173 return mbedtls_ecp_gen_privkey_sw(&grp->N, d, f_rng, p_rng);
3174 }
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003175#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003176
Gilles Peskine449bd832023-01-11 14:50:10 +01003177 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003178}
Manuel Pégourié-Gonnardc9573992014-01-03 12:54:00 +01003179
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003180/*
3181 * Generate a keypair with configurable base point
3182 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003183int mbedtls_ecp_gen_keypair_base(mbedtls_ecp_group *grp,
3184 const mbedtls_ecp_point *G,
3185 mbedtls_mpi *d, mbedtls_ecp_point *Q,
3186 int (*f_rng)(void *, unsigned char *, size_t),
3187 void *p_rng)
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003188{
Janos Follath24eed8d2019-11-22 13:21:35 +00003189 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01003190 MBEDTLS_MPI_CHK(mbedtls_ecp_gen_privkey(grp, d, f_rng, p_rng));
3191 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, Q, d, G, f_rng, p_rng));
Manuel Pégourié-Gonnarda7937f92017-04-20 15:37:46 +02003192
3193cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003194 return ret;
Manuel Pégourié-Gonnardd9a3f472015-08-11 14:31:03 +02003195}
3196
3197/*
3198 * Generate key pair, wrapper for conventional base point
3199 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003200int mbedtls_ecp_gen_keypair(mbedtls_ecp_group *grp,
3201 mbedtls_mpi *d, mbedtls_ecp_point *Q,
3202 int (*f_rng)(void *, unsigned char *, size_t),
3203 void *p_rng)
Manuel Pégourié-Gonnardd9a3f472015-08-11 14:31:03 +02003204{
Gilles Peskine449bd832023-01-11 14:50:10 +01003205 return mbedtls_ecp_gen_keypair_base(grp, &grp->G, d, Q, f_rng, p_rng);
Manuel Pégourié-Gonnard45a035a2013-01-26 14:42:45 +01003206}
Manuel Pégourié-Gonnardefaa31e2012-11-06 21:34:35 +01003207
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003208/*
3209 * Generate a keypair, prettier wrapper
3210 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003211int mbedtls_ecp_gen_key(mbedtls_ecp_group_id grp_id, mbedtls_ecp_keypair *key,
3212 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003213{
Janos Follath24eed8d2019-11-22 13:21:35 +00003214 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Gilles Peskine449bd832023-01-11 14:50:10 +01003215 if ((ret = mbedtls_ecp_group_load(&key->grp, grp_id)) != 0) {
3216 return ret;
3217 }
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003218
Gilles Peskine449bd832023-01-11 14:50:10 +01003219 return mbedtls_ecp_gen_keypair(&key->grp, &key->d, &key->Q, f_rng, p_rng);
Manuel Pégourié-Gonnard104ee1d2013-11-30 14:13:16 +01003220}
3221
Janos Follath77800962019-02-25 16:32:08 +00003222#define ECP_CURVE25519_KEY_SIZE 32
Archana1d2e2bb2021-06-07 06:13:16 +05303223#define ECP_CURVE448_KEY_SIZE 56
Janos Follath171a7ef2019-02-15 16:17:45 +00003224/*
3225 * Read a private key.
3226 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003227int mbedtls_ecp_read_key(mbedtls_ecp_group_id grp_id, mbedtls_ecp_keypair *key,
3228 const unsigned char *buf, size_t buflen)
Janos Follath171a7ef2019-02-15 16:17:45 +00003229{
3230 int ret = 0;
3231
Gilles Peskine449bd832023-01-11 14:50:10 +01003232 if ((ret = mbedtls_ecp_group_load(&key->grp, grp_id)) != 0) {
3233 return ret;
3234 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003235
Janos Follath28eb06d2019-02-26 10:53:34 +00003236 ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
3237
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003238#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003239 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
Janos Follath28eb06d2019-02-26 10:53:34 +00003240 /*
Archana1d2e2bb2021-06-07 06:13:16 +05303241 * Mask the key as mandated by RFC7748 for Curve25519 and Curve448.
Janos Follath28eb06d2019-02-26 10:53:34 +00003242 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003243 if (grp_id == MBEDTLS_ECP_DP_CURVE25519) {
3244 if (buflen != ECP_CURVE25519_KEY_SIZE) {
3245 return MBEDTLS_ERR_ECP_INVALID_KEY;
3246 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003247
Gilles Peskine449bd832023-01-11 14:50:10 +01003248 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&key->d, buf, buflen));
Janos Follath171a7ef2019-02-15 16:17:45 +00003249
Janos Follath28eb06d2019-02-26 10:53:34 +00003250 /* Set the three least significant bits to 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003251 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 0, 0));
3252 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 1, 0));
3253 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 2, 0));
Janos Follath171a7ef2019-02-15 16:17:45 +00003254
Janos Follath28eb06d2019-02-26 10:53:34 +00003255 /* Set the most significant bit to 0 */
3256 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003257 mbedtls_mpi_set_bit(&key->d,
3258 ECP_CURVE25519_KEY_SIZE * 8 - 1, 0)
3259 );
Janos Follath171a7ef2019-02-15 16:17:45 +00003260
Janos Follath28eb06d2019-02-26 10:53:34 +00003261 /* Set the second most significant bit to 1 */
3262 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003263 mbedtls_mpi_set_bit(&key->d,
3264 ECP_CURVE25519_KEY_SIZE * 8 - 2, 1)
3265 );
3266 } else if (grp_id == MBEDTLS_ECP_DP_CURVE448) {
3267 if (buflen != ECP_CURVE448_KEY_SIZE) {
3268 return MBEDTLS_ERR_ECP_INVALID_KEY;
3269 }
Archana1d2e2bb2021-06-07 06:13:16 +05303270
Gilles Peskine449bd832023-01-11 14:50:10 +01003271 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary_le(&key->d, buf, buflen));
Archana1d2e2bb2021-06-07 06:13:16 +05303272
3273 /* Set the two least significant bits to 0 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003274 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 0, 0));
3275 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(&key->d, 1, 0));
Archana1d2e2bb2021-06-07 06:13:16 +05303276
3277 /* Set the most significant bit to 1 */
3278 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003279 mbedtls_mpi_set_bit(&key->d,
3280 ECP_CURVE448_KEY_SIZE * 8 - 1, 1)
3281 );
Archana1d2e2bb2021-06-07 06:13:16 +05303282 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003283 }
3284
3285#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003286#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003287 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3288 MBEDTLS_MPI_CHK(mbedtls_mpi_read_binary(&key->d, buf, buflen));
Janos Follath171a7ef2019-02-15 16:17:45 +00003289
Gilles Peskine449bd832023-01-11 14:50:10 +01003290 MBEDTLS_MPI_CHK(mbedtls_ecp_check_privkey(&key->grp, &key->d));
Janos Follath171a7ef2019-02-15 16:17:45 +00003291 }
3292
3293#endif
3294cleanup:
3295
Gilles Peskine449bd832023-01-11 14:50:10 +01003296 if (ret != 0) {
3297 mbedtls_mpi_free(&key->d);
3298 }
Janos Follath171a7ef2019-02-15 16:17:45 +00003299
Gilles Peskine449bd832023-01-11 14:50:10 +01003300 return ret;
Janos Follath171a7ef2019-02-15 16:17:45 +00003301}
3302
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003303/*
Steven Cooremande8593f2020-06-09 19:55:26 +02003304 * Write a private key.
3305 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003306int mbedtls_ecp_write_key(mbedtls_ecp_keypair *key,
3307 unsigned char *buf, size_t buflen)
Steven Cooremande8593f2020-06-09 19:55:26 +02003308{
Steven Cooreman0024df62020-07-13 10:59:40 +02003309 int ret = MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE;
Steven Cooremande8593f2020-06-09 19:55:26 +02003310
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003311#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003312 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_MONTGOMERY) {
3313 if (key->grp.id == MBEDTLS_ECP_DP_CURVE25519) {
3314 if (buflen < ECP_CURVE25519_KEY_SIZE) {
3315 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
3316 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003317
Gilles Peskine449bd832023-01-11 14:50:10 +01003318 } else if (key->grp.id == MBEDTLS_ECP_DP_CURVE448) {
3319 if (buflen < ECP_CURVE448_KEY_SIZE) {
3320 return MBEDTLS_ERR_ECP_BUFFER_TOO_SMALL;
3321 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003322 }
Gilles Peskine449bd832023-01-11 14:50:10 +01003323 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary_le(&key->d, buf, buflen));
Steven Cooremande8593f2020-06-09 19:55:26 +02003324 }
Steven Cooremande8593f2020-06-09 19:55:26 +02003325#endif
Gilles Peskinee8c04fe2018-09-14 17:44:21 +02003326#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003327 if (mbedtls_ecp_get_type(&key->grp) == MBEDTLS_ECP_TYPE_SHORT_WEIERSTRASS) {
3328 MBEDTLS_MPI_CHK(mbedtls_mpi_write_binary(&key->d, buf, buflen));
Steven Cooremande8593f2020-06-09 19:55:26 +02003329 }
3330
3331#endif
3332cleanup:
3333
Gilles Peskine449bd832023-01-11 14:50:10 +01003334 return ret;
Steven Cooremande8593f2020-06-09 19:55:26 +02003335}
3336
3337
3338/*
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003339 * Check a public-private key pair
3340 */
Manuel Pégourié-Gonnardf8c24bf2021-06-15 11:29:26 +02003341int mbedtls_ecp_check_pub_priv(
Gilles Peskine449bd832023-01-11 14:50:10 +01003342 const mbedtls_ecp_keypair *pub, const mbedtls_ecp_keypair *prv,
3343 int (*f_rng)(void *, unsigned char *, size_t), void *p_rng)
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003344{
Janos Follath24eed8d2019-11-22 13:21:35 +00003345 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003346 mbedtls_ecp_point Q;
3347 mbedtls_ecp_group grp;
Gilles Peskine449bd832023-01-11 14:50:10 +01003348 if (pub->grp.id == MBEDTLS_ECP_DP_NONE ||
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003349 pub->grp.id != prv->grp.id ||
Gilles Peskine449bd832023-01-11 14:50:10 +01003350 mbedtls_mpi_cmp_mpi(&pub->Q.X, &prv->Q.X) ||
3351 mbedtls_mpi_cmp_mpi(&pub->Q.Y, &prv->Q.Y) ||
3352 mbedtls_mpi_cmp_mpi(&pub->Q.Z, &prv->Q.Z)) {
3353 return MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003354 }
3355
Gilles Peskine449bd832023-01-11 14:50:10 +01003356 mbedtls_ecp_point_init(&Q);
3357 mbedtls_ecp_group_init(&grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003358
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003359 /* mbedtls_ecp_mul() needs a non-const group... */
Gilles Peskine449bd832023-01-11 14:50:10 +01003360 mbedtls_ecp_group_copy(&grp, &prv->grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003361
3362 /* Also checks d is valid */
Gilles Peskine449bd832023-01-11 14:50:10 +01003363 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(&grp, &Q, &prv->d, &prv->grp.G, f_rng, p_rng));
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003364
Gilles Peskine449bd832023-01-11 14:50:10 +01003365 if (mbedtls_mpi_cmp_mpi(&Q.X, &prv->Q.X) ||
3366 mbedtls_mpi_cmp_mpi(&Q.Y, &prv->Q.Y) ||
3367 mbedtls_mpi_cmp_mpi(&Q.Z, &prv->Q.Z)) {
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003368 ret = MBEDTLS_ERR_ECP_BAD_INPUT_DATA;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003369 goto cleanup;
3370 }
3371
3372cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003373 mbedtls_ecp_point_free(&Q);
3374 mbedtls_ecp_group_free(&grp);
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003375
Gilles Peskine449bd832023-01-11 14:50:10 +01003376 return ret;
Manuel Pégourié-Gonnard30668d62014-11-06 15:25:32 +01003377}
3378
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003379/*
3380 * Export generic key-pair parameters.
3381 */
3382int mbedtls_ecp_export(const mbedtls_ecp_keypair *key, mbedtls_ecp_group *grp,
3383 mbedtls_mpi *d, mbedtls_ecp_point *Q)
3384{
3385 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003386
Gilles Peskine449bd832023-01-11 14:50:10 +01003387 if ((ret = mbedtls_ecp_group_copy(grp, &key->grp)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003388 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003389 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003390
Gilles Peskine449bd832023-01-11 14:50:10 +01003391 if ((ret = mbedtls_mpi_copy(d, &key->d)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003392 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003393 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003394
Gilles Peskine449bd832023-01-11 14:50:10 +01003395 if ((ret = mbedtls_ecp_copy(Q, &key->Q)) != 0) {
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003396 return ret;
Gilles Peskine449bd832023-01-11 14:50:10 +01003397 }
Przemek Stekiel711d0f52022-03-18 13:52:26 +01003398
3399 return 0;
3400}
3401
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003402#if defined(MBEDTLS_SELF_TEST)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003403
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003404/*
3405 * PRNG for test - !!!INSECURE NEVER USE IN PRODUCTION!!!
3406 *
3407 * This is the linear congruential generator from numerical recipes,
3408 * except we only use the low byte as the output. See
3409 * https://en.wikipedia.org/wiki/Linear_congruential_generator#Parameters_in_common_use
3410 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003411static int self_test_rng(void *ctx, unsigned char *out, size_t len)
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003412{
3413 static uint32_t state = 42;
3414
3415 (void) ctx;
3416
Gilles Peskine449bd832023-01-11 14:50:10 +01003417 for (size_t i = 0; i < len; i++) {
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003418 state = state * 1664525u + 1013904223u;
3419 out[i] = (unsigned char) state;
3420 }
3421
Gilles Peskine449bd832023-01-11 14:50:10 +01003422 return 0;
Manuel Pégourié-Gonnardaa3ed6f2021-06-15 11:29:26 +02003423}
3424
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003425/* Adjust the exponent to be a valid private point for the specified curve.
3426 * This is sometimes necessary because we use a single set of exponents
3427 * for all curves but the validity of values depends on the curve. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003428static int self_test_adjust_exponent(const mbedtls_ecp_group *grp,
3429 mbedtls_mpi *m)
Gilles Peskinea088c812018-09-17 18:31:15 +02003430{
3431 int ret = 0;
Gilles Peskine449bd832023-01-11 14:50:10 +01003432 switch (grp->id) {
3433 /* If Curve25519 is available, then that's what we use for the
3434 * Montgomery test, so we don't need the adjustment code. */
3435#if !defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskinea088c812018-09-17 18:31:15 +02003436#if defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
3437 case MBEDTLS_ECP_DP_CURVE448:
3438 /* Move highest bit from 254 to N-1. Setting bit N-1 is
3439 * necessary to enforce the highest-bit-set constraint. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003440 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(m, 254, 0));
3441 MBEDTLS_MPI_CHK(mbedtls_mpi_set_bit(m, grp->nbits, 1));
Gilles Peskinea088c812018-09-17 18:31:15 +02003442 /* Copy second-highest bit from 253 to N-2. This is not
3443 * necessary but improves the test variety a bit. */
3444 MBEDTLS_MPI_CHK(
Gilles Peskine449bd832023-01-11 14:50:10 +01003445 mbedtls_mpi_set_bit(m, grp->nbits - 1,
3446 mbedtls_mpi_get_bit(m, 253)));
Gilles Peskinea088c812018-09-17 18:31:15 +02003447 break;
3448#endif
3449#endif /* ! defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED) */
3450 default:
3451 /* Non-Montgomery curves and Curve25519 need no adjustment. */
3452 (void) grp;
3453 (void) m;
3454 goto cleanup;
3455 }
3456cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003457 return ret;
Gilles Peskinea088c812018-09-17 18:31:15 +02003458}
3459
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003460/* Calculate R = m.P for each m in exponents. Check that the number of
3461 * basic operations doesn't depend on the value of m. */
Gilles Peskine449bd832023-01-11 14:50:10 +01003462static int self_test_point(int verbose,
3463 mbedtls_ecp_group *grp,
3464 mbedtls_ecp_point *R,
3465 mbedtls_mpi *m,
3466 const mbedtls_ecp_point *P,
3467 const char *const *exponents,
3468 size_t n_exponents)
Gilles Peskinec95696f2018-09-17 15:59:01 +02003469{
3470 int ret = 0;
Gilles Peskine24666792018-09-17 18:29:49 +02003471 size_t i = 0;
Gilles Peskinec95696f2018-09-17 15:59:01 +02003472 unsigned long add_c_prev, dbl_c_prev, mul_c_prev;
3473 add_count = 0;
3474 dbl_count = 0;
3475 mul_count = 0;
Gilles Peskinea088c812018-09-17 18:31:15 +02003476
Gilles Peskine449bd832023-01-11 14:50:10 +01003477 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(m, 16, exponents[0]));
3478 MBEDTLS_MPI_CHK(self_test_adjust_exponent(grp, m));
3479 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, R, m, P, self_test_rng, NULL));
Gilles Peskinec95696f2018-09-17 15:59:01 +02003480
Gilles Peskine449bd832023-01-11 14:50:10 +01003481 for (i = 1; i < n_exponents; i++) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003482 add_c_prev = add_count;
3483 dbl_c_prev = dbl_count;
3484 mul_c_prev = mul_count;
3485 add_count = 0;
3486 dbl_count = 0;
3487 mul_count = 0;
3488
Gilles Peskine449bd832023-01-11 14:50:10 +01003489 MBEDTLS_MPI_CHK(mbedtls_mpi_read_string(m, 16, exponents[i]));
3490 MBEDTLS_MPI_CHK(self_test_adjust_exponent(grp, m));
3491 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(grp, R, m, P, self_test_rng, NULL));
Gilles Peskinec95696f2018-09-17 15:59:01 +02003492
Gilles Peskine449bd832023-01-11 14:50:10 +01003493 if (add_count != add_c_prev ||
Gilles Peskinec95696f2018-09-17 15:59:01 +02003494 dbl_count != dbl_c_prev ||
Gilles Peskine449bd832023-01-11 14:50:10 +01003495 mul_count != mul_c_prev) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003496 ret = 1;
3497 break;
3498 }
3499 }
3500
3501cleanup:
Gilles Peskine449bd832023-01-11 14:50:10 +01003502 if (verbose != 0) {
3503 if (ret != 0) {
3504 mbedtls_printf("failed (%u)\n", (unsigned int) i);
3505 } else {
3506 mbedtls_printf("passed\n");
3507 }
Gilles Peskinec95696f2018-09-17 15:59:01 +02003508 }
Gilles Peskine449bd832023-01-11 14:50:10 +01003509 return ret;
Gilles Peskinec95696f2018-09-17 15:59:01 +02003510}
3511
Manuel Pégourié-Gonnardb505c272012-11-05 17:27:54 +01003512/*
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003513 * Checkup routine
3514 */
Gilles Peskine449bd832023-01-11 14:50:10 +01003515int mbedtls_ecp_self_test(int verbose)
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003516{
Janos Follath24eed8d2019-11-22 13:21:35 +00003517 int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003518 mbedtls_ecp_group grp;
3519 mbedtls_ecp_point R, P;
3520 mbedtls_mpi m;
Gilles Peskine24666792018-09-17 18:29:49 +02003521
3522#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Gilles Peskined9767a52018-09-14 19:29:47 +02003523 /* Exponents especially adapted for secp192k1, which has the lowest
3524 * order n of all supported curves (secp192r1 is in a slightly larger
3525 * field but the order of its base point is slightly smaller). */
Gilles Peskine24666792018-09-17 18:29:49 +02003526 const char *sw_exponents[] =
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003527 {
Manuel Pégourié-Gonnardb63f9e92012-11-21 13:00:58 +01003528 "000000000000000000000000000000000000000000000001", /* one */
Gilles Peskined9767a52018-09-14 19:29:47 +02003529 "FFFFFFFFFFFFFFFFFFFFFFFE26F2FC170F69466A74DEFD8C", /* n - 1 */
Manuel Pégourié-Gonnardb63f9e92012-11-21 13:00:58 +01003530 "5EA6F389A38B8BC81E767753B15AA5569E1782E30ABE7D25", /* random */
Manuel Pégourié-Gonnardff27b7c2013-11-21 09:28:03 +01003531 "400000000000000000000000000000000000000000000000", /* one and zeros */
3532 "7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF", /* all ones */
3533 "555555555555555555555555555555555555555555555555", /* 101010... */
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003534 };
Gilles Peskine24666792018-09-17 18:29:49 +02003535#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3536#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
3537 const char *m_exponents[] =
3538 {
Gilles Peskine6d9c8d72020-07-22 01:26:25 +02003539 /* Valid private values for Curve25519. In a build with Curve448
3540 * but not Curve25519, they will be adjusted in
3541 * self_test_adjust_exponent(). */
Gilles Peskine24666792018-09-17 18:29:49 +02003542 "4000000000000000000000000000000000000000000000000000000000000000",
3543 "5C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C3C30",
3544 "5715ECCE24583F7A7023C24164390586842E816D7280A49EF6DF4EAE6B280BF8",
3545 "41A2B017516F6D254E1F002BCCBADD54BE30F8CEC737A0E912B4963B6BA74460",
3546 "5555555555555555555555555555555555555555555555555555555555555550",
3547 "7FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF8",
3548 };
3549#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003550
Gilles Peskine449bd832023-01-11 14:50:10 +01003551 mbedtls_ecp_group_init(&grp);
3552 mbedtls_ecp_point_init(&R);
3553 mbedtls_ecp_point_init(&P);
3554 mbedtls_mpi_init(&m);
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003555
Gilles Peskine24666792018-09-17 18:29:49 +02003556#if defined(MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED)
Manuel Pégourié-Gonnardb8012fc2013-10-10 15:40:49 +02003557 /* Use secp192r1 if available, or any available curve */
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003558#if defined(MBEDTLS_ECP_DP_SECP192R1_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003559 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_SECP192R1));
Paul Bakker5dc6b5f2013-06-29 23:26:34 +02003560#else
Gilles Peskine449bd832023-01-11 14:50:10 +01003561 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, mbedtls_ecp_curve_list()->grp_id));
Manuel Pégourié-Gonnardb8012fc2013-10-10 15:40:49 +02003562#endif
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003563
Gilles Peskine449bd832023-01-11 14:50:10 +01003564 if (verbose != 0) {
3565 mbedtls_printf(" ECP SW test #1 (constant op_count, base point G): ");
3566 }
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003567 /* Do a dummy multiplication first to trigger precomputation */
Gilles Peskine449bd832023-01-11 14:50:10 +01003568 MBEDTLS_MPI_CHK(mbedtls_mpi_lset(&m, 2));
3569 MBEDTLS_MPI_CHK(mbedtls_ecp_mul(&grp, &P, &m, &grp.G, self_test_rng, NULL));
3570 ret = self_test_point(verbose,
3571 &grp, &R, &m, &grp.G,
3572 sw_exponents,
3573 sizeof(sw_exponents) / sizeof(sw_exponents[0]));
3574 if (ret != 0) {
Gilles Peskinec95696f2018-09-17 15:59:01 +02003575 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003576 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003577
Gilles Peskine449bd832023-01-11 14:50:10 +01003578 if (verbose != 0) {
3579 mbedtls_printf(" ECP SW test #2 (constant op_count, other point): ");
3580 }
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003581 /* We computed P = 2G last time, use it */
Gilles Peskine449bd832023-01-11 14:50:10 +01003582 ret = self_test_point(verbose,
3583 &grp, &R, &m, &P,
3584 sw_exponents,
3585 sizeof(sw_exponents) / sizeof(sw_exponents[0]));
3586 if (ret != 0) {
Gilles Peskine24666792018-09-17 18:29:49 +02003587 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003588 }
Gilles Peskine24666792018-09-17 18:29:49 +02003589
Gilles Peskine449bd832023-01-11 14:50:10 +01003590 mbedtls_ecp_group_free(&grp);
3591 mbedtls_ecp_point_free(&R);
Gilles Peskine24666792018-09-17 18:29:49 +02003592#endif /* MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */
3593
3594#if defined(MBEDTLS_ECP_MONTGOMERY_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003595 if (verbose != 0) {
3596 mbedtls_printf(" ECP Montgomery test (constant op_count): ");
3597 }
Gilles Peskine24666792018-09-17 18:29:49 +02003598#if defined(MBEDTLS_ECP_DP_CURVE25519_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003599 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_CURVE25519));
Gilles Peskine24666792018-09-17 18:29:49 +02003600#elif defined(MBEDTLS_ECP_DP_CURVE448_ENABLED)
Gilles Peskine449bd832023-01-11 14:50:10 +01003601 MBEDTLS_MPI_CHK(mbedtls_ecp_group_load(&grp, MBEDTLS_ECP_DP_CURVE448));
Gilles Peskine24666792018-09-17 18:29:49 +02003602#else
3603#error "MBEDTLS_ECP_MONTGOMERY_ENABLED is defined, but no curve is supported for self-test"
3604#endif
Gilles Peskine449bd832023-01-11 14:50:10 +01003605 ret = self_test_point(verbose,
3606 &grp, &R, &m, &grp.G,
3607 m_exponents,
3608 sizeof(m_exponents) / sizeof(m_exponents[0]));
3609 if (ret != 0) {
Gilles Peskine24666792018-09-17 18:29:49 +02003610 goto cleanup;
Gilles Peskine449bd832023-01-11 14:50:10 +01003611 }
Gilles Peskine24666792018-09-17 18:29:49 +02003612#endif /* MBEDTLS_ECP_MONTGOMERY_ENABLED */
Manuel Pégourié-Gonnard161ef962013-09-17 19:13:10 +02003613
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003614cleanup:
3615
Gilles Peskine449bd832023-01-11 14:50:10 +01003616 if (ret < 0 && verbose != 0) {
3617 mbedtls_printf("Unexpected error, return code = %08X\n", (unsigned int) ret);
3618 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003619
Gilles Peskine449bd832023-01-11 14:50:10 +01003620 mbedtls_ecp_group_free(&grp);
3621 mbedtls_ecp_point_free(&R);
3622 mbedtls_ecp_point_free(&P);
3623 mbedtls_mpi_free(&m);
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003624
Gilles Peskine449bd832023-01-11 14:50:10 +01003625 if (verbose != 0) {
3626 mbedtls_printf("\n");
3627 }
Manuel Pégourié-Gonnardb4a310b2012-11-13 20:57:00 +01003628
Gilles Peskine449bd832023-01-11 14:50:10 +01003629 return ret;
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003630}
3631
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003632#endif /* MBEDTLS_SELF_TEST */
Manuel Pégourié-Gonnard39d2adb2012-10-31 09:26:55 +01003633
Janos Follathb0697532016-08-18 12:38:46 +01003634#endif /* !MBEDTLS_ECP_ALT */
3635
Manuel Pégourié-Gonnard2cf5a7c2015-04-08 12:49:31 +02003636#endif /* MBEDTLS_ECP_C */