commit d6028a1894ed9675769b13ae619a0ea6d937882b
author Hanno Becker <hanno.becker@arm.com> Mon Oct 15 12:01:35 2018 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Wed Apr 24 10:51:54 2019 +0200
tree 65e59c44d1000f2c5ff30c3977a18e8c8d497057
parent 20d707dd3eb9deadb5efe94c09fa6f105c56c5f1

Improve macro hygiene

This commit improves hygiene and formatting of macro definitions
throughout the library. Specifically:
- It adds brackets around parameters to avoid unintended
  interpretation of arguments, e.g. due to operator precedence.
- It adds uses of the `do { ... } while( 0 )` idiom for macros that
  can be used as commands.

library/x509_crt.c

diff --git a/library/x509_crt.c b/library/x509_crt.c
index 325bbc0..ebd118d 100644
--- a/library/x509_crt.c
+++ b/library/x509_crt.c
@@ -1439,7 +1439,7 @@
     }
 
 #define CERT_TYPE(type,name)                    \
-    if( ns_cert_type & type )                   \
+    if( ns_cert_type & (type) )                 \
         PRINT_ITEM( name );
 
 static int x509_info_cert_type( char **buf, size_t *size,
@@ -1466,7 +1466,7 @@
 }
 
 #define KEY_USAGE(code,name)    \
-    if( key_usage & code )      \
+    if( key_usage & (code) )    \
         PRINT_ITEM( name );
 
 static int x509_info_key_usage( char **buf, size_t *size,