commit bdba26c8d7169d3289d293b2e7583c406d73579a
author Dave Rodgman <dave.rodgman@arm.com> Wed Dec 13 11:19:00 2023 +0000
committer GitHub <noreply@github.com> Wed Dec 13 11:19:00 2023 +0000
tree 33b11f17ee1aff58c50e7fc2da8dacd0a2011d0a
parent 7404af6ec3befe5b188b8b776f42cb1db6da74d8
parent e04a97a1eb3586e2cafb74fb744cc5b3205b5539

Merge pull request #8626 from davidhorstmann-arm/fix-uninit-mpi-test

Fix possible free of uninitialized MPI

tests/suites/test_suite_x509write.function

diff --git a/tests/suites/test_suite_x509write.function b/tests/suites/test_suite_x509write.function
index 4de9add..b59fd48 100644
--- a/tests/suites/test_suite_x509write.function
+++ b/tests/suites/test_suite_x509write.function
@@ -665,13 +665,15 @@
     mbedtls_x509write_cert ctx;
     uint8_t invalid_serial[MBEDTLS_X509_RFC5280_MAX_SERIAL_LEN + 1];
 
+#if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
+    mbedtls_mpi serial_mpi;
+    mbedtls_mpi_init(&serial_mpi);
+#endif
+
     USE_PSA_INIT();
     memset(invalid_serial, 0x01, sizeof(invalid_serial));
 
 #if defined(MBEDTLS_TEST_DEPRECATED) && defined(MBEDTLS_BIGNUM_C)
-    mbedtls_mpi serial_mpi;
-
-    mbedtls_mpi_init(&serial_mpi);
     TEST_EQUAL(mbedtls_mpi_read_binary(&serial_mpi, invalid_serial,
                                        sizeof(invalid_serial)), 0);
     TEST_EQUAL(mbedtls_x509write_crt_set_serial(&ctx, &serial_mpi),