commit bb9cbc7a23c117437e3ef58076da76601053caf4
author Ronald Cron <ronald.cron@arm.com> Thu Mar 04 17:09:00 2021 +0100
committer Ronald Cron <ronald.cron@arm.com> Thu Mar 04 17:43:31 2021 +0100
tree 1f481de7e52a27c015c6ff1266db60fd67468542
parent 9103d490e8955c2b9723a266af000fc99eeb8f85

psa: ecdsa: Prefer NOT_SUPPORTED error code

When ECDSA is not supported by the library, prefer
to return NOT_SUPPORTED than INVALID_ARGUMENT when
asked for an ECDSA signature.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 7a2b65d..3b5e33d 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -3090,10 +3090,10 @@
     else
 #endif /* defined(MBEDTLS_PSA_BUILTIN_ALG_RSA_PKCS1V15_SIGN) ||
         * defined(MBEDTLS_PSA_BUILTIN_ALG_RSA_PSS) */
-    if( PSA_KEY_TYPE_IS_ECC( attributes->core.type ) )
-    {
 #if defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) || \
     defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA)
+    if( PSA_KEY_TYPE_IS_ECC( attributes->core.type ) )
+    {
         if( PSA_ALG_IS_ECDSA( alg ) )
         {
             return( mbedtls_psa_ecdsa_sign_hash(
@@ -3103,14 +3103,15 @@
                         signature, signature_size, signature_length ) );
         }
         else
-#endif /* defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) ||
-        * defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA) */
         {
             return( PSA_ERROR_INVALID_ARGUMENT );
         }
     }
     else
+#endif /* defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) ||
+        * defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA) */
     {
+        (void)attributes;
         (void)key_buffer;
         (void)key_buffer_size;
         (void)alg;