commit b30adce7fd5c66e0bb35c2d882215c43ae3b32d2
author Dave Rodgman <dave.rodgman@arm.com> Fri Aug 04 12:52:51 2023 +0100
committer Dave Rodgman <dave.rodgman@arm.com> Sun Aug 20 20:20:12 2023 +0100
tree 5413ca3e8aa1123b98f6b25b959d08ebc55d2c61
parent 4566132163a11d4f98b0685a33587281f059ef18

Use -1 as uninitialised marker

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

library/aesce.c

diff --git a/library/aesce.c b/library/aesce.c
index 42e04d3..6f75a67 100644
--- a/library/aesce.c
+++ b/library/aesce.c
@@ -99,7 +99,7 @@
 #include <asm/hwcap.h>
 #include <sys/auxv.h>
 
-char mbedtls_aesce_has_support_result = 2;
+signed char mbedtls_aesce_has_support_result = -1;
 
 #if !defined(MBEDTLS_AES_USE_HARDWARE_ONLY)
 /*
@@ -113,7 +113,7 @@
      * It is possible that we could end up setting result more than
      * once, but that is harmless.
      */
-    if (mbedtls_aesce_has_support_result == 2) {
+    if (mbedtls_aesce_has_support_result == -1) {
         unsigned long auxval = getauxval(AT_HWCAP);
         if ((auxval & (HWCAP_ASIMD | HWCAP_AES)) ==
             (HWCAP_ASIMD | HWCAP_AES)) {

library/aesce.h

diff --git a/library/aesce.h b/library/aesce.h
index 1a0abb8..8d48c60 100644
--- a/library/aesce.h
+++ b/library/aesce.h
@@ -44,7 +44,7 @@
 
 #if defined(__linux__) && !defined(MBEDTLS_AES_USE_HARDWARE_ONLY)
 
-extern char mbedtls_aesce_has_support_result;
+extern signed char mbedtls_aesce_has_support_result;
 
 /**
  * \brief          Internal function to detect the crypto extension in CPUs.
@@ -53,7 +53,7 @@
  */
 int mbedtls_aesce_has_support_impl(void);
 
-#define mbedtls_aesce_has_support() (mbedtls_aesce_has_support_result == 2 ? \
+#define mbedtls_aesce_has_support() (mbedtls_aesce_has_support_result == -1 ? \
                                      mbedtls_aesce_has_support_impl() : \
                                      mbedtls_aesce_has_support_result)