commit 9103d490e8955c2b9723a266af000fc99eeb8f85
author Ronald Cron <ronald.cron@arm.com> Thu Mar 04 11:26:03 2021 +0100
committer Ronald Cron <ronald.cron@arm.com> Thu Mar 04 13:32:27 2021 +0100
tree 6c35a040567e844b7183bcfedc15a6d6866d2111
parent 566899eefae1eae26eb971b68ae535b2d06b124a

psa: ecdsa: Rework deterministic support check

Move the check that ECDSA is supported from the
caller of the function responsible for Mbed TLS
ECDSA signatures to this function, namely
mbedtls_psa_ecdsa_sign_hash().

This makes the caller code more readable and is
more aligned with what is expected from a
sign_hash() PSA driver entry point.

Add a negative test case where a deterministic
ECDSA signature is requested while the library
does not support deterministic ECDSA.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 3ba056d..7a2b65d 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -3094,13 +3094,7 @@
     {
 #if defined(MBEDTLS_PSA_BUILTIN_ALG_ECDSA) || \
     defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA)
-        if(
-#if defined(MBEDTLS_PSA_BUILTIN_ALG_DETERMINISTIC_ECDSA)
-            PSA_ALG_IS_ECDSA( alg )
-#else
-            PSA_ALG_IS_RANDOMIZED_ECDSA( alg )
-#endif
-            )
+        if( PSA_ALG_IS_ECDSA( alg ) )
         {
             return( mbedtls_psa_ecdsa_sign_hash(
                         attributes,