commit 86981955666dd9284213668de7e887009f5b2338
author XiaokangQian <xiaokang.qian@arm.com> Tue Jul 19 09:51:50 2022 +0000
committer Ronald Cron <ronald.cron@arm.com> Thu Jul 21 15:30:04 2022 +0200
tree 54a3f143ad0f6800b264aa9388dbb12f3ae21335
parent adab9a64400796fb53a1911dc2ec9e6a2b16450f

Address comments of various issues

Improve comments
Change coding style
Rename functions

Change-Id: Ia111aef303932cfeee693431c3d48f90342b32e5
Signed-off-by: XiaokangQian <xiaokang.qian@arm.com>

library/ssl_tls13_generic.c

diff --git a/library/ssl_tls13_generic.c b/library/ssl_tls13_generic.c
index 4cd0d0e..9fd246d 100644
--- a/library/ssl_tls13_generic.c
+++ b/library/ssl_tls13_generic.c
@@ -1509,6 +1509,7 @@
 /* Check if we have any PSK to offer, returns 0 if PSK is available.
  * Assign the psk and ticket if pointers are present.
  */
+MBEDTLS_CHECK_RETURN_CRITICAL
 int mbedtls_ssl_get_psk_to_offer(
         const mbedtls_ssl_context *ssl,
         int *psk_type,
@@ -1517,7 +1518,7 @@
 {
     int ptrs_present = 0;
 
-    if( psk != NULL && psk_len != NULL &&
+    if( psk_type != NULL && psk != NULL && psk_len != NULL &&
         psk_identity != NULL && psk_identity_len != NULL )
     {
         ptrs_present = 1;
@@ -1528,14 +1529,13 @@
     {
         if( ptrs_present )
         {
+            *psk_type = MBEDTLS_SSL_TLS1_3_PSK_EXTERNAL;
             *psk = ssl->conf->psk;
             *psk_len = ssl->conf->psk_len;
             *psk_identity = ssl->conf->psk_identity;
             *psk_identity_len = ssl->conf->psk_identity_len;
         }
 
-        if( psk_type != NULL )
-            *psk_type = MBEDTLS_SSL_TLS1_3_PSK_EXTERNAL;
         return( 0 );
     }