commit 86981955666dd9284213668de7e887009f5b2338
author XiaokangQian <xiaokang.qian@arm.com> Tue Jul 19 09:51:50 2022 +0000
committer Ronald Cron <ronald.cron@arm.com> Thu Jul 21 15:30:04 2022 +0200
tree 54a3f143ad0f6800b264aa9388dbb12f3ae21335
parent adab9a64400796fb53a1911dc2ec9e6a2b16450f

Address comments of various issues

Improve comments
Change coding style
Rename functions

Change-Id: Ia111aef303932cfeee693431c3d48f90342b32e5
Signed-off-by: XiaokangQian <xiaokang.qian@arm.com>

library/ssl_misc.h

diff --git a/library/ssl_misc.h b/library/ssl_misc.h
index f55dede..295ff9f 100644
--- a/library/ssl_misc.h
+++ b/library/ssl_misc.h
@@ -1336,9 +1336,6 @@
 void mbedtls_ssl_optimize_checksum( mbedtls_ssl_context *ssl,
                             const mbedtls_ssl_ciphersuite_t *ciphersuite_info );
 
-void mbedtls_ssl_add_hs_hdr_to_checksum( mbedtls_ssl_context *ssl,
-                                         unsigned hs_type,
-                                         size_t total_hs_len );
 /*
  * Update checksum of handshake messages.
  */
@@ -1347,6 +1344,10 @@
                                          unsigned char const *msg,
                                          size_t msg_len );
 
+void mbedtls_ssl_add_hs_hdr_to_checksum( mbedtls_ssl_context *ssl,
+                                         unsigned hs_type,
+                                         size_t total_hs_len );
+
 #if defined(MBEDTLS_KEY_EXCHANGE_SOME_PSK_ENABLED)
 #if !defined(MBEDTLS_USE_PSA_CRYPTO)
 MBEDTLS_CHECK_RETURN_CRITICAL
@@ -2426,6 +2427,7 @@
 /* Check if we have any PSK to offer, returns 0 if PSK is available.
  * Assign the psk and ticket if pointers are present.
  */
+MBEDTLS_CHECK_RETURN_CRITICAL
 int mbedtls_ssl_get_psk_to_offer(
         const mbedtls_ssl_context *ssl,
         int *psk_type,
@@ -2445,6 +2447,7 @@
  * \param[out]  binders_len Length of the binders to be written at the end of
  *                          the extension.
  */
+MBEDTLS_CHECK_RETURN_CRITICAL
 int mbedtls_ssl_tls13_write_pre_shared_key_ext_without_binders(
     mbedtls_ssl_context *ssl,
     unsigned char *buf, unsigned char *end,
@@ -2459,7 +2462,8 @@
  * \param[in]   buf     Base address of the buffer where to write the binders
  * \param[in]   end     End address of the buffer where to write the binders
  */
-int mbedtls_ssl_tls13_write_pre_shared_key_ext_binders(
+MBEDTLS_CHECK_RETURN_CRITICAL
+int mbedtls_ssl_tls13_write_binders_of_pre_shared_key_ext(
     mbedtls_ssl_context *ssl,
     unsigned char *buf, unsigned char *end );
 #endif /* MBEDTLS_KEY_EXCHANGE_SOME_PSK_ENABLED */