commit 811d8d462fed3892b11a095438d4993dc7168cd8
author Paul Elliott <paul.elliott@arm.com> Thu Apr 22 11:31:14 2021 +0100
committer Paul Elliott <paul.elliott@arm.com> Fri May 14 19:03:26 2021 +0100
tree 4f6574490e5b8afbeafb147bd52629905a5281a2
parent 5653da0201c19755fa3f2ced4d8d8eea681bfbc3

Fix incorrect enums being used

Fix memory leak due to aead_abort() using incorrect enums to identify
algorithm used. Fix incorrect return on failure to check tag on
aead_verify()

Signed-off-by: Paul Elliott <paul.elliott@arm.com>

library/psa_crypto_aead.c

diff --git a/library/psa_crypto_aead.c b/library/psa_crypto_aead.c
index f8cceae..e92dac5 100644
--- a/library/psa_crypto_aead.c
+++ b/library/psa_crypto_aead.c
@@ -948,7 +948,7 @@
     {
         if( do_tag_check && safer_memcmp(tag, check_tag, tag_length) != 0 )
         {
-            status = MBEDTLS_ERR_GCM_AUTH_FAILED;
+            status = PSA_ERROR_INVALID_SIGNATURE;
         }
     }
 
@@ -960,10 +960,10 @@
 /* Abort an AEAD operation */
 psa_status_t mbedtls_psa_aead_abort( psa_aead_operation_t *operation )
 {
-   switch( operation->alg )
+    switch( operation->alg )
     {
-#if defined(MBEDTLS_CCM_C)
-        case MBEDTLS_PSA_BUILTIN_ALG_CCM:
+#if defined(MBEDTLS_PSA_BUILTIN_ALG_CCM)
+        case PSA_ALG_CCM:
             mbedtls_ccm_free( &operation->ctx.ccm );
             break;
 #endif /* MBEDTLS_PSA_BUILTIN_ALG_CCM */
@@ -973,9 +973,9 @@
             break;
 #endif /* MBEDTLS_PSA_BUILTIN_ALG_GCM */
 #if defined(MBEDTLS_PSA_BUILTIN_ALG_CHACHA20_POLY1305)
-       case PSA_ALG_CHACHA20_POLY1305:
-           mbedtls_chachapoly_free( &operation->ctx.chachapoly );
-           break;
+        case PSA_ALG_CHACHA20_POLY1305:
+            mbedtls_chachapoly_free( &operation->ctx.chachapoly );
+            break;
 #endif /* MBEDTLS_PSA_BUILTIN_ALG_CHACHA20_POLY1305 */
     }