commit 7f5a31915b6e80731cbd4504746fcd925a5aab63
author Nir Sonnenschein <nir.sonnenschein@arm.com> Sun May 06 22:26:54 2018 +0300
committer itayzafrir <itay.zafrir@arm.com> Wed Sep 05 12:41:53 2018 +0300
tree 177534e71faed8fa4c1f80f2ef135b3fc199ae1c
parent 0f3bdbddeedee6f224662c19dbd5dea62c4b801d

code fixes for internal code review:

1. change to correct error code
2. removed unneeded comment

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index a18abcd..e24638a 100755
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -1367,7 +1367,7 @@
     (void) salt_length;
 
     if( key == 0 || key > MBEDTLS_PSA_KEY_SLOT_COUNT )
-        return( PSA_ERROR_EMPTY_SLOT );
+        return( PSA_ERROR_INVALID_ARGUMENT );
     slot = &global_data.key_slots[key];
     if( slot->type == PSA_KEY_TYPE_NONE )
         return( PSA_ERROR_EMPTY_SLOT );
@@ -1460,14 +1460,13 @@
     (void) salt_length;
 
     if( key == 0 || key > MBEDTLS_PSA_KEY_SLOT_COUNT )
-        return( PSA_ERROR_EMPTY_SLOT );
+        return( PSA_ERROR_INVALID_ARGUMENT );
     slot = &global_data.key_slots[key];
     if( slot->type == PSA_KEY_TYPE_NONE )
         return( PSA_ERROR_EMPTY_SLOT );
     if( ! PSA_KEY_TYPE_IS_KEYPAIR( slot->type ) )
         return( PSA_ERROR_INVALID_ARGUMENT );
 
-    // check output size?
 
 #if defined(MBEDTLS_RSA_C)
     if( slot->type == PSA_KEY_TYPE_RSA_KEYPAIR )