commit 6d81f7e1196faf6c0797110a272970c250fd55c6
author Steven Cooreman <steven.cooreman@silabs.com> Mon Sep 14 13:14:31 2020 +0200
committer Steven Cooreman <steven.cooreman@silabs.com> Mon Sep 14 17:00:47 2020 +0200
tree a5b7dbdef294be5e8165747e0af79d9072a79929
parent ef8575e1bff2c33a97169216170901025451014f

Final feedback from @ronald-cron-arm

Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 8383eae..931e2e9 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -4088,9 +4088,11 @@
                                                           alg );
 
     if( status == PSA_SUCCESS )
+    {
         /* Once the driver context is initialised, it needs to be freed using
         * psa_cipher_abort. Indicate this through setting alg. */
         operation->alg = alg;
+    }
 
     if( status != PSA_ERROR_NOT_SUPPORTED ||
         psa_key_lifetime_is_external( slot->attr.lifetime ) )
@@ -4491,10 +4493,7 @@
     else if( output_size >= *output_length )
         memcpy( output, temp_output_buffer, *output_length );
     else
-    {
         status = PSA_ERROR_BUFFER_TOO_SMALL;
-        goto exit;
-    }
 
 exit:
     if( operation->mbedtls_in_use == 1 )
@@ -4505,8 +4504,6 @@
     else
     {
         *output_length = 0;
-
-        mbedtls_platform_zeroize( temp_output_buffer, sizeof( temp_output_buffer ) );
         (void) psa_cipher_abort( operation );
 
         return( status );