commit 653481632edb5061345abe1afe8ee1c816449d36
author Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com> Thu Nov 18 11:57:07 2021 +0100
committer Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com> Tue Feb 22 13:26:46 2022 +0100
tree d2c9c7a0deb6ddbfba4c17414b34eda0a87efddb
parent d8cdcba970e9c2d813660dcfd9ad36ad3aecf39f

psa_generate_derived_ecc_key_helper: fix bugs found during testing

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 07c0bbd..bd6c84c 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -4872,6 +4872,7 @@
         mbedtls_ecc_group_of_psa( curve, bits, 0 );
 
     mbedtls_ecp_group ecp_group;
+    mbedtls_ecp_group_init( &ecp_group );
 
     if( ( status = mbedtls_ecp_group_load( &ecp_group, grp_id ) ) != 0 )
     {
@@ -4880,12 +4881,12 @@
     }
 
     /* N is the boundary of the private key domain. */
-    N = ecp_group.N;
+    MBEDTLS_MPI_CHK( mbedtls_mpi_copy( &N, &ecp_group.N ) );
     /* Let m be the bit size of N. */
     size_t m = ecp_group.nbits;
 
     size_t m_bytes = PSA_BITS_TO_BYTES( m );
-    if (*data != NULL)
+    if (*data == NULL)
         *data = mbedtls_calloc( 1, m_bytes );
     if( *data == NULL )
     {