commit 5f3f0d06e6734e78390a4e58a1c5af139a13c6e1
author Dave Rodgman <dave.rodgman@arm.com> Thu Aug 11 14:38:26 2022 +0100
committer Dave Rodgman <dave.rodgman@arm.com> Tue Aug 30 10:25:45 2022 +0100
tree 426b81c23ae6bfbbf3c72ef9d97d274ce26d80f7
parent ec9f6b4de1e50289588b9794c5e0cad89dc4d471

Address minor review comments

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

library/x509write_crt.c

diff --git a/library/x509write_crt.c b/library/x509write_crt.c
index d0aaa9f..21e36b5 100644
--- a/library/x509write_crt.c
+++ b/library/x509write_crt.c
@@ -303,7 +303,10 @@
     unsigned char *c = buf + sizeof(buf);
     int ret;
     size_t len = 0;
-    const mbedtls_asn1_sequence *last_ext = 0, *ext;
+    const mbedtls_asn1_sequence *last_ext = NULL;
+    mbedtls_asn1_sequence *ext;
+
+    memset( buf, 0, sizeof(buf) );
 
     /* We need at least one extension: SEQUENCE SIZE (1..MAX) OF KeyPurposeId */
     if( exts == NULL )
@@ -324,14 +327,10 @@
     MBEDTLS_ASN1_CHK_ADD( len, mbedtls_asn1_write_len( &c, buf, len ) );
     MBEDTLS_ASN1_CHK_ADD( len, mbedtls_asn1_write_tag( &c, buf, MBEDTLS_ASN1_CONSTRUCTED | MBEDTLS_ASN1_SEQUENCE ) );
 
-    ret = mbedtls_x509write_crt_set_extension( ctx,
+    return mbedtls_x509write_crt_set_extension( ctx,
                          MBEDTLS_OID_EXTENDED_KEY_USAGE,
                          MBEDTLS_OID_SIZE( MBEDTLS_OID_EXTENDED_KEY_USAGE ),
                          1, c, len );
-    if( ret != 0 )
-        return( ret );
-
-    return( 0 );
 }
 
 int mbedtls_x509write_crt_set_ns_cert_type( mbedtls_x509write_cert *ctx,

programs/x509/cert_write.c

diff --git a/programs/x509/cert_write.c b/programs/x509/cert_write.c
index bffc4ab..dbdc4ee 100644
--- a/programs/x509/cert_write.c
+++ b/programs/x509/cert_write.c
@@ -1,4 +1,3 @@
-
 /*
  *  Certificate generation and signing
  *
@@ -832,7 +831,7 @@
         ret = mbedtls_x509write_crt_set_ns_cert_type( &crt, opt.ns_cert_type );
         if( ret != 0 )
         {
-            mbedtls_strerror( ret, buf, 1024 );
+            mbedtls_strerror( ret, buf, sizeof(buf) );
             mbedtls_printf( " failed\n  !  mbedtls_x509write_crt_set_ns_cert_type "
                             "returned -0x%04x - %s\n\n", (unsigned int) -ret, buf );
             goto exit;

tests/suites/test_suite_x509write.function

diff --git a/tests/suites/test_suite_x509write.function b/tests/suites/test_suite_x509write.function
index 5781fe0..2e59658 100644
--- a/tests/suites/test_suite_x509write.function
+++ b/tests/suites/test_suite_x509write.function
@@ -350,19 +350,24 @@
         if( strcmp( ext_key_usage, "NULL" ) != 0 )
         {
             mbedtls_asn1_sequence exts[2];
-            memset(exts, 0, sizeof(exts));
-#define SET_OID(x, oid) \
-    do { x.len = MBEDTLS_OID_SIZE(oid); x.p = (unsigned char*)oid; \
-         x.tag = MBEDTLS_ASN1_OID; } while( 0 )
+            memset( exts, 0, sizeof(exts) );
+
+#define SET_OID(x, oid)                \
+    do {                               \
+        x.len = MBEDTLS_OID_SIZE(oid); \
+        x.p   = (unsigned char*)oid;   \
+        x.tag = MBEDTLS_ASN1_OID;      \
+    } while( 0 )
+
             if( strcmp( ext_key_usage, "serverAuth" ) == 0 )
             {
-              SET_OID( exts[0].buf, MBEDTLS_OID_SERVER_AUTH );
+                SET_OID( exts[0].buf, MBEDTLS_OID_SERVER_AUTH );
             }
             else if( strcmp( ext_key_usage, "codeSigning,timeStamping" ) == 0 )
             {
-              SET_OID( exts[0].buf, MBEDTLS_OID_CODE_SIGNING );
-              exts[0].next = &exts[1];
-              SET_OID( exts[1].buf, MBEDTLS_OID_TIME_STAMPING );
+                SET_OID( exts[0].buf, MBEDTLS_OID_CODE_SIGNING );
+                exts[0].next = &exts[1];
+                SET_OID( exts[1].buf, MBEDTLS_OID_TIME_STAMPING );
             }
             TEST_ASSERT( mbedtls_x509write_crt_set_ext_key_usage( &crt, exts ) == 0 );
         }