Remove mostly-redundant test build
component_test_CID_no_debug was added specifically to be a non-regression
test for https://github.com/Mbed-TLS/mbedtls/issues/3998. Running compat.sh
in the newly introduced config-ccm-psk-dtls1_2.h is also a non-regression
test for that bug. Therefore component_test_CID_no_debug is redundant for
its primary purpose.
Of course every configuration is different, but the additional coverage from
component_test_CID_no_debug is minimal, unlike config-ccm-psk-dtls1_2.h
which is a plausible real-world configuration.
In mbedtls-2.28, component_test_CID_no_debug was never added, and running
the unit tests in that configuration does not trigger the #3998 bug, only
compat.sh does. So, rather than backport component_test_CID_no_debug to
2.28.2, I am removing it from 3.2.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh
index 0c2d9dd..c31b3ee 100755
--- a/tests/scripts/all.sh
+++ b/tests/scripts/all.sh
@@ -2239,18 +2239,6 @@
tests/compat.sh
}
-component_test_CID_no_debug() {
- msg "build: Connection ID enabled, debug disabled"
- scripts/config.py unset MBEDTLS_DEBUG_C
- scripts/config.py set MBEDTLS_SSL_DTLS_CONNECTION_ID
-
- CC=gcc cmake .
- make
-
- msg "test: Connection ID enabled, debug disabled"
- make test
-}
-
component_test_ssl_alloc_buffer_and_mfl () {
msg "build: default config with memory buffer allocator and MFL extension"
scripts/config.py set MBEDTLS_MEMORY_BUFFER_ALLOC_C