commit 4bf4473ef0960fd221a739a187a8f1ec3abb970f
author Gilles Peskine <gilles.peskine@arm.com> Thu Dec 21 12:09:23 2023 +0000
committer GitHub <noreply@github.com> Thu Dec 21 12:09:23 2023 +0000
tree 0d5a8cf216e09424bae9efe474896c4d67d3efc2
parent 0e6fdc4f1d1bf7093e8a8f43e3cfbc742f1e8b2b
parent 3b9de382084bb7a8b5f8735457844b0048e51748

Merge pull request #8633 from Wenxing-hou/clear_clienthello_comment

Make clienthello comment clear

library/ssl_tls12_server.c

diff --git a/library/ssl_tls12_server.c b/library/ssl_tls12_server.c
index f905e65..5a9f6ca 100644
--- a/library/ssl_tls12_server.c
+++ b/library/ssl_tls12_server.c
@@ -1128,11 +1128,11 @@
     msg_len -= mbedtls_ssl_hs_hdr_len(ssl);
 
     /*
-     * ClientHello layer:
+     * ClientHello layout:
      *     0  .   1   protocol version
      *     2  .  33   random bytes (starting with 4 bytes of Unix time)
-     *    34  .  35   session id length (1 byte)
-     *    35  . 34+x  session id
+     *    34  .  34   session id length (1 byte)
+     *    35  . 34+x  session id, where x = session id length from byte 34
      *   35+x . 35+x  DTLS only: cookie length (1 byte)
      *   36+x .  ..   DTLS only: cookie
      *    ..  .  ..   ciphersuite list length (2 bytes)