commit 476c1198e8a5e31b9674da98e58061a84a677711
author Waleed Elmelegy <waleed.elmelegy@arm.com> Thu Oct 12 14:19:25 2023 +0100
committer Waleed Elmelegy <waleed.elmelegy@arm.com> Thu Oct 12 14:19:25 2023 +0100
tree d32bc88b194e3d57f2ea4be9d7195e845f07f94e
parent e7ebec6723b61bd54800f649b1391e980edf2fbd

Fix possible NULL dereference issue in X509 cert_write program

Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com>

programs/x509/cert_write.c

diff --git a/programs/x509/cert_write.c b/programs/x509/cert_write.c
index 40b1871..5e0d608 100644
--- a/programs/x509/cert_write.c
+++ b/programs/x509/cert_write.c
@@ -583,6 +583,9 @@
 
                 if ((subtype_value = strchr(q, ':')) != NULL) {
                     *subtype_value++ = '\0';
+                } else {
+                    mbedtls_printf("Invalid argument for option SAN: Entry should be seperated by a colon\n");
+                    goto usage;
                 }
                 if (strcmp(q, "RFC822") == 0) {
                     cur->node.type = MBEDTLS_X509_SAN_RFC822_NAME;