commit 1f62714db86e6afc1791b6b31947c223905eeb38
author Andy Gross <andy.gross@linaro.org> Wed Jan 30 10:25:53 2019 -0600
committer Paul Sokolovsky <paul.sokolovsky@linaro.org> Fri Aug 30 14:48:36 2019 +0300
tree ffdcf790f5091e65aa2c6f3558a92fb001bf4a86
parent 3ec504738ec6810ec57821aec90d93e2b02ecebe

Fix uninitialized variable in x509_crt

This patch fixes an issue we encountered with more stringent compiler
warnings.  The signature_is_good variable has a possibility of being
used uninitialized.  This patch moves the use of the variable to a
place where it cannot be used while uninitialized.

Signed-off-by: Andy Gross <andy.gross@linaro.org>

library/x509_crt.c

diff --git a/library/x509_crt.c b/library/x509_crt.c
index b2c19db..48f244e 100644
--- a/library/x509_crt.c
+++ b/library/x509_crt.c
@@ -2611,15 +2611,13 @@
             continue;
         }
 
+        *r_parent = parent;
+        *r_signature_is_good = signature_is_good;
+
         break;
     }
 
-    if( parent != NULL )
-    {
-        *r_parent = parent;
-        *r_signature_is_good = signature_is_good;
-    }
-    else
+    if( parent == NULL )
     {
         *r_parent = fallback_parent;
         *r_signature_is_good = fallback_signature_is_good;