commit d5d983e16830b1a131b08c8f7746398a256a7e58
author Gilles Peskine <Gilles.Peskine@arm.com> Fri Jun 15 14:05:10 2018 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> Fri Jun 15 14:05:10 2018 +0200
tree 6f031e02c9a2599730e6664430ae95221bffe32a
parent ace05929e87817324aed83688f4b424780bf70cf

ssl_server2: handle mbedtls_x509_dn_gets failure

If mbedtls_x509_dn_gets fails, the server could end up calling printf
on an uninitialized buffer. Check if the function succeeds. Found by
Coverity.

programs/ssl/ssl_server2.c

diff --git a/programs/ssl/ssl_server2.c b/programs/ssl/ssl_server2.c
index 81041c4..3a413ad 100644
--- a/programs/ssl/ssl_server2.c
+++ b/programs/ssl/ssl_server2.c
@@ -962,8 +962,9 @@
 
     {
         char dn[100];
-        mbedtls_x509_dn_gets( dn, sizeof( dn ), &cert->subject );
-        mbedtls_printf( "Async %s callback: looking for DN=%s\n", op_name, dn );
+        if( mbedtls_x509_dn_gets( dn, sizeof( dn ), &cert->subject ) > 0 )
+            mbedtls_printf( "Async %s callback: looking for DN=%s\n",
+                            op_name, dn );
     }
 
     /* Look for a private key that matches the public key in cert.