commit cf975a3857e72ad9a0b38ada9a3d3d497f9cf752
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Fri Jan 24 19:28:43 2014 +0100
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Mon Jun 02 16:12:46 2014 +0200
tree 66d4655d2f2c9024d4bd0a238cf8efc894f15b63
parent 39868ee3011bd60d7ecd2ee8f383b3b167680801

Factor out some common code

library/x509_crl.c

diff --git a/library/x509_crl.c b/library/x509_crl.c
index 6c9ec59..f2bd0c1 100644
--- a/library/x509_crl.c
+++ b/library/x509_crl.c
@@ -397,35 +397,16 @@
         return( POLARSSL_ERR_X509_UNKNOWN_VERSION );
     }
 
-    if( ( ret = x509_get_sig_alg( &crl->sig_oid1, &crl->sig_md,
-                                  &crl->sig_pk ) ) != 0 )
+    if( ( ret = x509_get_sig_alg( &crl->sig_oid1, &sig_params,
+                                  &crl->sig_md, &crl->sig_pk ) ) != 0 )
     {
         x509_crl_free( crl );
         return( POLARSSL_ERR_X509_UNKNOWN_SIG_ALG );
     }
 
 #if defined(POLARSSL_RSASSA_PSS_CERTIFICATES)
-    if( crl->sig_pk == POLARSSL_PK_RSASSA_PSS )
-    {
-        int salt_len, trailer_field;
-        md_type_t mgf_md;
-
-        /* Make sure params are valid */
-        ret = x509_get_rsassa_pss_params( &sig_params,
-                &crl->sig_md, &mgf_md, &salt_len, &trailer_field );
-        if( ret != 0 )
-            return( ret );
-
-        memcpy( &crl->sig_params, &sig_params, sizeof( x509_buf ) );
-    }
-    else
+    memcpy( &crl->sig_params, &sig_params, sizeof( x509_buf ) );
 #endif
-    {
-        /* Make sure parameters are absent or NULL */
-        if( ( sig_params.tag != ASN1_NULL && sig_params.tag != 0 ) ||
-              sig_params.len != 0 )
-        return( POLARSSL_ERR_X509_INVALID_ALG );
-    }
 
     /*
      * issuer               Name