commit 5ca6547b77f93c39ba673b8a4f5d36cd1bf701bb
author Nir Sonnenschein <nir.sonnenschein@arm.com> Sun Jun 17 14:03:40 2018 +0300
committer itayzafrir <itay.zafrir@arm.com> Wed Sep 12 16:13:49 2018 +0300
tree d55c2b07270befe3a44cc1d93c359391bed3dcf2
parent caec7f0c49630d25570c2d6656e85dbdef45e1e6

Renamed hmac_ctx to opad and removed null check.

this array is now part of the struct and not dynamically allocated
so it can't be null.

include/psa/crypto_struct.h

diff --git a/include/psa/crypto_struct.h b/include/psa/crypto_struct.h
index 60c44fb..f554b6e 100644
--- a/include/psa/crypto_struct.h
+++ b/include/psa/crypto_struct.h
@@ -88,7 +88,7 @@
         /** The hash context. */
         struct psa_hash_operation_s hash_ctx;
         /** The HMAC part of the context. */
-        uint8_t hmac_ctx[PSA_CRYPTO_MD_BLOCK_SIZE];
+        uint8_t opad[PSA_CRYPTO_MD_BLOCK_SIZE];
 } psa_hmac_internal_data;
 
 

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 60a1197..e51de04 100755
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -1018,11 +1018,8 @@
                     return( PSA_ERROR_NOT_SUPPORTED );
 
                 psa_hash_abort( &operation->ctx.hmac.hash_ctx );
-                if ( operation->ctx.hmac.hmac_ctx != NULL )
-                {
-                    mbedtls_zeroize( operation->ctx.hmac.hmac_ctx,
+                mbedtls_zeroize( operation->ctx.hmac.opad,
                                      block_size);
-                }
             }
             else
 #endif /* MBEDTLS_MD_C */
@@ -1065,7 +1062,7 @@
                            psa_algorithm_t alg )
 {
     unsigned char ipad[PSA_CRYPTO_MD_BLOCK_SIZE];
-    unsigned char *opad = operation->ctx.hmac.hmac_ctx;
+    unsigned char *opad = operation->ctx.hmac.opad;
     size_t i;
     size_t block_size =
         PSA_HASH_BLOCK_SIZE( ( PSA_ALG_HMAC_HASH( alg ) ) );
@@ -1282,7 +1279,7 @@
             if( PSA_ALG_IS_HMAC( operation->alg ) )
             {
                 unsigned char tmp[MBEDTLS_MD_MAX_SIZE];
-                unsigned char *opad = operation->ctx.hmac.hmac_ctx;
+                unsigned char *opad = operation->ctx.hmac.opad;
                 size_t hash_size = 0;
                 unsigned int block_size =
                 PSA_HASH_BLOCK_SIZE( ( PSA_ALG_HMAC_HASH( operation->alg ) ) );