commit 39eda87382100565a890182ff9dffedd640cfa18
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Aug 15 13:00:33 2017 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Aug 15 13:00:33 2017 +0200
tree e0f75245f2e823cdff762c9cb2fd2cfae9736981
parent 6b7301c8722e9fce24f1e17e3b716d15cca618d5

Make more auto variables const

That way we know we don't have to worry about saving and restoring their
value.

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index 221071b..48bb336 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -4313,8 +4313,15 @@
 {
     int ret = MBEDTLS_ERR_SSL_FEATURE_UNAVAILABLE;
     size_t i, n;
-    const mbedtls_ssl_ciphersuite_t *ciphersuite_info = ssl->transform_negotiate->ciphersuite_info;
-    int authmode = ssl->conf->authmode;
+    const mbedtls_ssl_ciphersuite_t * const ciphersuite_info =
+          ssl->transform_negotiate->ciphersuite_info;
+#if defined(MBEDTLS_SSL_SRV_C) && defined(MBEDTLS_SSL_SERVER_NAME_INDICATION)
+    const int authmode = ssl->handshake->sni_authmode != MBEDTLS_SSL_VERIFY_UNSET
+                       ? ssl->handshake->sni_authmode
+                       : ssl->conf->authmode;
+#else
+    const int authmode = ssl->conf->authmode;
+#endif
     uint8_t alert;
 
     MBEDTLS_SSL_DEBUG_MSG( 2, ( "=> parse certificate" ) );
@@ -4338,11 +4345,6 @@
         return( 0 );
     }
 
-#if defined(MBEDTLS_SSL_SERVER_NAME_INDICATION)
-    if( ssl->handshake->sni_authmode != MBEDTLS_SSL_VERIFY_UNSET )
-        authmode = ssl->handshake->sni_authmode;
-#endif
-
     if( ssl->conf->endpoint == MBEDTLS_SSL_IS_SERVER &&
         authmode == MBEDTLS_SSL_VERIFY_NONE )
     {