commit 21298a20c4eab443694a7d34bfb1e3a5a41f01af
author k-stachowiak <krzysiek.stachowiak@gmail.com> Thu Dec 13 17:11:58 2018 +0100
committer k-stachowiak <krzysiek.stachowiak@gmail.com> Wed Dec 19 17:32:19 2018 +0100
tree 7af8ef4b946278ca2aa86186d1c51b0aa4c60558
parent 9af22e479072bedd1f50b88b26a6dca50d754c7d

Improve parameter validation in mbedtls_gcm_free()

include/mbedtls/gcm.h

diff --git a/include/mbedtls/gcm.h b/include/mbedtls/gcm.h
index 6a49c39..cf8bed9 100644
--- a/include/mbedtls/gcm.h
+++ b/include/mbedtls/gcm.h
@@ -298,7 +298,7 @@
  *                  cipher sub-context.
  *
  * \param ctx       The GCM context to clear. If this is \c NULL, the call has
- *                  no effect.
+ *                  no effect. Otherwise, this must be initialized.
  */
 void mbedtls_gcm_free( mbedtls_gcm_context *ctx );
 

library/gcm.c

diff --git a/library/gcm.c b/library/gcm.c
index 3e41eda..675926a 100644
--- a/library/gcm.c
+++ b/library/gcm.c
@@ -541,9 +541,8 @@
 
 void mbedtls_gcm_free( mbedtls_gcm_context *ctx )
 {
-    if( ctx == NULL ) {
+    if( ctx == NULL )
         return;
-    }
     mbedtls_cipher_free( &ctx->cipher_ctx );
     mbedtls_platform_zeroize( ctx, sizeof( mbedtls_gcm_context ) );
 }