fix(clang15): remove unused var and fix func prototypes
Building with clang15 requires that function prototypes
must include void as parameter if there are no parameters.
Variables that are set but not used produce an error.
This patch addresses occurrences of these two issues.
Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Change-Id: I676242c224e12b17ae9eba52d54c2becace50e62
diff --git a/test/hftest/common.c b/test/hftest/common.c
index 8573eca..d3c57c6 100644
--- a/test/hftest/common.c
+++ b/test/hftest/common.c
@@ -67,7 +67,6 @@
{
const char *suite = NULL;
size_t i;
- size_t suites_in_image = 0;
size_t tests_in_suite = 0;
HFTEST_LOG("{");
@@ -81,7 +80,6 @@
HFTEST_LOG(" },");
}
/* Move onto new suite. */
- ++suites_in_image;
suite = test->suite;
tests_in_suite = 0;
HFTEST_LOG(" {");
diff --git a/test/hftest/service_common.c b/test/hftest/service_common.c
index f606bf5..69cc1e7 100644
--- a/test/hftest/service_common.c
+++ b/test/hftest/service_common.c
@@ -151,7 +151,7 @@
}
}
-ffa_vm_id_t hftest_get_dir_req_source_id()
+ffa_vm_id_t hftest_get_dir_req_source_id(void)
{
struct hftest_context *ctx = hftest_get_context();
return ctx->dir_req_source_id;
diff --git a/test/inc/test/hftest.h b/test/inc/test/hftest.h
index 3366f5a..2eaa42d 100644
--- a/test/inc/test/hftest.h
+++ b/test/inc/test/hftest.h
@@ -165,7 +165,7 @@
/*
* Return the field tracking the source of the direct request message.
*/
-ffa_vm_id_t hftest_get_dir_req_source_id();
+ffa_vm_id_t hftest_get_dir_req_source_id(void);
/*
* Set the field tracking the source of the direct request message.
diff --git a/test/vmapi/arch/aarch64/gicv3/gicv3_setup.c b/test/vmapi/arch/aarch64/gicv3/gicv3_setup.c
index e680e3f..8adb00c 100644
--- a/test/vmapi/arch/aarch64/gicv3/gicv3_setup.c
+++ b/test/vmapi/arch/aarch64/gicv3/gicv3_setup.c
@@ -25,7 +25,7 @@
HFTEST_LOG("primary IRQ %d ended\n", interrupt_id);
}
-void gicv3_system_setup()
+void gicv3_system_setup(void)
{
const uint32_t mode = MM_MODE_R | MM_MODE_W | MM_MODE_D;
hftest_mm_identity_map((void *)GICD_BASE, PAGE_SIZE, mode);
diff --git a/test/vmapi/arch/aarch64/gicv3/inc/gicv3.h b/test/vmapi/arch/aarch64/gicv3/inc/gicv3.h
index 28bf29d..dede047 100644
--- a/test/vmapi/arch/aarch64/gicv3/inc/gicv3.h
+++ b/test/vmapi/arch/aarch64/gicv3/inc/gicv3.h
@@ -30,4 +30,4 @@
extern volatile uint32_t last_interrupt_id;
-void gicv3_system_setup();
+void gicv3_system_setup(void);
diff --git a/test/vmapi/arch/aarch64/gicv3/timer_secondary.c b/test/vmapi/arch/aarch64/gicv3/timer_secondary.c
index c79dbe8..e3ee243 100644
--- a/test/vmapi/arch/aarch64/gicv3/timer_secondary.c
+++ b/test/vmapi/arch/aarch64/gicv3/timer_secondary.c
@@ -55,7 +55,7 @@
EXPECT_FFA_ERROR(ffa_rx_release(), FFA_DENIED);
}
-static void timer_busywait_secondary()
+static void timer_busywait_secondary(void)
{
const char message[] = "loop 0099999";
const char expected_response[] = "Got IRQ 03.";
diff --git a/test/vmapi/el0_partitions/services/interruptible.c b/test/vmapi/el0_partitions/services/interruptible.c
index 85c97dc..80fc61b 100644
--- a/test/vmapi/el0_partitions/services/interruptible.c
+++ b/test/vmapi/el0_partitions/services/interruptible.c
@@ -44,7 +44,7 @@
* Try to receive a message from the mailbox, blocking if necessary, and
* retrying if interrupted.
*/
-static struct ffa_value mailbox_receive_retry()
+static struct ffa_value mailbox_receive_retry(void)
{
struct ffa_value received;
diff --git a/test/vmapi/el0_partitions/services/interruptible_echo.c b/test/vmapi/el0_partitions/services/interruptible_echo.c
index 958d750..55511d6 100644
--- a/test/vmapi/el0_partitions/services/interruptible_echo.c
+++ b/test/vmapi/el0_partitions/services/interruptible_echo.c
@@ -33,7 +33,7 @@
* Try to receive a message from the mailbox, blocking if necessary, and
* retrying if interrupted.
*/
-static struct ffa_value mailbox_receive_retry()
+static struct ffa_value mailbox_receive_retry(void)
{
struct ffa_value received;
diff --git a/test/vmapi/primary_with_secondaries/services/interruptible.c b/test/vmapi/primary_with_secondaries/services/interruptible.c
index 594f28a..3888bf8 100644
--- a/test/vmapi/primary_with_secondaries/services/interruptible.c
+++ b/test/vmapi/primary_with_secondaries/services/interruptible.c
@@ -41,7 +41,7 @@
* Try to receive a message from the mailbox, blocking if necessary, and
* retrying if interrupted.
*/
-struct ffa_value mailbox_receive_retry()
+struct ffa_value mailbox_receive_retry(void)
{
struct ffa_value received;