fix: fix build with clang-17
Target triple `aarch64-none-eabi` was incorrect, but old versions of
clang accepted it anyway. clang-17 is stricter and does not accept it
(https://releases.llvm.org/17.0.1/tools/clang/docs/ReleaseNotes.html#arm-and-aarch64-support).
The correct replacement is `aarch64-none-elf`.
The local variable `struct ffa_partition_rxtx_header header` was
assigned a different address that was not aligned to 8 bytes by
clang-17, and so `memcpy_trapped` would fail. This is fixed by
annotating it with `alignas(8)`.
Fix new warnings from `clang-tidy`.
Ignore `misc-include-cleaner` warning from `clang-tidy`, because it
produces a lot of incorrect warnings.
Apply `make format`.
Change-Id: I605e23ce258de9bfd49d717ef5864292a30235e1
Signed-off-by: Karl Meakin <karl.meakin@arm.com>
diff --git a/src/ffa_memory.c b/src/ffa_memory.c
index 92dee8f..27e3b56 100644
--- a/src/ffa_memory.c
+++ b/src/ffa_memory.c
@@ -378,6 +378,8 @@
break;
case FFA_DATA_ACCESS_RESERVED:
panic("Tried to convert FFA_DATA_ACCESS_RESERVED.");
+ default:
+ panic("Unknown data access %#x\n", permissions.data_access);
}
switch (permissions.instruction_access) {
@@ -391,6 +393,9 @@
break;
case FFA_INSTRUCTION_ACCESS_RESERVED:
panic("Tried to convert FFA_INSTRUCTION_ACCESS_RESVERVED.");
+ default:
+ panic("Unknown instruction access %#x\n",
+ permissions.instruction_access);
}
/* Set the security state bit if necessary. */
@@ -487,8 +492,9 @@
return FFA_VERSION_1_1;
case sizeof(struct ffa_memory_access):
return FFA_VERSION_1_2;
+ default:
+ return 0;
}
- return 0;
}
/**
@@ -2383,6 +2389,10 @@
memory_region->flags |=
FFA_MEMORY_REGION_TRANSACTION_TYPE_DONATE;
break;
+ default:
+ dlog_verbose("Unknown share func %#x (%s)\n", share_func,
+ ffa_func_name(share_func));
+ return ffa_error(FFA_INVALID_PARAMETERS);
}
share_states = share_states_lock();