commit 801f8ef24a20e97b8f10c21c48907d82800c49dc
author Daniel Boulby <daniel.boulby@arm.com> Mon Jun 27 14:21:01 2022 +0100
committer Olivier Deprez <olivier.deprez@arm.com> Thu Aug 04 13:25:26 2022 +0200
tree d366a849d3b7f23c7f35c04836239d15e58cf241
parent ecd35ca5b2bc551b43669168157b30f74153906d

feat(manifest): check interrupt IDs are unique

Add a checks to prevent two endpoints from declaring the same
interrupt ID resource for a device peripheral.

Also add macros used to access the bitmask that tracks
interrupts.

Signed-off-by: Daniel Boulby <daniel.boulby@arm.com>
Change-Id: I5074e8d4209588a6c8f62ee06e0eb05b20cac387

src/api.c

diff --git a/src/api.c b/src/api.c
index ca39086..788db42 100644
--- a/src/api.c
+++ b/src/api.c
@@ -607,9 +607,8 @@
 				    struct vcpu **next)
 {
 	struct vcpu *target_vcpu = target_locked.vcpu;
-	uint32_t intid_index = intid / INTERRUPT_REGISTER_BITS;
-	uint32_t intid_shift = intid % INTERRUPT_REGISTER_BITS;
-	uint32_t intid_mask = 1U << intid_shift;
+	uint32_t intid_index = INTID_INDEX(intid);
+	uint32_t intid_mask = INTID_MASK(1U, intid);
 	int64_t ret = 0;
 
 	/*
@@ -625,7 +624,7 @@
 
 	/* Increment the count. */
 	if ((target_vcpu->interrupts.interrupt_type[intid_index] &
-	     intid_mask) == (INTERRUPT_TYPE_IRQ << intid_shift)) {
+	     intid_mask) == INTID_MASK(INTERRUPT_TYPE_IRQ, intid)) {
 		vcpu_irq_count_increment(target_locked);
 	} else {
 		vcpu_fiq_count_increment(target_locked);
@@ -1818,9 +1817,8 @@
 			     enum interrupt_type type, struct vcpu *current)
 {
 	struct vcpu_locked current_locked;
-	uint32_t intid_index = intid / INTERRUPT_REGISTER_BITS;
-	uint32_t intid_shift = intid % INTERRUPT_REGISTER_BITS;
-	uint32_t intid_mask = 1U << intid_shift;
+	uint32_t intid_index = INTID_INDEX(intid);
+	uint32_t intid_mask = INTID_MASK(1U, intid);
 
 	if (intid >= HF_NUM_INTIDS) {
 		return -1;
@@ -1845,7 +1843,7 @@
 		    intid_mask) {
 			if ((current->interrupts.interrupt_type[intid_index] &
 			     intid_mask) ==
-			    (INTERRUPT_TYPE_IRQ << intid_shift)) {
+			    INTID_MASK(INTERRUPT_TYPE_IRQ, intid)) {
 				vcpu_irq_count_increment(current_locked);
 			} else {
 				vcpu_fiq_count_increment(current_locked);
@@ -1862,7 +1860,7 @@
 		    intid_mask) {
 			if ((current->interrupts.interrupt_type[intid_index] &
 			     intid_mask) ==
-			    (INTERRUPT_TYPE_IRQ << intid_shift)) {
+			    INTID_MASK(INTERRUPT_TYPE_IRQ, intid)) {
 				vcpu_irq_count_decrement(current_locked);
 			} else {
 				vcpu_fiq_count_decrement(current_locked);