chore(logs): clean up logs for aborted VMs
When an SP was attempted to be run via ffa_run or direct
messsaging interfaces a check is performed by reading the vm->aborting
flag. Previously, a log stating "Aborting VM" was printed along with
this check. This can become redundant if multiple requests to an
aborted VM are made. Instead, print "Aborting" message only when
setting the VM abort flag and print a more specific error message when
check is performed and verbose logs are set.
Also add flag to sp_boot_next parameters to indicate whether previous
SP was initialized successfully or not and prevent printing
"Initialized VM" when SP was actually aborted.
Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Change-Id: I84c50c2b11aef12544cfcc66999b1aedfdaad781
diff --git a/src/api.c b/src/api.c
index e5e9458..97bce2e 100644
--- a/src/api.c
+++ b/src/api.c
@@ -1074,8 +1074,8 @@
if (atomic_load_explicit(&vcpu->vm->aborting, memory_order_relaxed)) {
if (vcpu->state != VCPU_STATE_ABORTED) {
- dlog_notice("Aborting VM %#x vCPU %u\n", vcpu->vm->id,
- vcpu_index(vcpu));
+ dlog_verbose("VM %#x was aborted, cannot run vCPU %u\n",
+ vcpu->vm->id, vcpu_index(vcpu));
vcpu->state = VCPU_STATE_ABORTED;
}
*run_ret = ffa_error(FFA_ABORTED);
@@ -2713,9 +2713,10 @@
if (atomic_load_explicit(&receiver_vcpu->vm->aborting,
memory_order_relaxed)) {
if (receiver_vcpu->state != VCPU_STATE_ABORTED) {
- dlog_notice("Aborting VM %#x vCPU %u\n",
- receiver_vcpu->vm->id,
- vcpu_index(receiver_vcpu));
+ dlog_verbose(
+ "Receiver VM %#x aborted, cannot run vCPU %u\n",
+ receiver_vcpu->vm->id,
+ vcpu_index(receiver_vcpu));
receiver_vcpu->state = VCPU_STATE_ABORTED;
}