Edit Repo Config
Change-Id: I6cf4dea3f75a6ea97c9b812fb459014f99a7c6c8
Signed-off-by: György Szing <gyorgy.szing@arm.com>
diff --git a/project.config b/project.config
index d2e8282..542f8e2 100644
--- a/project.config
+++ b/project.config
@@ -101,7 +101,7 @@
# In addition, define our 2 custom labels for code review.
# These influence whether a patch is submittable.
[label "Code-Owner-Review"]
- function = MaxWithBlock
+ function = NoBlock
value = -1 I would prefer this is not merged as is
value = 0 No score
value = +1 Looks good to me
@@ -109,7 +109,7 @@
copyCondition = changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
[label "Maintainer-Review"]
- function = MaxWithBlock
+ function = NoBlock
value = -1 I would prefer this is not merged as is
value = 0 No score
value = +1 Looks good to me
@@ -117,9 +117,24 @@
copyCondition = changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
[label "Verified"]
- function = MaxWithBlock
+ function = NoBlock
value = -1 Fails
value = 0 No score
value = +1 Verified
defaultValue = 0
copyCondition = changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
+
+[submit-requirement "Code-Review"]
+ description = Code review
+ submittableIf = label:Code-Review=MAX,user=non_uploader -label:Code-Review=MIN
+ canOverrideInChildProjects = true
+
+[submit-requirement "Code-Owner-or-Maintainer-Review"]
+ description = Code Owner or Maintainr Review
+ submittableIf = (label:Maintainer-Review=MAX,count>1 OR label:Code-Owner-Review=MAX,count>1) AND (-label:Maintainer-Review=MIN OR label:Code-Owner-Review=MIN)
+ canOverrideInChildProjects = true
+
+[submit-requirement "Verified"]
+ description = Static and dynamic quality check
+ submittableIf = label:Verified=MAX,count>1 -label:Verified=MIN
+ canOverrideInChildProjects = true