commit e95902bcdebb8f1729043b8ea7cdf3616bb5af80
author Chuyue Luo <Chuyue.Luo@arm.com> Tue Oct 17 15:46:25 2023 +0100
committer Chuyue Luo <Chuyue.Luo@arm.com> Tue Oct 31 16:02:47 2023 +0000
tree 3315d9ec640a97b7bb5caf827917fe53538eec7b
parent ddccbae53ff0e8f42cee11416aaed3bb304e0c06

fix(lib): clang-tidy macro parentheses warnings

This patch encloses macro arguments in parentheses, as advised by the
clang-tidy bugprone-macro-parentheses check.

Signed-off-by: Chuyue Luo <Chuyue.Luo@arm.com>
Change-Id: Ie064f565d2bd52d324630c3469d2ee272324944a

lib/common/include/utils_def.h

diff --git a/lib/common/include/utils_def.h b/lib/common/include/utils_def.h
index 5569675..353c088 100644
--- a/lib/common/include/utils_def.h
+++ b/lib/common/include/utils_def.h
@@ -69,14 +69,14 @@
 	(sizeof(a) / sizeof((a)[0]))
 
 #define ARRAY_LEN(_a)	\
-	((sizeof(_a) / sizeof(_a[0])) + CHECK_TYPE_IS_ARRAY(_a))
+	((sizeof(_a) / sizeof((_a)[0])) + CHECK_TYPE_IS_ARRAY(_a))
 
 /*
  * Macro checks types of array and variable/value to write
  * and reports compilation error if they mismatch.
  */
 #define CHECK_ARRAY_TYPE(_a, _v)	\
-	_Static_assert(__builtin_types_compatible_p(typeof(_a[0]), typeof(_v)), \
+	_Static_assert(__builtin_types_compatible_p(typeof((_a)[0]), typeof(_v)), \
 	"array type mismatch")
 
 /*
@@ -88,19 +88,19 @@
 #define SAFE_ARRAY_READ(_a, _i, _v)	\
 ({					\
 	CHECK_ARRAY_TYPE(_a, _v);	\
-	if (_i >= ARRAY_SIZE(_a)) {	\
+	if ((_i) >= ARRAY_SIZE(_a)) {	\
 		panic();		\
 	}				\
-	_v = _a[_i];			\
+	(_v) = (_a)[_i];			\
 })
 
 #define SAFE_ARRAY_WRITE(_a, _i, _v)	\
 ({					\
 	CHECK_ARRAY_TYPE(_a, _v);	\
-	if (_i >= ARRAY_SIZE(_a)) {	\
+	if ((_i) >= ARRAY_SIZE(_a)) {	\
 		panic();		\
 	}				\
-	_a[_i] = _v;			\
+	(_a)[_i] = (_v);			\
 })
 
 #define COMPILER_ASSERT(_condition)	\
@@ -120,7 +120,7 @@
 
 #define CHECK_TYPE_IS_ARRAY(_v) \
 	COMPILER_ASSERT_ZERO(!__builtin_types_compatible_p(typeof(_v),	\
-							typeof(&(_v[0]))))
+							typeof(&((_v)[0]))))
 
 #define IS_POWER_OF_TWO(x)			\
 	((((x) + UL(0)) & ((x) - UL(1))) == UL(0))
@@ -132,9 +132,9 @@
 
 #define GRANULE_ALIGNED(_addr) ALIGNED((void *)(_addr), GRANULE_SIZE)
 #define ALIGNED_TO_ARRAY(_addr, _array)		\
-			(((uintptr_t)_addr >= (uintptr_t)&_array[0]) && \
-			 ((((uintptr_t)_addr - (uintptr_t)&_array[0]) % \
-						sizeof(_array[0])) == UL(0)))
+			(((uintptr_t)(_addr) >= (uintptr_t)&(_array)[0]) && \
+			 ((((uintptr_t)(_addr) - (uintptr_t)&(_array)[0]) % \
+						sizeof((_array)[0])) == UL(0)))
 
 #define GRANULE_SIZE	(UL(1) << GRANULE_SHIFT)
 #define GRANULE_MASK	(~(GRANULE_SIZE - 1U))