fix(static-checks): fix cppcheck warnings
Fix some cppcheck warnings.
Signed-off-by: Shruti Gupta <shruti.gupta@arm.com>
Change-Id: I3f47ef5a54924d48c5e78cc3a38cc3d7508b24aa
diff --git a/runtime/core/sysregs.c b/runtime/core/sysregs.c
index af263ba..b2f7a66 100644
--- a/runtime/core/sysregs.c
+++ b/runtime/core/sysregs.c
@@ -177,19 +177,18 @@
* Rt bits [9:5] of ISS field cannot exceed 0b11111.
*/
unsigned int rt = ESR_EL2_SYSREG_ISS_RT(esr);
- unsigned int i;
unsigned int __unused op0, op1, crn, crm, op2;
unsigned long __unused sysreg;
/* Check for 32-bit instruction trapped */
assert(ESR_IL(esr) != 0UL);
- for (i = 0U; i < ARRAY_LEN(sysreg_handlers); i++) {
+ for (unsigned int i = 0U; i < ARRAY_LEN(sysreg_handlers); i++) {
const struct sysreg_handler *handler = &sysreg_handlers[i];
- bool handled;
if ((esr & handler->esr_mask) == handler->esr_value) {
- handled = handler->fn(rec, rec_exit, esr);
+ bool handled = handler->fn(rec, rec_exit, esr);
+
if (!handled) {
emulate_sysreg_access_ns(rec, rec_exit, esr);
}