commit 9debb1397eb5c548d89f3dca6e00b8f9c1034916
author Shruti Gupta <shruti.gupta@arm.com> Tue Dec 13 14:38:49 2022 +0000
committer Soby Mathew <soby.mathew@arm.com> Mon Jan 16 17:05:43 2023 +0200
tree bcfd0cebfb693c02cc99258e53b5bc2990ef3085
parent b2c6071ddd6c073438ab1d30e16130606009f998

fix(static-checks): fix cppcheck warnings

Fix some cppcheck warnings.

Signed-off-by: Shruti Gupta <shruti.gupta@arm.com>
Change-Id: I3f47ef5a54924d48c5e78cc3a38cc3d7508b24aa

lib/attestation/src/attestation_rnd.c

diff --git a/lib/attestation/src/attestation_rnd.c b/lib/attestation/src/attestation_rnd.c
index bd2a9a5..b48d6b7 100644
--- a/lib/attestation/src/attestation_rnd.c
+++ b/lib/attestation/src/attestation_rnd.c
@@ -26,7 +26,6 @@
 
 static int get_random_seed(unsigned char *output, size_t len)
 {
-	bool rc;
 	uint64_t *random_output;
 	uint64_t *random_end;
 
@@ -39,6 +38,8 @@
 	random_end = (uint64_t *)(output + len);
 
 	for (; random_output < random_end; ++random_output) {
+		bool rc = false;
+
 		rc = arch_collect_entropy(random_output);
 		if (!rc) {
 			return -EINVAL;

lib/attestation/src/attestation_utils.c

diff --git a/lib/attestation/src/attestation_utils.c b/lib/attestation/src/attestation_utils.c
index 31a5189..c985f74 100644
--- a/lib/attestation/src/attestation_utils.c
+++ b/lib/attestation/src/attestation_utils.c
@@ -120,10 +120,8 @@
 	return 0;
 }
 
-int attestation_heap_ctx_unassign_pe(struct buffer_alloc_ctx *ctx)
+int attestation_heap_ctx_unassign_pe(void)
 {
-	assert(ctx != NULL);
-
 	if (attest_initialized == false) {
 		return -EINVAL;
 	}