fix(fvp): supress Coverity out-of-bounds warning
Function plat_setup() sets maximum number of
platform's DRAM banks by passing MAX_DRAM_NUM_BANKS
value to rmm_el3_ifc_get_dram_data_validated_pa().
For FVP platform MAX_DRAM_NUM_BANKS is 2, and if
number of banks exceeds this value, error code
E_RMM_BOOT_MANIFEST_DATA_ERROR is returned.
Later call from plat_setup() to fvp_set_dram_layout()
passes 'plat_dram' pointer to 'ns_dram_info'
structure with 'num_banks' field which contains
number of platform's DRAM banks.
Although this value cannot be greater than
MAX_DRAM_NUM_BANKS because of the previous check in
rmm_el3_ifc_get_dram_data_validated_pa(), Coverity
scan reports the warning below
"Out-of-bounds write (OVERRUN).
overrun-local: Overrunning array fvp_dram->fvp_bank
of 2 16-byte elements at element index 2 (byte offset 47)
using index i (which evaluates to 2)."
To supress this warning the patch adds assertion
for testing 'num_banks' <= MAX_DRAM_NUM_BANKS condition.
Signed-off-by: AlexeiFedorov <Alexei.Fedorov@arm.com>
Change-Id: I1fcb7904fbab1ea551ec5ead46850924b0594add
diff --git a/plat/fvp/src/fvp_memory.c b/plat/fvp/src/fvp_memory.c
index c45645b..f3fc9e9 100644
--- a/plat/fvp/src/fvp_memory.c
+++ b/plat/fvp/src/fvp_memory.c
@@ -19,6 +19,7 @@
/* Number of banks */
num_banks = plat_dram->num_banks;
+ assert(num_banks <= MAX_DRAM_NUM_BANKS);
/* Pointer to dram_bank[] array */
bank_ptr = plat_dram->banks;