commit 995785602c941dbaeb17839ffad1a284d97644ad
author Hugues de Valon <hugues.devalon@arm.com> Tue Jun 18 16:08:51 2019 +0100
committer Máté Tóth-Pál <Mate.Toth-Pal@arm.com> Thu Jul 18 11:01:52 2019 +0000
tree c7327e1b9116487b3415f44f6f2bec322788f5b3
parent a0c75a2a4e6f5090b88e5c8bd67346881764c7c7

Core: Improve code quality

This patch fixes the following things:
* avoid implicit casting by using matching types or casting
* avoid implicit casting between enum tfm_buffer_share_region_e and
uint32_t types by replacing the enumerated type with uint32_t and its
constants with preprocessor constants
* make explicit that the return value of a function is not used
* remove function return type if not needed
* replace preprocessor if condition by ifdef if only definition is
  checked
* replace enumerated types not used by preprocessor constants

Change-Id: Ib718937f89631cae2212de1fc748c48461b683d0
Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>

platform/ext/target/mps2/an519/spm_hal.c

diff --git a/platform/ext/target/mps2/an519/spm_hal.c b/platform/ext/target/mps2/an519/spm_hal.c
index 1c07116..d25f30f 100644
--- a/platform/ext/target/mps2/an519/spm_hal.c
+++ b/platform/ext/target/mps2/an519/spm_hal.c
@@ -282,8 +282,7 @@
 /**
  * Set share region to which the partition needs access
  */
-enum spm_err_t tfm_spm_hal_set_share_region(
-        enum tfm_buffer_share_region_e share)
+enum spm_err_t tfm_spm_hal_set_share_region(uint32_t share)
 {
     struct mpu_armv8m_region_cfg_t region_cfg;
     enum spm_err_t res = SPM_ERR_INVALID_CONFIG;

platform/ext/target/mps2/an521/spm_hal.c

diff --git a/platform/ext/target/mps2/an521/spm_hal.c b/platform/ext/target/mps2/an521/spm_hal.c
index bc91d41..183d448 100644
--- a/platform/ext/target/mps2/an521/spm_hal.c
+++ b/platform/ext/target/mps2/an521/spm_hal.c
@@ -282,8 +282,7 @@
 /**
  * Set share region to which the partition needs access
  */
-enum spm_err_t tfm_spm_hal_set_share_region(
-                                           enum tfm_buffer_share_region_e share)
+enum spm_err_t tfm_spm_hal_set_share_region(uint32_t share)
 {
     struct mpu_armv8m_region_cfg_t region_cfg;
     enum spm_err_t res = SPM_ERR_INVALID_CONFIG;

platform/ext/target/musca_a/spm_hal.c

diff --git a/platform/ext/target/musca_a/spm_hal.c b/platform/ext/target/musca_a/spm_hal.c
index 5637aaf..7bb8159 100644
--- a/platform/ext/target/musca_a/spm_hal.c
+++ b/platform/ext/target/musca_a/spm_hal.c
@@ -282,8 +282,7 @@
 /**
  * Set share region to which the partition needs access
  */
-enum spm_err_t tfm_spm_hal_set_share_region(
-        enum tfm_buffer_share_region_e share)
+enum spm_err_t tfm_spm_hal_set_share_region(uint32_t share)
 {
     struct mpu_armv8m_region_cfg_t region_cfg;
     enum spm_err_t res = SPM_ERR_INVALID_CONFIG;

platform/ext/target/musca_b1/spm_hal.c

diff --git a/platform/ext/target/musca_b1/spm_hal.c b/platform/ext/target/musca_b1/spm_hal.c
index 84fc144..2ab6f68 100644
--- a/platform/ext/target/musca_b1/spm_hal.c
+++ b/platform/ext/target/musca_b1/spm_hal.c
@@ -282,8 +282,7 @@
 /**
  * Set share region to which the partition needs access
  */
-enum spm_err_t tfm_spm_hal_set_share_region(
-        enum tfm_buffer_share_region_e share)
+enum spm_err_t tfm_spm_hal_set_share_region(uint32_t share)
 {
     struct mpu_armv8m_region_cfg_t region_cfg;
     enum spm_err_t res = SPM_ERR_INVALID_CONFIG;

platform/include/tfm_spm_hal.h

diff --git a/platform/include/tfm_spm_hal.h b/platform/include/tfm_spm_hal.h
index cb54186..9f1e7a6 100644
--- a/platform/include/tfm_spm_hal.h
+++ b/platform/include/tfm_spm_hal.h
@@ -237,8 +237,7 @@
  *
  * \return Returns the result operation as per \ref spm_err_t
  */
-enum spm_err_t tfm_spm_hal_set_share_region(
-                                          enum tfm_buffer_share_region_e share);
+enum spm_err_t tfm_spm_hal_set_share_region(uint32_t share);
 #endif
 
 #endif /* __TFM_SPM_HAL_H__ */