Reintroduce the Code-Review label.
Following on some discussions on the TF-A mailing list, we have decided
that we need to reintroduce the Code-Review label. Contributors that are
neither code owners for the patch nor maintainers are not expected to
vote on the Code-Owner-Review / Maintainer-Review labels so they need
another label to record their concerns/approval. This latter label is
purely informational and will not determine whether a patch is
submittable but it might influence the code owners'/maintainers'
decision.
Signed-off-by: Sandrine Bailleux <sandrine.bailleux@arm.com>
Change-Id: I0acd201f970c58ce3d9aa4bf511ed8c5d78e22fc
diff --git a/project.config b/project.config
index c015777..1fa5df2 100644
--- a/project.config
+++ b/project.config
@@ -22,6 +22,7 @@
removeReviewer = group trusted-firmware-a-ci-users
abandon = group trusted-firmware-a-approvers
+ label-Code-Review = -1..+1 group Registered Users
label-Code-Owner-Review = -1..+1 group Registered Users
label-Maintainer-Review = -1..+1 group trusted-firmware-a-approvers
@@ -38,19 +39,19 @@
createTag = group trusted-firmware-a-approvers
createSignedTag = group trusted-firmware-a-approvers
-[label "Verified"]
- function = MaxWithBlock
- value = -1 Fails
+# The Code-Review label is purely informational. Contributors that are neither
+# code owners for the patch nor maintainers use it to record their concerns.
+[label "Code-Review"]
+ function = NoBlock
+ value = -1 I would prefer this is not merged as is
value = 0 No score
- value = +1 Verified
+ value = +1 Looks good to me
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
defaultValue = 0
-# Remove default "Code-Review" label by redefining it as empty.
-[label "Code-Review"]
-
-# Instead define our 2 custom labels for code review.
+# In addition, define our 2 custom labels for code review.
+# These influence whether a patch is submittable.
[label "Code-Owner-Review"]
function = MaxWithBlock
value = -1 I would prefer this is not merged as is
@@ -69,6 +70,8 @@
copyAllScoresOnTrivialRebase = true
defaultValue = 0
+# The Allow-CI label triggers the internal Arm CI on the patch.
+# It sets the Verified score.
[label "Allow-CI"]
function = NoBlock
value = 0 No score
@@ -76,6 +79,15 @@
value = +2 Approved for automated testing, in-depth tests
defaultValue = 0
+[label "Verified"]
+ function = MaxWithBlock
+ value = -1 Fails
+ value = 0 No score
+ value = +1 Verified
+ copyAllScoresIfNoCodeChange = true
+ copyAllScoresOnTrivialRebase = true
+ defaultValue = 0
+
[access "refs/meta/dashboards/*"]
create = group trusted-firmware-a-approvers
push = group trusted-firmware-a-approvers