regression 1022: return TEE_ERROR_GENERIC on failure
When dlopen() or dlsym() fail in regression test 1022, the error status
is set to TEE_ERROR_OUT_OF_MEMORY which is inappropriate since the true
cause of the error is unknown. Use TEE_ERROR_GENERIC instead. This is
essentially cosmetic to avoid confusion when debugging.
Signed-off-by: Jerome Forissier <jerome@forissier.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
diff --git a/ta/os_test/os_test.c b/ta/os_test/os_test.c
index 7087789..1409470 100644
--- a/ta/os_test/os_test.c
+++ b/ta/os_test/os_test.c
@@ -1114,7 +1114,7 @@
handle = dlopen("b3091a65-9751-4784-abf7-0298a7cc35ba",
RTLD_NOW | RTLD_GLOBAL | RTLD_NODELETE);
if (!handle)
- return TEE_ERROR_OUT_OF_MEMORY;
+ return TEE_ERROR_GENERIC;
add_func = dlsym(handle, "os_test_shlib_dl_add");
if (!add_func)
@@ -1123,10 +1123,8 @@
goto err;
hnull = dlopen(NULL, RTLD_NOW | RTLD_GLOBAL | RTLD_NODELETE);
- if (!hnull) {
- res = TEE_ERROR_OUT_OF_MEMORY;
+ if (!hnull)
goto err;
- }
add_func = dlsym(hnull, "os_test_shlib_dl_add");
if (!add_func)