commit 659e221d3aa43ce6ef38f592d38a9820df155ef8
author Jerome Forissier <jerome@forissier.org> Tue Oct 27 18:39:05 2020 +0100
committer Jérôme Forissier <jerome@forissier.org> Wed Oct 28 10:01:51 2020 +0100
tree 24fea5ccec121bf56a4267f2dd060238648f3987
parent 159e295d5cc3ad2275ab15fe544620f6604d4ba4

xtest: remove __unused and do not include <compiler.h>

xtest (the 'host' part, not the TAs) uses __unused from OP-TEE's
<compiler.h>. This does not comply with the following statement from
the C specification:

 In addition to the names documented in this manual, reserved names
 include all external identifiers (global functions and variables)
 that begin with an underscore (‘_’) and all identifiers regardless of
 use that begin with either two underscores or an underscore followed
 by a capital letter are reserved names. This is so that the library
 and header files can define functions, variables, and macros for
 internal purposes without risk of conflict with names in user
 programs.

This is not a hypothetical problem, __unused is used by musl and as
such optee-test can't be built with musl.

<compiler.h> and __unused should only be used in TAs (in which case we
know the C library is OP-TEE's libutils). Remove them from xtest and add
-Wno-unused-param to the C flags instead.

Reported-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Jerome Forissier <jerome@forissier.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>