commit 102092ed689a22f5522e5934a4d94b65507f6277
author Etienne Carriere <etienne.carriere@linaro.org> Thu Mar 28 15:24:22 2019 +0100
committer Jérôme Forissier <jerome.forissier@linaro.org> Fri Apr 12 17:38:26 2019 +0200
tree 261ed15b914696fabef29f6c7f0fb0839de007fa
parent 895c5caa9070a134bc12acdc6d0ad0354aa1f644

TAs: explicitly initialize local variables

This change initializes all local variables to prevent build issues
(warnings and/or errors) in OP-TEE test package. This change uses
= { } for non-scalar variables and = 0 for scalar variables.

This change also removes some useless header files inclusion.
This change also fixes few bad indentations.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

ta/sdp_basic/ta_sdp_basic.c

diff --git a/ta/sdp_basic/ta_sdp_basic.c b/ta/sdp_basic/ta_sdp_basic.c
index 7f3ab41..aa2e65c 100644
--- a/ta/sdp_basic/ta_sdp_basic.c
+++ b/ta/sdp_basic/ta_sdp_basic.c
@@ -45,7 +45,7 @@
 static TEE_Result cmd_inject(uint32_t types,
 			     TEE_Param params[TEE_NUM_PARAMS])
 {
-	TEE_Result rc;
+	TEE_Result rc = TEE_ERROR_GENERIC;
 	const int sec_idx = 1;		/* highlight secure buffer index */
 	const int ns_idx = 0;		/* highlight nonsecure buffer index */
 
@@ -128,9 +128,9 @@
 static TEE_Result cmd_transform(uint32_t types,
 				TEE_Param params[TEE_NUM_PARAMS])
 {
-	TEE_Result rc;
-	unsigned char *p;
-	size_t sz;
+	TEE_Result rc = TEE_ERROR_GENERIC;
+	unsigned char *p = NULL;
+	size_t sz = 0;
 
 	if (types != TEE_PARAM_TYPES(TEE_PARAM_TYPE_MEMREF_INOUT,
 				     TEE_PARAM_TYPE_NONE,
@@ -198,7 +198,7 @@
 static TEE_Result cmd_dump(uint32_t types,
 			   TEE_Param params[TEE_NUM_PARAMS])
 {
-	TEE_Result rc;
+	TEE_Result rc = TEE_ERROR_GENERIC;
 	const int sec_idx = 0;		/* highlight secure buffer index */
 	const int ns_idx = 1;		/* highlight nonsecure buffer index */
 
@@ -270,8 +270,8 @@
 {
         const TEE_UUID uuid = TA_SDP_BASIC_UUID;
         static TEE_TASessionHandle sess = TEE_HANDLE_NULL;
-        uint32_t ret_orig;
-        TEE_Result res;
+        uint32_t ret_orig = 0;
+        TEE_Result res = TEE_ERROR_GENERIC;
 
 	if (sess == TEE_HANDLE_NULL) {
 	        res = TEE_OpenTASession(&uuid, 0, 0, NULL, &sess, &ret_orig);
@@ -302,8 +302,8 @@
 {
         const TEE_UUID uuid = PTA_INVOKE_TESTS_UUID;
         static TEE_TASessionHandle sess = TEE_HANDLE_NULL;
-        uint32_t ret_orig;
-        TEE_Result res;
+        uint32_t ret_orig = 0;
+        TEE_Result res = TEE_ERROR_GENERIC;
 
 	if (sess == TEE_HANDLE_NULL) {
 	        res = TEE_OpenTASession(&uuid, 0, 0, NULL, &sess, &ret_orig);