commit 8ff963a60211f7f3bd9d70c8755e3e781ad7643f
author Jens Wiklander <jens.wiklander@linaro.org> Thu Jan 17 11:14:38 2019 +0100
committer Jérôme Forissier <jerome.forissier@linaro.org> Thu Jan 17 14:07:57 2019 +0100
tree b8e64da309b1b8d87b79c58a9c7ca2eaa0da3939
parent 213cce52a6047731cfa847fcf56bee95e6aeb1bd

mbedtls: fix memory leak in mpi_miller_rabin()

Fixes memory leak in mpi_miller_rabin() that occurs when the function has
failed to obtain a usable random 'A' 300 turns in a row.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

lib/libmbedtls/mbedtls/library/bignum.c

diff --git a/lib/libmbedtls/mbedtls/library/bignum.c b/lib/libmbedtls/mbedtls/library/bignum.c
index a21af82..405cf52 100644
--- a/lib/libmbedtls/mbedtls/library/bignum.c
+++ b/lib/libmbedtls/mbedtls/library/bignum.c
@@ -2180,7 +2180,8 @@
             }
 
             if (count++ > 300) {
-                return MBEDTLS_ERR_MPI_NOT_ACCEPTABLE;
+                ret = MBEDTLS_ERR_MPI_NOT_ACCEPTABLE;
+                goto cleanup;
             }
 
         } while ( mbedtls_mpi_cmp_mpi( &A, &W ) >= 0 ||