commit ae499f6a39f395801dff7f5353cb7424500f648a
author Jens Wiklander <jens.wiklander@linaro.org> Wed Apr 17 12:25:20 2019 +0200
committer Joakim Bech <joakim.bech@linaro.org> Wed Apr 17 21:42:17 2019 +0700
tree e5afcdd47174d0ac8ddfad0f6b5baa8898808ff8
parent b95a6c5de200b12b985daab883edcfe0918be097

libmbedtls: mbedtls_mpi_exp_mod() initialize W

Initialize W using mbedtls_mpi_init_mempool() instead of memset() to
ensure that the temporary variable uses the designated memory pool if
configured.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

lib/libmbedtls/mbedtls/library/bignum.c

diff --git a/lib/libmbedtls/mbedtls/library/bignum.c b/lib/libmbedtls/mbedtls/library/bignum.c
index 1c0e675..5d4beca 100644
--- a/lib/libmbedtls/mbedtls/library/bignum.c
+++ b/lib/libmbedtls/mbedtls/library/bignum.c
@@ -60,6 +60,7 @@
 #endif
 
 #include <mempool.h>
+#include <util.h>
 
 #define MPI_VALIDATE_RET( cond )                                       \
     MBEDTLS_INTERNAL_VALIDATE_RET( cond, MBEDTLS_ERR_MPI_BAD_INPUT_DATA )
@@ -1805,7 +1806,8 @@
     mbedtls_mpi_montg_init( &mm, N );
     mbedtls_mpi_init_mempool( &RR ); mbedtls_mpi_init_mempool( &T );
     mbedtls_mpi_init_mempool( &Apos );
-    memset( W, 0, sizeof( W ) );
+    for( i = 0; i < ARRAY_SIZE(W); i++ )
+        mbedtls_mpi_init_mempool( W + i );
 
     i = mbedtls_mpi_bitlen( E );
 
@@ -1977,10 +1979,10 @@
 
 cleanup:
 
-    for( i = ( one << ( wsize - 1 ) ); i < ( one << wsize ); i++ )
-        mbedtls_mpi_free( &W[i] );
+    for( i = 0; i < ARRAY_SIZE(W); i++ )
+        mbedtls_mpi_free( W + i );
 
-    mbedtls_mpi_free( &W[1] ); mbedtls_mpi_free( &T ); mbedtls_mpi_free( &Apos );
+    mbedtls_mpi_free( &T ); mbedtls_mpi_free( &Apos );
 
     if( _RR == NULL || _RR->p == NULL )
         mbedtls_mpi_free( &RR );