commit 9b0818d48d29024624decdadc5d273904201d3ae
author Jens Wiklander <jens.wiklander@linaro.org> Thu Jan 17 11:14:38 2019 +0100
committer Jérôme Forissier <jerome.forissier@linaro.org> Wed Mar 20 14:04:44 2019 +0100
tree 6fd5d415464475e043ebad9d48af275f3421f52f
parent 2d6644ee0bbe38b29b51a0b8d8873de74acb2187

mbedtls: fix memory leak in mpi_miller_rabin()

Fixes memory leak in mpi_miller_rabin() that occurs when the function has
failed to obtain a usable random 'A' 300 turns in a row.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

lib/libmbedtls/mbedtls/library/bignum.c

diff --git a/lib/libmbedtls/mbedtls/library/bignum.c b/lib/libmbedtls/mbedtls/library/bignum.c
index 7094f89..1c0e675 100644
--- a/lib/libmbedtls/mbedtls/library/bignum.c
+++ b/lib/libmbedtls/mbedtls/library/bignum.c
@@ -2277,7 +2277,8 @@
             }
 
             if (count++ > 300) {
-                return MBEDTLS_ERR_MPI_NOT_ACCEPTABLE;
+                ret = MBEDTLS_ERR_MPI_NOT_ACCEPTABLE;
+                goto cleanup;
             }
 
         } while ( mbedtls_mpi_cmp_mpi( &A, &W ) >= 0 ||