| commit | e41292930099f5383aca72030f884e943525a584 | [log] [tgz] |
|---|---|---|
| author | Jerome Forissier <jerome.forissier@linaro.org> | Tue Nov 08 10:45:23 2022 +0100 |
| committer | Jérôme Forissier <jerome@forissier.org> | Wed Nov 09 10:06:03 2022 +0100 |
| tree | 5d0a47af60279da427f56825e0195677099cda5e | |
| parent | 49f9eb285b86510d25e208c95056cd5104777bec [diff] |
trusted-keys.exp: fix error detection
The check_keyctl_result() procedure doesn't deal with all error cases
properly. For example the following error is not reported:
# keyctl add trusted kmk "new 32" @u
[ 7.293607] trusted-key-tee optee-ta-f04a0fe7-1f5d-4b9b-abf7-619b85b4ce8c: key shm register failed
add_key: Invalid argument
#
To make things simpler, rely on the exit status of the commands sent to
the guest. The || shell construct is used to trigger the display of an
error message ("FAILED"). To avoid having the message in the command
themselves, which would make the parsing more complex, a shell function
is introduced ("fail"). Then all the check_keyctl_result() procedure
needs to do is wait for the next prompt ("# "), while dealing with
errors (the "FAILED" word appearing anywhere), key ID (parsing is
unchanged), and timeouts (which I have reduced to 5 seconds, more than
enough for any operation in this test suite).
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
This git contains makefiles etc to be able to build a full OP-TEE developer setup for the OP-TEE project.
All official OP-TEE documentation has moved to http://optee.readthedocs.io. The pages that used to be here in this git can be found under build and Device specific information at he new location for the OP-TEE documentation.
// OP-TEE core maintainers